[{"id":3325,"web_url":"https://patchwork.libcamera.org/comment/3325/","msgid":"","date":"2020-01-06T16:58:48","subject":"Re: [libcamera-devel] [PATCH 2/4] v4l2: camera_proxy: Return\n\tcorrect type from VIDIOC_G_FMT","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 06/01/2020 16:14, Laurent Pinchart wrote:\n> The VIDIOC_G_FMT implementation overwrites the v4l2_format type field\n> with 0. Fix it.\n\n\nCould you clarify this please?\n\nYou mean the kernel changes the arg->type?\n\nThe whole function reads as:\n\nint V4L2CameraProxy::vidioc_g_fmt(struct v4l2_format *arg)\n{\n LOG(V4L2Compat, Debug) << \"Servicing vidioc_g_fmt\";\n\n if (!validateBufferType(arg->type))\n return -EINVAL;\n\n memset(&arg->fmt, 0, sizeof(arg->fmt));\n> +\targ->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; /* LP-Addition */\n arg->fmt.pix = curV4L2Format_.fmt.pix;\n\n return 0;\n}\n\n\nI see usage of arg->type in the validateBufferType before the memset.\n\nDoes this need to be set correctly before that ? or otherwise what is\nthe purpose of the call to validateBufferType(arg->type)?\n\n--\nKieran\n\n\n\n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 2eeb12396d90..dd3ee3e6c6ff 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -229,6 +229,7 @@ int V4L2CameraProxy::vidioc_g_fmt(struct v4l2_format *arg)\n> \t\treturn -EINVAL;\n> \n> \tmemset(&arg->fmt, 0, sizeof(arg->fmt));\n> +\targ->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;\n> \targ->fmt.pix = curV4L2Format_.fmt.pix;\n> \n> \treturn 0;\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F1F660612\n\tfor ;\n\tMon, 6 Jan 2020 17:58:52 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6919C52F;\n\tMon, 6 Jan 2020 17:58:51 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1578329931;\n\tbh=TTLICXmTCPg9gttcBmI+FHyJ0TFmCrTl9lkWbP2uC7c=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=YyL+zIImK+qbmbhW0Csc3XWsLWWwOZp+DyShRnS1+yXMGi7HQvBa7Rv0ZhoEg9ShH\n\tCgZ2pf5VgVLfXA9xFkokPsD07iMeU0+qz8LofBGfBDn2Fb7+QyxHBW7+7dvAOEm30n\n\td2KDflAsEOun5AZ/q0V9MyQ/Ez0K2qtZNprEymPI=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200106161417.19150-1-laurent.pinchart@ideasonboard.com>\n\t<20200106161417.19150-3-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 6 Jan 2020 16:58:48 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.0","MIME-Version":"1.0","In-Reply-To":"<20200106161417.19150-3-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 2/4] v4l2: camera_proxy: Return\n\tcorrect type from VIDIOC_G_FMT","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 06 Jan 2020 16:58:52 -0000"}},{"id":3330,"web_url":"https://patchwork.libcamera.org/comment/3330/","msgid":"<20200106171145.GA22189@pendragon.ideasonboard.com>","date":"2020-01-06T17:11:45","subject":"Re: [libcamera-devel] [PATCH 2/4] v4l2: camera_proxy: Return\n\tcorrect type from VIDIOC_G_FMT","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Jan 06, 2020 at 04:58:48PM +0000, Kieran Bingham wrote:\n> On 06/01/2020 16:14, Laurent Pinchart wrote:\n> > The VIDIOC_G_FMT implementation overwrites the v4l2_format type field\n> > with 0. Fix it.\n> \n> Could you clarify this please?\n> \n> You mean the kernel changes the arg->type?\n> \n> The whole function reads as:\n> \n> int V4L2CameraProxy::vidioc_g_fmt(struct v4l2_format *arg)\n> {\n> LOG(V4L2Compat, Debug) << \"Servicing vidioc_g_fmt\";\n> \n> if (!validateBufferType(arg->type))\n> return -EINVAL;\n> \n> memset(&arg->fmt, 0, sizeof(arg->fmt));\n> > +\targ->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; /* LP-Addition */\n> arg->fmt.pix = curV4L2Format_.fmt.pix;\n> \n> return 0;\n> }\n> \n> \n> I see usage of arg->type in the validateBufferType before the memset.\n> \n> Does this need to be set correctly before that ? or otherwise what is\n> the purpose of the call to validateBufferType(arg->type)?\n\nI meant that *our* implementation of VIDIOC_G_FMT unconditionally sets\narg->type to 0 (due to the memset). It's incorrect, the field should\nretain its value. And now that I've written this, I realize that we only\nmemset arg->fmt, not arg... I'll drop this patch :-)\n\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/v4l2/v4l2_camera_proxy.cpp | 1 +\n> > 1 file changed, 1 insertion(+)\n> > \n> > diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> > index 2eeb12396d90..dd3ee3e6c6ff 100644\n> > --- a/src/v4l2/v4l2_camera_proxy.cpp\n> > +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> > @@ -229,6 +229,7 @@ int V4L2CameraProxy::vidioc_g_fmt(struct v4l2_format *arg)\n> > \t\treturn -EINVAL;\n> > \n> > \tmemset(&arg->fmt, 0, sizeof(arg->fmt));\n> > +\targ->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;\n> > \targ->fmt.pix = curV4L2Format_.fmt.pix;\n> > \n> > \treturn 0;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9525460612\n\tfor ;\n\tMon, 6 Jan 2020 18:11:55 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3856852F;\n\tMon, 6 Jan 2020 18:11:55 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1578330715;\n\tbh=Ji+1LySkSHcDNe0/FaGc1I2xRAiUE2EAxFRW6pK3aVQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JL6PLEbL6maSm0nuFRMDijYLhCQwTcmEV7pmvYzSRv7cZigr/4Lfl1tBOuu3Ts1an\n\txA6stafgbJXJaeK6cA4s50onWmsYnnQ9ygLbtOqAxloDv53ynrSn7d+kBL2VijL8ju\n\tdpQV9DFUeMxRdiYXuYvMubLa5JFeX1UhLbdtecOQ=","Date":"Mon, 6 Jan 2020 19:11:45 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200106171145.GA22189@pendragon.ideasonboard.com>","References":"<20200106161417.19150-1-laurent.pinchart@ideasonboard.com>\n\t<20200106161417.19150-3-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/4] v4l2: camera_proxy: Return\n\tcorrect type from VIDIOC_G_FMT","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 06 Jan 2020 17:11:55 -0000"}},{"id":3331,"web_url":"https://patchwork.libcamera.org/comment/3331/","msgid":"","date":"2020-01-06T17:26:34","subject":"Re: [libcamera-devel] [PATCH 2/4] v4l2: camera_proxy: Return\n\tcorrect type from VIDIOC_G_FMT","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 06/01/2020 17:11, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Mon, Jan 06, 2020 at 04:58:48PM +0000, Kieran Bingham wrote:\n>> On 06/01/2020 16:14, Laurent Pinchart wrote:\n>>> The VIDIOC_G_FMT implementation overwrites the v4l2_format type field\n>>> with 0. Fix it.\n>>\n>> Could you clarify this please?\n>>\n>> You mean the kernel changes the arg->type?\n>>\n>> The whole function reads as:\n>>\n>> int V4L2CameraProxy::vidioc_g_fmt(struct v4l2_format *arg)\n>> {\n>> LOG(V4L2Compat, Debug) << \"Servicing vidioc_g_fmt\";\n>>\n>> if (!validateBufferType(arg->type))\n>> return -EINVAL;\n>>\n>> memset(&arg->fmt, 0, sizeof(arg->fmt));\n>>> +\targ->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; /* LP-Addition */\n>> arg->fmt.pix = curV4L2Format_.fmt.pix;\n>>\n>> return 0;\n>> }\n>>\n>>\n>> I see usage of arg->type in the validateBufferType before the memset.\n>>\n>> Does this need to be set correctly before that ? or otherwise what is\n>> the purpose of the call to validateBufferType(arg->type)?\n> \n> I meant that *our* implementation of VIDIOC_G_FMT unconditionally sets\n> arg->type to 0 (due to the memset). It's incorrect, the field should\n\nbut ....\n\n> retain its value. And now that I've written this, I realize that we only\n> memset arg->fmt, not arg... I'll drop this patch :-)\n\n\nAha - there we go then :-D\n\nI thought it was an odd looking patch!\n\n--\nKieran\n\n\n\n> \n>>> Signed-off-by: Laurent Pinchart \n>>> ---\n>>> src/v4l2/v4l2_camera_proxy.cpp | 1 +\n>>> 1 file changed, 1 insertion(+)\n>>>\n>>> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n>>> index 2eeb12396d90..dd3ee3e6c6ff 100644\n>>> --- a/src/v4l2/v4l2_camera_proxy.cpp\n>>> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n>>> @@ -229,6 +229,7 @@ int V4L2CameraProxy::vidioc_g_fmt(struct v4l2_format *arg)\n>>> \t\treturn -EINVAL;\n>>> \n>>> \tmemset(&arg->fmt, 0, sizeof(arg->fmt));\n>>> +\targ->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;\n>>> \targ->fmt.pix = curV4L2Format_.fmt.pix;\n>>> \n>>> \treturn 0;\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C74160612\n\tfor ;\n\tMon, 6 Jan 2020 18:26:38 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EA90552F;\n\tMon, 6 Jan 2020 18:26:37 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1578331598;\n\tbh=RmoAh66OGoH237i3i54Wtq/u6RjZxf/1sxbz9ig8JDQ=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=uEJZ5w7CKQGvvS5tAfcA+CizUmVH99rc0gcrlzGO2vVKYPX74zxc3gC6R0Ovw2z38\n\tew3shP0UFomCzPCtK1LXSoGo5B/i1rP5/LSQLIcJBp3TgnT8zYQWKH603AZ0RAFei8\n\tGeS9xe4nWNA10XSGaGJFSKKP2w+wjS/qVqq1jp5I=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20200106161417.19150-1-laurent.pinchart@ideasonboard.com>\n\t<20200106161417.19150-3-laurent.pinchart@ideasonboard.com>\n\t\n\t<20200106171145.GA22189@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 6 Jan 2020 17:26:34 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.0","MIME-Version":"1.0","In-Reply-To":"<20200106171145.GA22189@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 2/4] v4l2: camera_proxy: Return\n\tcorrect type from VIDIOC_G_FMT","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 06 Jan 2020 17:26:38 -0000"}}]