{"id":25158,"url":"https://patchwork.libcamera.org/api/patches/25158/?format=json","web_url":"https://patchwork.libcamera.org/patch/25158/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251123203228.3462026-1-rui.wang@ideasonboard.com>","date":"2025-11-23T20:32:28","name":"[[PATCH,v1] ] media: rkisp1: Fix filter mode register configuration to handle enable and DNR bits separately","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5d41e1ee4539d6eaa19edaecca8ba304f463e47c","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25158/mbox/","series":[{"id":5608,"url":"https://patchwork.libcamera.org/api/series/5608/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5608","date":"2025-11-23T20:32:28","name":"[[PATCH,v1] ] media: rkisp1: Fix filter mode register configuration to handle enable and DNR bits separately","version":1,"mbox":"https://patchwork.libcamera.org/series/5608/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25158/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25158/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4B31CC3336\n\tfor ;\n\tSun, 23 Nov 2025 20:32:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8237B60A80;\n\tSun, 23 Nov 2025 21:32:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 792F1608CF\n\tfor ;\n\tSun, 23 Nov 2025 21:32:36 +0100 (CET)","from rui-Precision-7560.local (unknown [209.171.85.75])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 55E89606;\n\tSun, 23 Nov 2025 21:30:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lUEInwY/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763929828;\n\tbh=fHIi8H4QtFXebb4CdezvbnzBd9uc9qv0MRW0NFmwQyc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=lUEInwY/H/scB4ht8BFa9POrD9k3fbVjKJaNn9uK3VCefLf5IicUtQ3dHN31g4ZOU\n\tR5GNVoQocBpQBlTNf77ukBrnbBFFBvJMVNPnv7uqMS1Z6GfgQauWyQuShj/WR/dRh4\n\tIK0UQ6RU7aXoxEiTsd0WGMKGyk8MeA+cw9vH26QY=","From":"Rui Wang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Rui Wang ","Subject":"[[PATCH v1]] media: rkisp1: Fix filter mode register configuration\n\tto handle enable and DNR bits separately","Date":"Sun, 23 Nov 2025 15:32:28 -0500","Message-ID":"<20251123203228.3462026-1-rui.wang@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The current implementation in rkisp1_flt_config()\ntreats the arg->mode field as a boolean for enabling DNR mode,\nwhich doesn't properly separate the filter\nenable bit from the DNR mode bit\nin the RKISP1_CIF_ISP_FILT_MODE register.\n\nUpdate the register write to explicitly check individual bits:\n\nBit 0 of arg->mode controls the filter enable (RKISP1_CIF_ISP_FLT_ENA)\nBit 1 of arg->mode controls the DNR mode (RKISP1_CIF_ISP_FLT_MODE_DNR)\nThis ensures that the filter enable and DNR mode\ncan be configured independently through the mode field,\n\nSigned-off-by: Rui Wang \n---\n drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c\nindex b28f4140c8a3..077269848058 100644\n--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c\n+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c\n@@ -408,7 +408,8 @@ static void rkisp1_flt_config(struct rkisp1_params *params,\n \t\t arg->lum_weight);\n \n \trkisp1_write(params->rkisp1, RKISP1_CIF_ISP_FILT_MODE,\n-\t\t (arg->mode ? RKISP1_CIF_ISP_FLT_MODE_DNR : 0) |\n+\t\t ((arg->mode & (1 << 1)) ? RKISP1_CIF_ISP_FLT_MODE_DNR : 0) |\n+\t\t ((arg->mode & (1 << 0)) ? RKISP1_CIF_ISP_FLT_ENA : 0) |\n \t\t RKISP1_CIF_ISP_FLT_CHROMA_V_MODE(arg->chr_v_mode) |\n \t\t RKISP1_CIF_ISP_FLT_CHROMA_H_MODE(arg->chr_h_mode) |\n \t\t RKISP1_CIF_ISP_FLT_GREEN_STAGE1(arg->grn_stage1));\n","prefixes":["[PATCH","v1"]}