[{"id":3342,"web_url":"https://patchwork.libcamera.org/comment/3342/","msgid":"<20200107121219.GB521610@oden.dyn.berto.se>","date":"2020-01-07T12:12:19","subject":"Re: [libcamera-devel] [PATCH] libcamera: control_serializer:\n\tInitialize serial_","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-01-04 08:00:31 +0200, Laurent Pinchart wrote:\n> The ControlSerializer::serial_ member variable isn't initialized. Add a\n> constructor to the class to initialize it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/control_serializer.cpp | 5 +++++\n> src/libcamera/include/control_serializer.h | 2 ++\n> 2 files changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\n> index b787655e6769..a5d6d875c76f 100644\n> --- a/src/libcamera/control_serializer.cpp\n> +++ b/src/libcamera/control_serializer.cpp\n> @@ -84,6 +84,11 @@ static constexpr size_t ControlValueSize[] = {\n> * proceed with care to avoid stale references.\n> */\n> \n> +ControlSerializer::ControlSerializer()\n> +\t: serial_(0)\n> +{\n> +}\n> +\n> /**\n> * \\brief Reset the serializer\n> *\n> diff --git a/src/libcamera/include/control_serializer.h b/src/libcamera/include/control_serializer.h\n> index bb3cb8e7b904..55259913a2ca 100644\n> --- a/src/libcamera/include/control_serializer.h\n> +++ b/src/libcamera/include/control_serializer.h\n> @@ -20,6 +20,8 @@ class ByteStreamBuffer;\n> class ControlSerializer\n> {\n> public:\n> +\tControlSerializer();\n> +\n> \tvoid reset();\n> \n> \tstatic size_t binarySize(const ControlInfoMap &info);\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6898D60461\n\tfor ;\n\tTue, 7 Jan 2020 13:12:20 +0100 (CET)","by mail-lf1-x144.google.com with SMTP id 9so38706196lfq.10\n\tfor ;\n\tTue, 07 Jan 2020 04:12:20 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tt1sm30655736lji.98.2020.01.07.04.12.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 07 Jan 2020 04:12:19 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=DnlKd7bjFLheWxPTCcq4ToHrNbCGV7S0zQJcrIqqRv4=;\n\tb=l+odM6LO3qT6CKb5LN7yScKO+dKHXQcGJHGnICMnhOslYEXbvqfbLigipyWSPZ88sU\n\tdo1K+RRXxkorTuIOVX55HvagHNZPMU+VOWpb+3JmhRHpKgY9aJZ/3JFpKVLCywRGhyTy\n\tgoygZXcMFWUh+MV9JJihOwMydB5KL1Xp8mZbfxugYI7pMk1XdjeqfHLz4QO5roSnj0n7\n\tUTDZ6Meq5e1i/vG3UZtRDGFc0PsGHA27VzRwB5RVAjWcyRSi1urfy4Rw0uw0XJBOxcBF\n\t4tzqntTtTZYjvDDoY8vt5/glFjifrlJv6HXcoyyJouUXvrbwXku+v7OMccXx380cDKze\n\tb5Nw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=DnlKd7bjFLheWxPTCcq4ToHrNbCGV7S0zQJcrIqqRv4=;\n\tb=kyIWiMohO1OCh+84h9kw/VENfFwv08Z39ot663YN7OnqsVEKTpGGy87zfCadBgOt8y\n\tkCcD6DSVe2f4jxwDEoM8r/15wYcWC2palMXkccjJndfS8EpazJG1UW+RSibJI0qg5zjg\n\trijN3SrotZVmAP0J5lee71IejgFRm0gGxRNW+Kec/rQEZADnejTOqaY+u3woKFHdbamr\n\tu/R6EWDZGowpkbNmbH4oC+x/K302AAabgDPrRFpewPQc3RQf71cEUphkrdrQZZNs0VX8\n\tA8MEE1+9gRB85+q+K69n1hnSmCiVb3CFXRw816WPPHN2cW1birn3Yp3SCuamfzO0ODSy\n\twz8w==","X-Gm-Message-State":"APjAAAWpD4HdFpz5IttHupptijkRiTXVVvJE8ZDcfcXXsybpFFBu6nk/\n\ty4j4HMeJQJ6ZQdOMOaWifEWIuK0rk3k=","X-Google-Smtp-Source":"APXvYqyEleE6/hslRN6ReuvIe5SH0s2CRibzGM06dqyNsT7PKTbLiOkcefZDSiTNfcYEPE6+KAs2Tw==","X-Received":"by 2002:ac2:47ec:: with SMTP id\n\tb12mr56722545lfp.162.1578399139923; \n\tTue, 07 Jan 2020 04:12:19 -0800 (PST)","Date":"Tue, 7 Jan 2020 13:12:19 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200107121219.GB521610@oden.dyn.berto.se>","References":"<20200104060031.17140-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200104060031.17140-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: control_serializer:\n\tInitialize serial_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 07 Jan 2020 12:12:20 -0000"}}]