{"id":25128,"url":"https://patchwork.libcamera.org/api/patches/25128/?format=json","web_url":"https://patchwork.libcamera.org/patch/25128/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251120233347.5046-5-bryan.odonoghue@linaro.org>","date":"2025-11-20T23:33:28","name":"[v4,04/23] libcamera: shaders: Rename bayer_8 to bayer_unpacked","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"92563517212ccf09b73afa366b2a799656c6a24c","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25128/mbox/","series":[{"id":5600,"url":"https://patchwork.libcamera.org/api/series/5600/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5600","date":"2025-11-20T23:33:24","name":"Add GLES 2.0 GPUISP to libcamera","version":4,"mbox":"https://patchwork.libcamera.org/series/5600/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25128/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25128/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 38DC9C3333\n\tfor ;\n\tThu, 20 Nov 2025 23:34:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC98660A8B;\n\tFri, 21 Nov 2025 00:34:02 +0100 (CET)","from mail-wr1-x429.google.com (mail-wr1-x429.google.com\n\t[IPv6:2a00:1450:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 61381609DE\n\tfor ;\n\tFri, 21 Nov 2025 00:34:01 +0100 (CET)","by mail-wr1-x429.google.com with SMTP id\n\tffacd0b85a97d-42b3c965ca9so842991f8f.1\n\tfor ;\n\tThu, 20 Nov 2025 15:34:01 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42cb7fa3a81sm7984139f8f.26.2025.11.20.15.33.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 20 Nov 2025 15:33:59 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"MYCAeMtQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1763681641; x=1764286441;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=aOWsQHS70g1fB8m4fPc/5abKue0LOycI9h8pUVaouv4=;\n\tb=MYCAeMtQ/NQqFDetGG6BSXr4mFesc4MtHS7bEtD11vFrNwAzKB63qJtGJGs+zmYz/R\n\tis90A+XW3DIEqy6oaizX3ol0jUgIlS3HOxGW1ZjLZtVd2U8xZEQs3AlTWfLiUHitfZef\n\t045uqBgHJY+SAsm5bCsXnw6nvMgljdOdCG1xByiVQlHwEzLpFQglO8lTQAoLwrARRf5j\n\tJH+JL+Lzek5QpuGuNQIJvHh2//3sYOv0Gnn6dtFLhFoInoh/8IuzGhMtGFQlk+aYnewC\n\txWVjirs6YNHu/qwAQnDwYG9BXa2XpEEP1JmCn8A2uFE8ZKKta5qUyvVT4xYrix3ZTA1b\n\t76Ng==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1763681641; x=1764286441;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=aOWsQHS70g1fB8m4fPc/5abKue0LOycI9h8pUVaouv4=;\n\tb=qVhPyT1kxT7DVxZYAMdBOsWhiMumLaDFYwpGtPaaq0FJOznDdWLrZz4JbiptLzvi9Q\n\tEVYAYRpBy/eeZw4yl2Thr/z+HG7RCPZZKRkmuCMqX1Lkfgv/aLPpoKEQfZQVa9cLMcMG\n\t96uM1USA88zW5QI7WAkkfj9YQC3Te6JVz6UlLV+P5XGYPM19mJ7gANDgDnpqqPCmuJT3\n\t7zfbQEaBPQWNjpTks791qlJOL4/q0aNFa2R0YSaPDjvV3dmu+gzFP4IJoSGql/6ymD7o\n\tfC6YDEhNf42u+rmAIzjljBaauj7msV/l1CGvaFduWYKdL6QXdvc0VRuf5/Kg9CehD1Z0\n\tfcTA==","X-Gm-Message-State":"AOJu0YwRctssXMnjD2hBdLxwpfZIzu5cETVQB/C1plmvIgtXploaXAvQ\n\tyT3bxZqcoZuMRUvx5Jn2kdu8XbQBH8erQ8N5n/phuhmytb2lf2roQFMvO23nQmvoP1Tu4x/TmZY\n\tiVfHz6kM=","X-Gm-Gg":"ASbGncujbA1JEypQbl9BYNoGAwQozSFnxisfrUgCrq4DjJJ7PzjPO5eUWHIxgsJJjMm\n\teUUT7K6JqmjtJSapTmIujGz2Aghd/tHTHwmw6b/IX0NdPzBUml2fnrEmx1VuqY5tV97VlHh2O0A\n\t92BolLcdZNmPlOi2eJDJhiOE9vCkszcYzMzApXqjCTaNgOvB+wYOOvQZm1Jg+zS1Vf3BbnX4LvI\n\tPJDUiiQ3F4eEpvRjH+ikmDU3ndcu9MQNeludahakIVkAm3XVbS+Mh+rVI465z0GjI/JcEnaaOPC\n\txSWhoLY3n5fvsbE3RCW1+mkdzqzT9bCuyrAev1UweZAdQL0Gl4vBruMUmK2EP4u/iea+xl1zHSQ\n\tfhOzxb8UwbF5p7AXx09Sw++f3GWtOUK6vorxl81rOR8VsgV8U6gVOcF7ao6c6c+ToFa7ISND1HH\n\t9qitluHu+Gop/FHevMxffV8oz8C5ieoTqkA8wVagRE7XCI1d2YEGezL7k+ZFMHu9q+nko=","X-Google-Smtp-Source":"AGHT+IH+RXn1P/aXsympVnstSWgpDaGfODJMfhpIUkNEszSe0On9EzAZYrqGWGHJYdldvCAuxTaTtA==","X-Received":"by 2002:a05:6000:2489:b0:427:854:770 with SMTP id\n\tffacd0b85a97d-42cc1d35781mr98446f8f.43.1763681640654; \n\tThu, 20 Nov 2025 15:34:00 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Milan Zamazal ,\n\tKieran Bingham ,\n\tBryan O'Donoghue ","Subject":"[PATCH v4 04/23] libcamera: shaders: Rename bayer_8 to\n\tbayer_unpacked","Date":"Thu, 20 Nov 2025 23:33:28 +0000","Message-ID":"<20251120233347.5046-5-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20251120233347.5046-1-bryan.odonoghue@linaro.org>","References":"<20251120233347.5046-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Milan Zamazal \n\nbayer_8.* shaders are now used for all unpacked sensor data formats,\nregardless of the pixel bit width. Let's rename the \"8-bit\" shaders to\navoid confusion.\n\nSigned-off-by: Milan Zamazal \nReviewed-by: Kieran Bingham \nSigned-off-by: Bryan O'Donoghue \n---\n .../{bayer_8.frag => bayer_unpacked.frag} | 0\n .../{bayer_8.vert => bayer_unpacked.vert} | 0\n include/libcamera/internal/shaders/meson.build | 4 ++--\n src/apps/qcam/assets/shader/shaders.qrc | 4 ++--\n src/apps/qcam/viewfinder_gl.cpp | 16 ++++++++--------\n 5 files changed, 12 insertions(+), 12 deletions(-)\n rename include/libcamera/internal/shaders/{bayer_8.frag => bayer_unpacked.frag} (100%)\n rename include/libcamera/internal/shaders/{bayer_8.vert => bayer_unpacked.vert} (100%)","diff":"diff --git a/include/libcamera/internal/shaders/bayer_8.frag b/include/libcamera/internal/shaders/bayer_unpacked.frag\nsimilarity index 100%\nrename from include/libcamera/internal/shaders/bayer_8.frag\nrename to include/libcamera/internal/shaders/bayer_unpacked.frag\ndiff --git a/include/libcamera/internal/shaders/bayer_8.vert b/include/libcamera/internal/shaders/bayer_unpacked.vert\nsimilarity index 100%\nrename from include/libcamera/internal/shaders/bayer_8.vert\nrename to include/libcamera/internal/shaders/bayer_unpacked.vert\ndiff --git a/include/libcamera/internal/shaders/meson.build b/include/libcamera/internal/shaders/meson.build\nindex 386b342d0..dd441a577 100644\n--- a/include/libcamera/internal/shaders/meson.build\n+++ b/include/libcamera/internal/shaders/meson.build\n@@ -4,7 +4,7 @@\n # for the purposes of inclusion in OpenGL debayering\n shader_files = files([\n 'bayer_1x_packed.frag',\n- 'bayer_8.frag',\n- 'bayer_8.vert',\n+ 'bayer_unpacked.frag',\n+ 'bayer_unpacked.vert',\n 'identity.vert',\n ])\ndiff --git a/src/apps/qcam/assets/shader/shaders.qrc b/src/apps/qcam/assets/shader/shaders.qrc\nindex 04f9d7061..32dfa51bf 100644\n--- a/src/apps/qcam/assets/shader/shaders.qrc\n+++ b/src/apps/qcam/assets/shader/shaders.qrc\n@@ -6,8 +6,8 @@\n \t../../../../../include/libcamera/internal/shaders/YUV_3_planes.frag\n \t../../../../../include/libcamera/internal/shaders/YUV_packed.frag\n \t../../../../../include/libcamera/internal/shaders/bayer_1x_packed.frag\n-\t../../../../../include/libcamera/internal/shaders/bayer_8.frag\n-\t../../../../../include/libcamera/internal/shaders/bayer_8.vert\n+\t../../../../../include/libcamera/internal/shaders/bayer_unpacked.frag\n+\t../../../../../include/libcamera/internal/shaders/bayer_unpacked.vert\n \t../../../../../include/libcamera/internal/shaders/identity.vert\n \n \ndiff --git a/src/apps/qcam/viewfinder_gl.cpp b/src/apps/qcam/viewfinder_gl.cpp\nindex 70f600650..95965ab71 100644\n--- a/src/apps/qcam/viewfinder_gl.cpp\n+++ b/src/apps/qcam/viewfinder_gl.cpp\n@@ -235,29 +235,29 @@ bool ViewFinderGL::selectFormat(const libcamera::PixelFormat &format)\n \tcase libcamera::formats::SBGGR8:\n \t\tfirstRed_.setX(1.0);\n \t\tfirstRed_.setY(1.0);\n-\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SGBRG8:\n \t\tfirstRed_.setX(0.0);\n \t\tfirstRed_.setY(1.0);\n-\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SGRBG8:\n \t\tfirstRed_.setX(1.0);\n \t\tfirstRed_.setY(0.0);\n-\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SRGGB8:\n \t\tfirstRed_.setX(0.0);\n \t\tfirstRed_.setY(0.0);\n-\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SBGGR10_CSI2P:\n","prefixes":["v4","04/23"]}