{"id":25112,"url":"https://patchwork.libcamera.org/api/patches/25112/?format=json","web_url":"https://patchwork.libcamera.org/patch/25112/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251120232019.3590-12-bryan.odonoghue@linaro.org>","date":"2025-11-20T23:20:08","name":"[11/22] libcamera: software_isp: Move param select code to Debayer base class","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9fcb345f54993fa838e1ceb547df945d60e4711e","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25112/mbox/","series":[{"id":5599,"url":"https://patchwork.libcamera.org/api/series/5599/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5599","date":"2025-11-20T23:19:57","name":"GPUISP precursor series","version":1,"mbox":"https://patchwork.libcamera.org/series/5599/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25112/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25112/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6586CC3330\n\tfor ;\n\tThu, 20 Nov 2025 23:20:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2088760AB7;\n\tFri, 21 Nov 2025 00:20:47 +0100 (CET)","from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n\t[IPv6:2a00:1450:4864:20::332])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B117C60AAF\n\tfor ;\n\tFri, 21 Nov 2025 00:20:44 +0100 (CET)","by mail-wm1-x332.google.com with SMTP id\n\t5b1f17b1804b1-47775fb6cb4so10206175e9.0\n\tfor ;\n\tThu, 20 Nov 2025 15:20:44 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-477bf3af0ecsm11618415e9.9.2025.11.20.15.20.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 20 Nov 2025 15:20:43 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"PAq9+Fbz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1763680844; x=1764285644;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=5RzA2VjoFGo8Y8DWFS3Wdghq/DKfdgt6/HWUREdw1BA=;\n\tb=PAq9+FbznkwBtxqT6zgW7MfP3ETuPiDICa+Q08weWmHmZ7eHZMfmStT3CvGc2iivSY\n\tHbdUNsxkWrGsy2C21u3kaiLyEc9rZBW4Z/M/g5U7X3Pwf8BYnPrWt1Z5pw9WWkMt4LNi\n\t4JmyHJFKItRWsrGcsURHXwzaDnIJKoJH131wLJETyKSO9Dsu4fVrg/5FQ1eOxoUkzW++\n\tPas5ZeTTcZrDDiN7XzzRmyuKa8NY8S/yvy8jyuKqWNH2ZVAbwrjAXuhcdXKX8EDWaMbd\n\tGDf1FYJVwd3ZSam7SnE3VLfX5go+zZgo69UzxVo5O2NqlF1up10Nt7y5yrWEp7wP6svu\n\tqm/g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1763680844; x=1764285644;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=5RzA2VjoFGo8Y8DWFS3Wdghq/DKfdgt6/HWUREdw1BA=;\n\tb=S8xphJhDfz+HcolQJU4GOJcF4EWStdUhKMQG+z58ym5HHNGznMuMLnTAWi4rlSe08s\n\t3YN/RWXcFgDzn7hjdE6jzZ47aFm8jQBVheKW0GmLX96h1EhYX7vJVJ/+p7cWI7Jm9eMY\n\tuTBFc8tYaisP8a3XTHov1t93SkQkLwIechnxMXW+BXDPXbnDdBKeESUn9dmrS/Rha4GC\n\t72Zz1IFQbMLNySKhrZDd8JA4vszYJn+4WkoWEPpB548UEcmCNqy2bzcPJwOUhXTmMHXM\n\tt+7ID26OIqF6AuDoOPs5HvY01/jN2iZqJrvkhz7zmH/FQOjgDbJDdIay9PtM5lfGpauH\n\tRDlA==","X-Gm-Message-State":"AOJu0YxgaU4IcAWht00jeq63Hd+TZVgKoszUVkJbDgvP2WLujqwif6vm\n\tHRITWTNlnrIHGlT1vECztcsDylDTD7I/W9tjEozYHNsgK9oRRWQcvdgQo6FiX0pdSr3oOxgOQ2c\n\tC9YIQvTM=","X-Gm-Gg":"ASbGncvSjYLnHRVxr3gHXVrO+CrUysQksR2SImL5myAKZHSd7TRDo1FQRJrooyCCxgn\n\tYGTAslDiVmmoYYSKiXqgQQKd7P+Es3GSSY22lZl8Tt5QF4I/nSM/oEMAtIvmb31nQf4XJLfnf3Z\n\trnpdW967B/bOBB5uG3sfQA7EPwHfNNspKbZisafdKfxk5nXA0WyrL8EAxiGGl96S1ESAfNtQeda\n\t6iDCCSUUlxaMP1q8BUEutATrRsyQDlkszYSTL8vgimYDTiDs4dFXDlmxViV2ma/+O14VPcIsncd\n\tXMd03Ig8z7s9tXoJeiRTOswcDSYtD1+4nrxJ/OEV40uBdJV7//rK5RNj+tOqAbDvxWe2rJ9RTAW\n\tSUrkho/ZIbdGCZSZIWnsTYLU2MixSThrFqlaexSDVBr/bDPs7ac7P7Trh+giLA/D10DIzZPYLDL\n\ta7zIr0L7/hGJ3oo4V1wsF+0uh+u7cUhmWPkS4JLt7fBVKAjO/OZqCYI+OJ7gT7xlum+xW2pZTeY\n\toprXQ==","X-Google-Smtp-Source":"AGHT+IFMg5r4Pc8TsMtLy0Nh+xdmQpXAKwKToCC037X7lghQqKfnXz79BXw+8Gnpd0RI2oXihcqj2A==","X-Received":"by 2002:a05:600c:198e:b0:46e:33b2:c8da with SMTP id\n\t5b1f17b1804b1-477c1133927mr330985e9.32.1763680844054; \n\tThu, 20 Nov 2025 15:20:44 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tKieran Bingham ,\n\tMilan Zamazal ","Subject":"[PATCH 11/22] libcamera: software_isp: Move param select code to\n\tDebayer base class","Date":"Thu, 20 Nov 2025 23:20:08 +0000","Message-ID":"<20251120232019.3590-12-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20251120232019.3590-1-bryan.odonoghue@linaro.org>","References":"<20251120232019.3590-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Move the parameter selection code into the Debayer base class in-order to\nfacilitate reuse of the lookup tables in the eGL shaders.\n\nReviewed-by: Kieran Bingham \nReviewed-by: Milan Zamazal \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/debayer.cpp | 28 ++++++++++++++++++++++\n src/libcamera/software_isp/debayer.h | 3 +++\n src/libcamera/software_isp/debayer_cpu.cpp | 20 +---------------\n 3 files changed, 32 insertions(+), 19 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex f267f8c7f..af40f5107 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -193,4 +193,32 @@ Debayer::~Debayer()\n * \\brief Signals when the output buffer is ready\n */\n \n+/**\n+ * \\fn void Debayer::setParams(DebayerParams ¶ms)\n+ * \\brief Select the bayer params to use for the next frame debayer\n+ * \\param[in] params The parameters to be used in debayering\n+ */\n+void Debayer::setParams(DebayerParams ¶ms)\n+{\n+\tgreen_ = params.green;\n+\tgreenCcm_ = params.greenCcm;\n+\tif (swapRedBlueGains_) {\n+\t\tred_ = params.blue;\n+\t\tblue_ = params.red;\n+\t\tredCcm_ = params.blueCcm;\n+\t\tblueCcm_ = params.redCcm;\n+\t\tfor (unsigned int i = 0; i < 256; i++) {\n+\t\t\tstd::swap(redCcm_[i].r, redCcm_[i].b);\n+\t\t\tstd::swap(greenCcm_[i].r, greenCcm_[i].b);\n+\t\t\tstd::swap(blueCcm_[i].r, blueCcm_[i].b);\n+\t\t}\n+\t} else {\n+\t\tred_ = params.red;\n+\t\tblue_ = params.blue;\n+\t\tredCcm_ = params.redCcm;\n+\t\tblueCcm_ = params.blueCcm;\n+\t}\n+\tgammaLut_ = params.gammaLut;\n+}\n+\n } /* namespace libcamera */\ndiff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex dc0b8e67b..0b5e11abd 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -111,6 +111,9 @@ private:\n \t * Bayer formats (BGGR, GRBG, GBRG, RGGB) this is typically 2x2 pixels.\n \t */\n \tvirtual Size patternSize(PixelFormat inputFormat) = 0;\n+\n+protected:\n+\tvoid setParams(DebayerParams ¶ms);\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex 8f42d706b..6be5cdbd5 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -758,25 +758,7 @@ void DebayerCpu::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output\n \tfor (const FrameBuffer::Plane &plane : output->planes())\n \t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Write);\n \n-\tgreen_ = params.green;\n-\tgreenCcm_ = params.greenCcm;\n-\tif (swapRedBlueGains_) {\n-\t\tred_ = params.blue;\n-\t\tblue_ = params.red;\n-\t\tredCcm_ = params.blueCcm;\n-\t\tblueCcm_ = params.redCcm;\n-\t\tfor (unsigned int i = 0; i < 256; i++) {\n-\t\t\tstd::swap(redCcm_[i].r, redCcm_[i].b);\n-\t\t\tstd::swap(greenCcm_[i].r, greenCcm_[i].b);\n-\t\t\tstd::swap(blueCcm_[i].r, blueCcm_[i].b);\n-\t\t}\n-\t} else {\n-\t\tred_ = params.red;\n-\t\tblue_ = params.blue;\n-\t\tredCcm_ = params.redCcm;\n-\t\tblueCcm_ = params.blueCcm;\n-\t}\n-\tgammaLut_ = params.gammaLut;\n+\tsetParams(params);\n \n \t/* Copy metadata from the input buffer */\n \tFrameMetadata &metadata = output->_d()->metadata();\n","prefixes":["11/22"]}