[{"id":36997,"web_url":"https://patchwork.libcamera.org/comment/36997/","msgid":"<85ms4f9yza.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-11-21T15:39:21","subject":"Re: [PATCH 09/22] libcamera: software_isp: Move useful items from\n\tDebayerCpu to Debayer base class","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> The DebayerCpu class has a number of variables, embedded structures and\n> methods which are useful to DebayerGpu implementation.\n>\n> Move relevant variables and methods to base class.\n>\n> Since we want to call setParams() from the GPUISP and reuse the code in\n> the existing CPUISP as a first step, we need to move all of the\n> dependent variables in DebayerCPU to the Debayer base class including\n> LookupTable and redCcm_.\n>\n> The DebayerEGL class will ultimately be able to consume both the CCM and\n> non-CCM data.\n>\n> Reviewed-by: Kieran Bingham \n> Signed-off-by: Bryan O'Donoghue \n> ---\n> src/libcamera/software_isp/debayer.cpp | 6 +++\n> src/libcamera/software_isp/debayer.h | 63 +++++++++++++++++++++-\n> src/libcamera/software_isp/debayer_cpu.cpp | 2 +-\n> src/libcamera/software_isp/debayer_cpu.h | 41 +-------------\n> 4 files changed, 70 insertions(+), 42 deletions(-)\n>\n> diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\n> index e9e18c488..e9130df1e 100644\n> --- a/src/libcamera/software_isp/debayer.cpp\n> +++ b/src/libcamera/software_isp/debayer.cpp\n> @@ -18,6 +18,12 @@ namespace libcamera {\n> * \\brief Struct to hold the debayer parameters.\n> */\n> \n> +/**\n> + * \\fn Debayer::Debayer(const GlobalConfiguration &configuration)\n> + * \\brief Construct a Debayer object\n> + * \\param[in] configuration Global configuration reference\n> + */\n> +\n> /**\n> * \\var DebayerParams::kRGBLookupSize\n> * \\brief Size of a color lookup table\n> diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\n> index ba033d440..578535b20 100644\n> --- a/src/libcamera/software_isp/debayer.h\n> +++ b/src/libcamera/software_isp/debayer.h\n> @@ -14,11 +14,14 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> \n> #include \n> #include \n> \n> +#include \"libcamera/internal/global_configuration.h\"\n> +#include \"libcamera/internal/software_isp/benchmark.h\"\n> #include \"libcamera/internal/software_isp/debayer_params.h\"\n> \n> namespace libcamera {\n> @@ -27,9 +30,10 @@ class FrameBuffer;\n> \n> LOG_DECLARE_CATEGORY(Debayer)\n> \n> -class Debayer\n> +class Debayer : public Object\n\nIt's still not clear why Object is inherited here.\n\n(I guess it's preparation for the GPU debayering class but it should be\neither explained or moved to the corresponding patch.)\n\n> {\n> public:\n> +\tDebayer (const GlobalConfiguration &configuration) : bench_(configuration) {};\n> \tvirtual ~Debayer() = 0;\n> \n> \tvirtual int configure(const StreamConfiguration &inputCfg,\n> @@ -45,10 +49,67 @@ public:\n> \n> \tvirtual SizeRange sizes(PixelFormat inputFormat, const Size &inputSize) = 0;\n> \n> +\t/**\n> +\t * \\brief Get the file descriptor for the statistics\n> +\t *\n> +\t * \\return the file descriptor pointing to the statistics\n> +\t */\n> +\tvirtual const SharedFD &getStatsFD() = 0;\n> +\n> +\t/**\n> +\t * \\brief Get the output frame size\n> +\t *\n> +\t * \\return The output frame size\n> +\t */\n> +\tunsigned int frameSize() { return outputConfig_.frameSize; }\n> +\n> \tSignal inputBufferReady;\n> \tSignal outputBufferReady;\n> \n> +\t/**\n> +\t * struct DebayerInputConfig\n> +\t *\n> +\t * Structure to describe the incoming Bayer parameters.\n> +\t */\n> +\tstruct DebayerInputConfig {\n> +\t\tSize patternSize;\t\t\t/**< patternSize size of the Bayer pattern in pixels */\n> +\t\tunsigned int bpp;\t\t\t/**< bpp Memory used per pixel, not precision */\n> +\t\tunsigned int stride;\t\t\t/**< stride Line stride in bytes */\n> +\t\tstd::vector outputFormats;\t/**< outputFormats List of supported output pixel formats */\n> +\t};\n> +\n> +\t/**\n> +\t * struct DebayerOutputConfig\n\nStill not fixed struct -> \\struct here and above.\n\n> +\t *\n> +\t * Structure to describe the output pattern requested to the Debayer logic.\n> +\t */\n> +\tstruct DebayerOutputConfig {\n> +\t\tunsigned int bpp;\t\t\t/**< bpp Memory used per pixel, not precision */\n> +\t\tunsigned int stride;\t\t\t/**< stride Line stride in bytes */\n> +\t\tunsigned int frameSize;\t\t\t/**< framesize Total frame size in bytes */\n> +\t};\n> +\n> +\tDebayerInputConfig inputConfig_;\t\t/**< inputConfig_ debayer input config params */\n> +\tDebayerOutputConfig outputConfig_;\t\t/**< outputConfig_ debayer output config data */\n> +\tDebayerParams::LookupTable red_;\t\t/**< red_ DebayerParams red_ lookup table */\n> +\tDebayerParams::LookupTable green_;\t\t/**< green_ DebayerParams green_ lookup table */\n> +\tDebayerParams::LookupTable blue_;\t\t/**< blue_ DebayerParams blue_ lookup table */\n> +\tDebayerParams::CcmLookupTable redCcm_;\t\t/**< redCcm_ Red Colour Correction matrix lookup table */\n> +\tDebayerParams::CcmLookupTable greenCcm_;\t/**< greenCcm_ Green Colour Correction matrix lookup table */\n> +\tDebayerParams::CcmLookupTable blueCcm_;\t\t/**< blueCcm_ Blue Colour Correction matrix lookup table */\n> +\tDebayerParams::LookupTable gammaLut_;\t\t/**< gammaLut_ Gamma Lut lookup table */\n> +\tbool swapRedBlueGains_;\t\t\t\t/**< swapRedBlueGains_ bool to indicate swapping of red/blue gains */\n> +\tBenchmark bench_;\t\t\t\t/**< bench_ an instance of the Benchmark class */\n> +\n> private:\n> +\t/**\n> +\t * \\fn patternSize(PixelFormat inputFormat)\n> +\t * \\var DebayerInputConfig::patternSize\n> +\t * \\brief Size of the Bayer pattern in pixels\n> +\t *\n> +\t * The width and height of the Bayer color filter array pattern. For standard\n> +\t * Bayer formats (BGGR, GRBG, GBRG, RGGB) this is typically 2x2 pixels.\n> +\t */\n> \tvirtual Size patternSize(PixelFormat inputFormat) = 0;\n> };\n> \n> diff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\n> index b92c6a904..e55599f09 100644\n> --- a/src/libcamera/software_isp/debayer_cpu.cpp\n> +++ b/src/libcamera/software_isp/debayer_cpu.cpp\n> @@ -42,7 +42,7 @@ namespace libcamera {\n> * \\param[in] configuration The global configuration\n> */\n> DebayerCpu::DebayerCpu(std::unique_ptr stats, const GlobalConfiguration &configuration)\n> -\t: stats_(std::move(stats)), bench_(configuration)\n> +\t: Debayer(configuration), stats_(std::move(stats))\n> {\n> \t/*\n> \t * Reading from uncached buffers may be very slow.\n> diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\n> index aff32491e..ecc4f9dd0 100644\n> --- a/src/libcamera/software_isp/debayer_cpu.h\n> +++ b/src/libcamera/software_isp/debayer_cpu.h\n> @@ -17,16 +17,14 @@\n> \n> #include \n> \n> -#include \"libcamera/internal/software_isp/benchmark.h\"\n> #include \"libcamera/internal/bayer_format.h\"\n> -#include \"libcamera/internal/global_configuration.h\"\n> #include \"libcamera/internal/software_isp/swstats_cpu.h\"\n> \n> #include \"debayer.h\"\n> \n> namespace libcamera {\n> \n> -class DebayerCpu : public Debayer, public Object\n> +class DebayerCpu : public Debayer\n> {\n> public:\n> \tDebayerCpu(std::unique_ptr stats, const GlobalConfiguration &configuration);\n> @@ -41,21 +39,8 @@ public:\n> \tstrideAndFrameSize(const PixelFormat &outputFormat, const Size &size);\n> \tvoid process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, DebayerParams params);\n> \tSizeRange sizes(PixelFormat inputFormat, const Size &inputSize);\n> -\n> -\t/**\n> -\t * \\brief Get the file descriptor for the statistics\n> -\t *\n> -\t * \\return the file descriptor pointing to the statistics\n> -\t */\n> \tconst SharedFD &getStatsFD() { return stats_->getStatsFD(); }\n> \n> -\t/**\n> -\t * \\brief Get the output frame size\n> -\t *\n> -\t * \\return The output frame size\n> -\t */\n> -\tunsigned int frameSize() { return outputConfig_.frameSize; }\n> -\n> private:\n> \t/**\n> \t * \\brief Called to debayer 1 line of Bayer input data to output format\n> @@ -112,19 +97,6 @@ private:\n> \ttemplate\n> \tvoid debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[]);\n> \n> -\tstruct DebayerInputConfig {\n> -\t\tSize patternSize;\n> -\t\tunsigned int bpp; /* Memory used per pixel, not precision */\n> -\t\tunsigned int stride;\n> -\t\tstd::vector outputFormats;\n> -\t};\n> -\n> -\tstruct DebayerOutputConfig {\n> -\t\tunsigned int bpp; /* Memory used per pixel, not precision */\n> -\t\tunsigned int stride;\n> -\t\tunsigned int frameSize;\n> -\t};\n> -\n> \tint getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n> \tint getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n> \tint setupStandardBayerOrder(BayerFormat::Order order);\n> @@ -140,20 +112,11 @@ private:\n> \t/* Max. supported Bayer pattern height is 4, debayering this requires 5 lines */\n> \tstatic constexpr unsigned int kMaxLineBuffers = 5;\n> \n> -\tDebayerParams::LookupTable red_;\n> -\tDebayerParams::LookupTable green_;\n> -\tDebayerParams::LookupTable blue_;\n> -\tDebayerParams::CcmLookupTable redCcm_;\n> -\tDebayerParams::CcmLookupTable greenCcm_;\n> -\tDebayerParams::CcmLookupTable blueCcm_;\n> -\tDebayerParams::LookupTable gammaLut_;\n> \tdebayerFn debayer0_;\n> \tdebayerFn debayer1_;\n> \tdebayerFn debayer2_;\n> \tdebayerFn debayer3_;\n> \tRectangle window_;\n> -\tDebayerInputConfig inputConfig_;\n> -\tDebayerOutputConfig outputConfig_;\n> \tstd::unique_ptr stats_;\n> \tstd::vector lineBuffers_[kMaxLineBuffers];\n> \tunsigned int lineBufferLength_;\n> @@ -161,8 +124,6 @@ private:\n> \tunsigned int lineBufferIndex_;\n> \tunsigned int xShift_; /* Offset of 0/1 applied to window_.x */\n> \tbool enableInputMemcpy_;\n> -\tbool swapRedBlueGains_;\n> -\tBenchmark bench_;\n> };\n> \n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E228C3333\n\tfor ;\n\tFri, 21 Nov 2025 15:39:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D37AB60805;\n\tFri, 21 Nov 2025 16:39:29 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99E6B60805\n\tfor ;\n\tFri, 21 Nov 2025 16:39:27 +0100 (CET)","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n\t[209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-58-D81RLJJHOQy777rSYbbnbw-1; Fri, 21 Nov 2025 10:39:25 -0500","by mail-wr1-f71.google.com with SMTP id\n\tffacd0b85a97d-42b3c965ce5so1733412f8f.2\n\tfor ;\n\tFri, 21 Nov 2025 07:39:24 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42cb7f2e454sm11906555f8f.2.2025.11.21.07.39.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 21 Nov 2025 07:39:22 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"H0X1WWD+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1763739566;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=E9LZQF0Ef8pKmzADz3SJzuD/KK/65csQ2Oze9sk4ORg=;\n\tb=H0X1WWD+iLDvhu/HIX96y7r7hZRnM0lO9qEvoP70dD9En5CUjm6qLjVFgJe04z0oEiATmk\n\tGJlxF9FZDrbp6GSbQXv8m30Jc1wB4CJgz6Dtu4rYvP+w9OhLzE5jGrjeKDQ8ZEt8pHp/fF\n\txUQm5HGH51h6OMacPyhtbvYfoAIk2GE=","X-MC-Unique":"D81RLJJHOQy777rSYbbnbw-1","X-Mimecast-MFC-AGG-ID":"D81RLJJHOQy777rSYbbnbw_1763739564","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1763739564; x=1764344364;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=E9LZQF0Ef8pKmzADz3SJzuD/KK/65csQ2Oze9sk4ORg=;\n\tb=mb9aPeaccXHO4Ahhv90PGDGBIBoXryA22MX193lHROmTHzvnnsLPGjQN0hwjCNKx7I\n\tLrJ0EtAjN69q5xoPCwpWT+Kuf5d8DJKbVHyKmf9JPogG5P5BkohOsgJ2Z+uhFsPsZPBz\n\t2jc/nkHUKMy9nx5abAM6hM55dZA3hIvqsKBrBF8CZsLwlvImSa9bDe7rvsRjFgOPpxtw\n\tsUccyA7361hdZbfYA9i34IX5yUZTC4L3YWkc2xBGk8ibdNLmNd+yyexbQWN9a2TzTrpj\n\ttdbD4EsogmxzAwJk7WVxm67Pwt2p63p/VL7/hgqB/ayqTeJ0egn2UpmqsjDqowupGrYy\n\tZpJw==","X-Gm-Message-State":"AOJu0YztwpY3/kb4LJZS7iyRdVrsfo+rQ3Q4PwEXEIqSL0l/Jzr3hyWO\n\twsfXlu6E4m6MjRUBXmOVd5u6+Q+zt9PNrwIbXHpIhlkc1Mqgtt6ax8bmySOtfWCA22QAB6Hc10O\n\tAD6idmjRL/GhPRxWz3J6HshDpMNBUI62XvoSs6IVzEI3v7WrgyOjoDv8sb3NCk53C5JO2JO0ebs\n\tc=","X-Gm-Gg":"ASbGnctzbf2fYAFg9DifTZydCknsEL2Kyu8j+kKFT0ZHF7RWlmNuWM6Em9PuqXV3I4i\n\tMf7ZgPwWq7m7AqS+jgxYfQyH3Be2gcxYUwfFbTOM8xtyN2eppQucoIvl88SSz6gwL0KOXU/O9z8\n\tmyUDSKVLwVUXuOqOw4YVcr1DO/+oTuY//C0PcuOLR2kCowC0aYVk+/YLcAYlw9FxTs6CZM4a6IC\n\tCXbb6bKIMlp0oWR/WpuUNrsRejwAwXACD1ccMSHg3JJblx/FhNu0Arz4b3gHCi5Fkccyxuw9NuO\n\tfjY5xXSEvOJhu61C5VbN+82/l1Sc0FvCvFoTk3VO4m2ihJJfI7nG6m862RS19nlKCjR4MnWPBgS\n\tNowA4JaihvDQ48FBGajHZlz3P8KORarlsV6TTSLVp+gecO24henUWj0fPbATjrSc=","X-Received":["by 2002:a05:6000:1448:b0:42b:3746:3b82 with SMTP id\n\tffacd0b85a97d-42cc1d230a8mr2698688f8f.54.1763739563589; \n\tFri, 21 Nov 2025 07:39:23 -0800 (PST)","by 2002:a05:6000:1448:b0:42b:3746:3b82 with SMTP id\n\tffacd0b85a97d-42cc1d230a8mr2698650f8f.54.1763739563100; \n\tFri, 21 Nov 2025 07:39:23 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IG1QMWyTLh39QlBAtDvOtgo6wI9ZU9/4vd/d3ndMrNU5x8BE+hh2E3dW2qQlanfuFfQRt45Uw==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, pavel@ucw.cz, Kieran Bingham\n\t","Subject":"Re: [PATCH 09/22] libcamera: software_isp: Move useful items from\n\tDebayerCpu to Debayer base class","In-Reply-To":"<20251120232019.3590-10-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Thu, 20 Nov 2025 23:20:06 +0000\")","References":"<20251120232019.3590-1-bryan.odonoghue@linaro.org>\n\t<20251120232019.3590-10-bryan.odonoghue@linaro.org>","Date":"Fri, 21 Nov 2025 16:39:21 +0100","Message-ID":"<85ms4f9yza.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"FvG6K5NdkUKD_nYZFN8PQXg9YIKVvCyxIRzFfsVeXUg_1763739564","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37085,"web_url":"https://patchwork.libcamera.org/comment/37085/","msgid":"","date":"2025-11-27T01:59:34","subject":"Re: [PATCH 09/22] libcamera: software_isp: Move useful items from\n\tDebayerCpu to Debayer base class","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"content":"On 21/11/2025 15:39, Milan Zamazal wrote:\n>> +class Debayer : public Object\n> It's still not clear why Object is inherited here.\n\nObject gets you invokeMethod, moveToThread and friends - since we will \nbe calling debayer->invokeMethod on a pointer to an instantiation of the \nbayer class - we need to give the base class Object.\n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E9C9C3257\n\tfor ;\n\tThu, 27 Nov 2025 01:59:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3D3D760A85;\n\tThu, 27 Nov 2025 02:59:38 +0100 (CET)","from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F2571609D8\n\tfor ;\n\tThu, 27 Nov 2025 02:59:36 +0100 (CET)","by mail-wr1-x435.google.com with SMTP id\n\tffacd0b85a97d-42b3c965cc4so169283f8f.0\n\tfor ;\n\tWed, 26 Nov 2025 17:59:36 -0800 (PST)","from [192.168.0.27] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42e1caa5d02sm491034f8f.36.2025.11.26.17.59.35\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 26 Nov 2025 17:59:36 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"GueH3x+O\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764208776; x=1764813576;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=E2yBZV4Dg17pMBkYbVXJ6pUgVgqyCbZgQY6dg0XEm30=;\n\tb=GueH3x+Oh4lM7+nMS/WPeUpVtMz8tRfeM3VhTlsQbtKySJbDrri3t2ECJD0JmuTF9s\n\tuiw4OuHAV7MyJC1HX4alwyRn4OoucWl+CNm1bB6rYFp3PWoHjnte/TQyHC4jAfM1ZU/l\n\tASf2K76GvU+N4RIfYmEPkeeNhX0KJO0l8XFu/E+7j6vr0RujRUY3f6KWVld5xY8tKXoC\n\tqEsiqmRzqywLeQQD5D5wJiKAJlv6RM6jSKTJk2ITESpRM3jiCyvqblvWObs1VseaN+yw\n\tFRHrPfUOrUPwp1n8K1IKxmj35i0MIXmiqSFuLcCHKi2grSJmb/49mIXTYVi9L+38+HO1\n\tGgVw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764208776; x=1764813576;\n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=E2yBZV4Dg17pMBkYbVXJ6pUgVgqyCbZgQY6dg0XEm30=;\n\tb=U4cnWAXGQOQluHraQ9QEeTV45/jATRmnhpdGFofKdQItEXr+tWQzExk1XwRtgNvrSw\n\tNA2BLAcEXWaEQX17wxuyE97qStabuadmM1QQdcT+GUrlreAVz4Ssqkih3eGgFeWuQiNp\n\tLc30dnbI/UXvN41Q2DiPw7E2qa+bskKjWW9p1XnOnoud7eo2OOzEf8g/+Pj9MtU+AZK9\n\tqBzdZUhFZMYJFkCmTPjqgkGHZJ0C1yljcnXRNO4r6GNpcjQcxVrdp21XGbhpNF2J2TaI\n\tFd8NDaPp9mvROuz1YdvlOZpROfwbFseQARhb28P9fZJoC8W+ZnlrYswCVuO6m5N6Lmoj\n\to6lw==","X-Gm-Message-State":"AOJu0YwcGbnSvpNNzL6LKAOum+Ci17X8zBKg0MVFv4TbHC+wsOqojVby\n\tfDv1EW4skVNoeuxsgx54P8cb/wIUkFHZTs9XUBFcxFT7D03QQPS176KU2ggfcwuI9Xc=","X-Gm-Gg":"ASbGnctcFfiGN4mmX4x8bHMTwYfBV8a289A+OAXF8B1QKWwXf3tzO+7nIyQ7XPoXbWN\n\t3QG1yQxnZr3BN1Wnn2tgPcXJEZkaJ9vQtv+vZCAD7D1Fb7YmKXySdOFmPUzcpaeoKkmcQtVzrKU\n\taJjHgaaT5rhWFT0ncbgvWwekbOj/YWRuim0mwB/3qhH3IBBXY+zVvbVJl+K9zBN4gGL2NxzaoDU\n\tOvwExpCI4YjD1rIoPr4f1hfCc56BpEh1TQsRs9jyGqsKDnLZFJi8vstrbGlyebYF07cHKpPcrjo\n\tUI1yimz77yRviuKge+aAtfZwhdXM0U86ZQBpziBnlu4Fpovv2eSuQo08LiEdvM3zN8zvBdMeWWl\n\tBbleBA/PAm2RvPK+EbYCsvjiHx30yrgIU0NNG2asjl0YkdWLSPpv01u/T9ENDOlLcUT7xzaOygu\n\tHY8sSVsLlmT6z1RPBNj2LI1MsldnX3PmsHvrERF4kVFdc7l2jxVvpr","X-Google-Smtp-Source":"AGHT+IE67KTuiu7UwAOt+MvU9BIVHxdhYX5tjWiQXYjEULByRTLEwudXlGNIup+Ro8jGaT11Gt+zXg==","X-Received":"by 2002:a5d:5850:0:b0:429:c719:e0aa with SMTP id\n\tffacd0b85a97d-42cba63a6f8mr29862362f8f.6.1764208776556; \n\tWed, 26 Nov 2025 17:59:36 -0800 (PST)","Message-ID":"","Date":"Thu, 27 Nov 2025 01:59:34 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 09/22] libcamera: software_isp: Move useful items from\n\tDebayerCpu to Debayer base class","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org, pavel@ucw.cz,\n\tKieran Bingham ","References":"<20251120232019.3590-1-bryan.odonoghue@linaro.org>\n\t<20251120232019.3590-10-bryan.odonoghue@linaro.org>\n\t<85ms4f9yza.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","From":"Bryan O'Donoghue ","Content-Language":"en-US","In-Reply-To":"<85ms4f9yza.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]