{"id":25106,"url":"https://patchwork.libcamera.org/api/patches/25106/?format=json","web_url":"https://patchwork.libcamera.org/patch/25106/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251120232019.3590-6-bryan.odonoghue@linaro.org>","date":"2025-11-20T23:20:02","name":"[05/22] libcamera: swstats_cpu: Drop patternSize_ documentation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"59741e75c523b0031de9169f512623c1b3987ba1","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25106/mbox/","series":[{"id":5599,"url":"https://patchwork.libcamera.org/api/series/5599/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5599","date":"2025-11-20T23:19:57","name":"GPUISP precursor series","version":1,"mbox":"https://patchwork.libcamera.org/series/5599/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25106/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25106/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67C3BC3333\n\tfor ;\n\tThu, 20 Nov 2025 23:20:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 25A1860A8B;\n\tFri, 21 Nov 2025 00:20:38 +0100 (CET)","from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n\t[IPv6:2a00:1450:4864:20::32d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D360F60A9D\n\tfor ;\n\tFri, 21 Nov 2025 00:20:34 +0100 (CET)","by mail-wm1-x32d.google.com with SMTP id\n\t5b1f17b1804b1-47796a837c7so9424105e9.0\n\tfor ;\n\tThu, 20 Nov 2025 15:20:34 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-477bf3af0ecsm11618415e9.9.2025.11.20.15.20.32\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 20 Nov 2025 15:20:33 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"eKZ8K4Am\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1763680834; x=1764285634;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=J/rNUy6IT8Dq/gobx75Pygy+h2VMr98GtCcoWBBrzZU=;\n\tb=eKZ8K4AmDARdsmThf3v+ls8mG9gipqwucPUHy8L71i6g2Fh2u0yXeyy9PH7Eua0nYC\n\tkKesU8ysWGQyfljuuKSQs7NnMVzopOolgKErZn9Mg5gnxjZbEDC/GFJi6Q8cfgT5P6hf\n\tsNya3+g37TCwj5VPbRE1O65INEm0ahtBRH+L1d9dPJYiJOsuONZ+UiBaHfxvcPiPIWhG\n\tTVA/bdcg8OXfnvmnkvTaVhdEirFVBavFoBKxhgUM14FxPXaNycr3oVgWdlXOXU20oKUx\n\t6bbKa4EJAPO1NV2/DTbaGxpUJXpn6gt7qMdmcbwS+ZgBF0KquBnmoqGFXXDKMN/iItKH\n\tV8mw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1763680834; x=1764285634;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=J/rNUy6IT8Dq/gobx75Pygy+h2VMr98GtCcoWBBrzZU=;\n\tb=WaheV8vULEnJD23XVYs8LExpn4UO5c7fNPV4jzDCJiQvHQ3Sr5m40ksFlSjsLLWwQR\n\tjuidQMBsgy7g2VrI8zcK933AKmIJnYXsLC5kQ576wPNgbqKpl4eY+Atv8mUmrR5GOA/z\n\txJ+ykBJ1gchDeJXD6IuJz5/wC3N7L6BQcL/Iu82EZ7Ad610lgC+5WavaDuVbkAXqRS1G\n\txBrEFkc67Ih81NI+ZYL+gBjXnUjgps9kCYHsoZ/tcLnRrmpugO1vLHJUrerwWOyihPbp\n\tkFsM6QZcrqAW7Hj3oH9yNQixZmkGjKLNExmTvyw+vUhP4NLILnfQsudAkFDhisTHNKRj\n\tHjVw==","X-Gm-Message-State":"AOJu0YzDQofNXswdWQsMS4ljiPFh39X9pQQ8gYwjsnsjn7LjMl9b6roL\n\tree3oduZnrly3dP+ThGIHJgzx+OC2WyEIuUkHnKeDDUCEt41JHwoy978rANfUMtyY5nGYxIH+ru\n\tEw65kpXc=","X-Gm-Gg":"ASbGnctJvyrgRFFchKqOusf2Zxn605zzbB+47BKZDC+XEKPWKdNhKMEbQwZPjFXs77y\n\tI2jGUUUEM2e+XfIfOIJ++0kRs71acAwSAwIHjLcQhNkcR9xP5Qru9+4AJi6fY+TVU0Hd+buiQlL\n\t6Goy+nN05q/Hisr9D8mgNFwk+exj6pJ3ahiknDGEvkrB9ztiTyQaX4ip2lywA+ZF7JQXT1dzHKo\n\t9ZNaNr+hAqTsRc5q552PR3kWKOkClipJI3TKHXxG6EOYz/kEkE8Pp/HshlTCYbRGFHMTyydYs1M\n\t8ujycRhRChwjsJP+FQ9hzql2nseZSCpeHRvHjp1bwt9NRAbbOnhgFAien+X+T1VjtvUw48n4JIj\n\tQMDO73AW7wh/ScQEbDS+LQ0qtOVFC8q8KVTqvRlMxAcVGpF6i+aCc97rfXaHsV4rs6piGk7p/oZ\n\tCN1tJV5qsMQqlD9IpqWK4xMKwzpK4EaDVi7BiE+s5a1875c9dATIG3cG1XfrzCkZyZfik=","X-Google-Smtp-Source":"AGHT+IExo/lZJ5aSQVeh+ZgmyPHPlqN12DlPdCnFcian4cxW11tHaGwpKCj9UEis+wbsjhh7O5Q6Lg==","X-Received":"by 2002:a05:600c:310d:b0:477:9fcf:3ff9 with SMTP id\n\t5b1f17b1804b1-477c01c359fmr2941445e9.27.1763680834133; \n\tThu, 20 Nov 2025 15:20:34 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Hans de Goede ,\n\tKieran Bingham ,\n\tMilan Zamazal ,\n\tBryan O'Donoghue ","Subject":"[PATCH 05/22] libcamera: swstats_cpu: Drop patternSize_\n\tdocumentation","Date":"Thu, 20 Nov 2025 23:20:02 +0000","Message-ID":"<20251120232019.3590-6-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20251120232019.3590-1-bryan.odonoghue@linaro.org>","References":"<20251120232019.3590-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Hans de Goede \n\npatternSize_ is a private variable and its meaning is already documented\nin the patternSize() getter documentation.\n\nMove the list of valid sizes to the patternSize() getter documentation\nand drop the patternSize_ documentation.\n\nWhile at it also add 1x1 as valid size for use with future support\nof single plane non Bayer input data.\n\nReviewed-by: Kieran Bingham \nReviewed-by: Milan Zamazal \nSigned-off-by: Hans de Goede \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/swstats_cpu.cpp | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex 9c03338a0..1b33ffa71 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -58,6 +58,8 @@ namespace libcamera {\n * also indicates if processLine2() should be called or not.\n * This may only be called after a successful configure() call.\n *\n+ * Valid sizes are: 1x1, 2x2, 4x2 or 4x4.\n+ *\n * \\return The pattern size\n */\n \n@@ -133,13 +135,6 @@ namespace libcamera {\n * \\brief Statistics window, set by setWindow(), used every line\n */\n \n-/**\n- * \\var Size SwStatsCpu::patternSize_\n- * \\brief The size of the bayer pattern\n- *\n- * Valid sizes are: 2x2, 4x2 or 4x4.\n- */\n-\n /**\n * \\var unsigned int SwStatsCpu::xShift_\n * \\brief The offset of x, applied to window_.x for bayer variants\n","prefixes":["05/22"]}