{"id":25094,"url":"https://patchwork.libcamera.org/api/patches/25094/?format=json","web_url":"https://patchwork.libcamera.org/patch/25094/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251120104548.80268-11-mzamazal@redhat.com>","date":"2025-11-20T10:45:45","name":"[RFC,v2,10/13] libcamera: ipa: simple: Apply gain matrix in awb","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3ae27ce8243fe7a94bd2b555956e78fb4f0b91db","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25094/mbox/","series":[{"id":5597,"url":"https://patchwork.libcamera.org/api/series/5597/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5597","date":"2025-11-20T10:45:35","name":"Simple pipeline IPA cleanup","version":2,"mbox":"https://patchwork.libcamera.org/series/5597/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25094/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25094/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7349C3330\n\tfor ;\n\tThu, 20 Nov 2025 10:46:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E75A60AAE;\n\tThu, 20 Nov 2025 11:46:28 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7635860A8A\n\tfor ;\n\tThu, 20 Nov 2025 11:46:26 +0100 (CET)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-640-TFBuK8EXM7ukkGO-8XeZKA-1;\n\tThu, 20 Nov 2025 05:46:24 -0500","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 533331954B0D; Thu, 20 Nov 2025 10:46:23 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.39])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id CA486180087B; Thu, 20 Nov 2025 10:46:21 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"QPK20ef/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1763635585;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=YYuPtkA2BoPPCcF1lZCupzLLtPpMr0tsXnypIKRRbL4=;\n\tb=QPK20ef/zSG1YuXbFU5hbdnQE0P6OeALznMaOmAjf+xL/MMs9DOa1DcMfq5ELMathqG0NP\n\t8tOK26tFgabbDdFMpwLUiQpSkhJtqsf5KSj0qSWgwgucd2KD1gtuKeU4twPnpbMXw61Uqo\n\ttaxUhzmpYaR3WXrVHVxfRpxRrKvxYSA=","X-MC-Unique":"TFBuK8EXM7ukkGO-8XeZKA-1","X-Mimecast-MFC-AGG-ID":"TFBuK8EXM7ukkGO-8XeZKA_1763635583","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","Subject":"[RFC PATCH v2 10/13] libcamera: ipa: simple: Apply gain matrix in\n\tawb","Date":"Thu, 20 Nov 2025 11:45:45 +0100","Message-ID":"<20251120104548.80268-11-mzamazal@redhat.com>","In-Reply-To":"<20251120104548.80268-1-mzamazal@redhat.com>","References":"<20251120104548.80268-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"cUrLYfMywLji0x00O5Hnjh-RnODFeTIy-JRB7FJ7luI_1763635583","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now, when we have a combined matrix, we can apply AWB gains to it\ndirectly in awb.cpp.\n\nSigned-off-by: Milan Zamazal \n---\n src/ipa/simple/algorithms/awb.cpp | 7 ++++++-\n src/ipa/simple/algorithms/lut.cpp | 5 +----\n 2 files changed, 7 insertions(+), 5 deletions(-)","diff":"diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\nindex 9de422519..a0af8a603 100644\n--- a/src/ipa/simple/algorithms/awb.cpp\n+++ b/src/ipa/simple/algorithms/awb.cpp\n@@ -1,6 +1,6 @@\n /* SPDX-License-Identifier: LGPL-2.1-or-later */\n /*\n- * Copyright (C) 2024, Red Hat Inc.\n+ * Copyright (C) 2024-2025 Red Hat Inc.\n *\n * Auto white balance\n */\n@@ -40,6 +40,11 @@ void Awb::prepare(IPAContext &context,\n \t\t [[maybe_unused]] DebayerParams *params)\n {\n \tauto &gains = context.activeState.awb.gains;\n+\tMatrix gainMatrix = { { gains.r(), 0, 0,\n+\t\t\t\t\t 0, gains.g(), 0,\n+\t\t\t\t\t 0, 0, gains.b() } };\n+\tcontext.activeState.combinedMatrix =\n+\t\tcontext.activeState.combinedMatrix * gainMatrix;\n \t/* Just report, the gains are applied in LUT algorithm. */\n \tframeContext.gains.red = gains.r();\n \tframeContext.gains.blue = gains.b();\ndiff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex a17a24c9e..bbf7f168a 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -107,10 +107,7 @@ void Lut::prepare(IPAContext &context,\n \t\t\tparams->blue[i] = gammaTable[static_cast(lutGains.b())];\n \t\t}\n \t} else if (context.activeState.matrixChanged || gammaUpdateNeeded) {\n-\t\tMatrix gainMatrix = { { gains.r(), 0, 0,\n-\t\t\t\t\t\t 0, gains.g(), 0,\n-\t\t\t\t\t\t 0, 0, gains.b() } };\n-\t\tauto matrix = context.activeState.combinedMatrix * gainMatrix;\n+\t\tauto &matrix = context.activeState.combinedMatrix;\n \t\tauto &red = params->redCcm;\n \t\tauto &green = params->greenCcm;\n \t\tauto &blue = params->blueCcm;\n","prefixes":["RFC","v2","10/13"]}