[{"id":3369,"web_url":"https://patchwork.libcamera.org/comment/3369/","msgid":"<20200107192220.GN533370@oden.dyn.berto.se>","date":"2020-01-07T19:22:20","subject":"Re: [libcamera-devel] [PATCH 13/14] test: signal: Test connecting\n\tto non-void slots","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-01-04 07:09:46 +0200, Laurent Pinchart wrote:\n> Test that a signal can be connected to non-void static and member slots.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> test/signal.cpp | 17 +++++++++++++++++\n> 1 file changed, 17 insertions(+)\n> \n> diff --git a/test/signal.cpp b/test/signal.cpp\n> index 9d8f985d15e5..0054ed5a380d 100644\n> --- a/test/signal.cpp\n> +++ b/test/signal.cpp\n> @@ -23,6 +23,11 @@ static void slotStatic(int value)\n> \tvalueStatic_ = value;\n> }\n> \n> +static int slotStaticReturn()\n> +{\n> +\treturn 0;\n> +}\n> +\n> class SlotObject : public Object\n> {\n> public:\n> @@ -85,6 +90,11 @@ protected:\n> \t\tname_ = name;\n> \t}\n> \n> +\tint slotReturn()\n> +\t{\n> +\t\treturn 0;\n> +\t}\n> +\n> \tint init()\n> \t{\n> \t\treturn 0;\n> @@ -174,6 +184,13 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\t/*\n> +\t\t * Test connecting to slots that return a value. This targets\n> +\t\t * compilation, there's no need to check runtime results.\n> +\t\t */\n> +\t\tsignalVoid_.connect(slotStaticReturn);\n> +\t\tsignalVoid_.connect(this, &SignalTest::slotReturn);\n> +\n> \t\t/* ----------------- Signal -> Object tests ----------------- */\n> \n> \t\t/*\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C5F46063B\n\tfor ;\n\tTue, 7 Jan 2020 20:22:21 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id z22so779394ljg.1\n\tfor ;\n\tTue, 07 Jan 2020 11:22:21 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\te21sm327888lfc.63.2020.01.07.11.22.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 07 Jan 2020 11:22:20 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=LL/SQcNV/9Ha7Igpe3eu/74V+mO4+bggfJJ+z1hBeYo=;\n\tb=g2YNM5myruEDjPApxtVtIjTzTF0ns5yZnqOcnOgjFpuO/JyUEwt/NT/Kos1plGg078\n\tYS021kpDgmrfntB/8pc6sYkiP0XpxqxHygJdmsA5t7h62FbOAnGtSau4Kjem11RGC3W1\n\tz4PPtqjv6/UDz/2kjc/oK5IzRYA0PF0FkwryyvQC1xTWDElB7qP8KUAFRjZblbjhZp/b\n\tmZN2gObdBazQG+DwR5ENLDaqP8mmK/GWwpY0Hd7rr7BAFUT5oobqho3r8yZUZ+Ec9gzh\n\tql9rfualopPxUUqrEQ2wsD9PF4OhssuFpAf3Au6LiOCrRsA8317RLG5SN+DWvkxyIlIy\n\tG+lQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=LL/SQcNV/9Ha7Igpe3eu/74V+mO4+bggfJJ+z1hBeYo=;\n\tb=Vr5zfNS9gAU5yeizzmhaqlUWZD8ndCxw/5iLO3fH64gbV3c+01VwevpJzL6F5iROMQ\n\tvDUntzivvmSj1UWvD3Z5R1dlAb/bM7o8u5OlOBxhjxF7pJCqurXF16FHCRMMDGjJHxLm\n\te7niSKWq8K6naln4VKDuvAyExynOugdZQal95GQUF7zWad6jgLpY8v6Od7udrOnXNjNL\n\tUcLgXMZxACTH1RMTphfrMQ3JALzj7RNJ7oxX1zlQGJukD2W9VWJ+SQA7EkBh2waJieTh\n\tVpbtIjxjr18R5eAOzpO7IBxbdKEHln7gAvvl9oisKfHed44zPR2WGYMlbqF2zNsr14Ke\n\t1H6w==","X-Gm-Message-State":"APjAAAUEaUEVKCM2CatzyXf4IEOA9QjI9rBbYwGJOFXyRID1HLJ9eWHB\n\tFmCW0P2QLAQ6bUaEs/Spxs1Weg==","X-Google-Smtp-Source":"APXvYqxZ/qID82OSEn3zj4mYqsgfEAXnh7t02W9fsFWW6FiNOeL6vLuR2mXGc6XNSiNVKvQvt3KLkA==","X-Received":"by 2002:a2e:b044:: with SMTP id d4mr619863ljl.158.1578424941020; \n\tTue, 07 Jan 2020 11:22:21 -0800 (PST)","Date":"Tue, 7 Jan 2020 20:22:20 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200107192220.GN533370@oden.dyn.berto.se>","References":"<20200104050947.7673-1-laurent.pinchart@ideasonboard.com>\n\t<20200104050947.7673-14-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200104050947.7673-14-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 13/14] test: signal: Test connecting\n\tto non-void slots","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 07 Jan 2020 19:22:21 -0000"}}]