[{"id":36882,"web_url":"https://patchwork.libcamera.org/comment/36882/","msgid":"<176346968468.880260.11724216696312633601@isaac-ThinkPad-T16-Gen-2>","date":"2025-11-18T12:41:24","subject":"Re: [PATCH v4 16/21] ipa: rkisp1: ccm: Use Q4_7 format directly","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/people/215/","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch!\n\nReviewed-by: Isaac Scott \n\nQuoting Kieran Bingham (2025-11-14 00:54:20)\n> Replace the legacy call to floatingToFixedPoint with the new FixedPoint\n> quantizer to explicitly describe the type used by the RKISP1 Colour\n> Correction Matrix.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/ipa/rkisp1/algorithms/ccm.cpp | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\n> index de2b6fe775aa..a99336c478b1 100644\n> --- a/src/ipa/rkisp1/algorithms/ccm.cpp\n> +++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n> @@ -115,10 +115,11 @@ void Ccm::setParameters(struct rkisp1_cif_isp_ctk_config &config,\n> * 4 bit integer and 7 bit fractional, ranging from -8 (0x400) to\n> * +7.9921875 (0x3ff)\n> */\n> + using Q4_7 = Quantized>;\n> +\n> for (unsigned int i = 0; i < 3; i++) {\n> for (unsigned int j = 0; j < 3; j++)\n> - config.coeff[i][j] =\n> - floatingToFixedPoint<4, 7, uint16_t, double>(matrix[i][j]);\n> + config.coeff[i][j] = Q4_7(matrix[i][j]).quantized();\n> }\n> \n> for (unsigned int i = 0; i < 3; i++)\n> -- \n> 2.51.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7F34ABD80A\n\tfor ;\n\tTue, 18 Nov 2025 12:41:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 09EBB60AAF;\n\tTue, 18 Nov 2025 13:41:29 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41DA060A80\n\tfor ;\n\tTue, 18 Nov 2025 13:41:27 +0100 (CET)","from thinkpad.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 80368D52;\n\tTue, 18 Nov 2025 13:39:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qvZtGvsW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763469563;\n\tbh=v/5iqk2QNa8FiyfGrSGU14e8E3PYGXh3OHN+B+1A1EU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=qvZtGvsWb2oZKKF/Nfj0nIcTyRWOI2FYgjz4UXttGKfg0Or9RaTd/KG2lAfsHl08E\n\tq/oROYcxUutTXwlXcLNC3TKC1+SU7gpQzTd8NBFBg+t1PR70h5OOEP3nTYw3wi51Ke\n\tfPoEpKBvAZSH6HKwPnPM1HSMTuDHNGf7y34c9tdQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251114005428.90024-17-kieran.bingham@ideasonboard.com>","References":"<20251114005428.90024-1-kieran.bingham@ideasonboard.com>\n\t<20251114005428.90024-17-kieran.bingham@ideasonboard.com>","Subject":"Re: [PATCH v4 16/21] ipa: rkisp1: ccm: Use Q4_7 format directly","From":"Isaac Scott ","Cc":"Kieran Bingham ","To":"Kieran Bingham ,\n\tlibcamera devel ","Date":"Tue, 18 Nov 2025 12:41:24 +0000","Message-ID":"<176346968468.880260.11724216696312633601@isaac-ThinkPad-T16-Gen-2>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36901,"web_url":"https://patchwork.libcamera.org/comment/36901/","msgid":"<20251119043025.GT10711@pendragon.ideasonboard.com>","date":"2025-11-19T04:30:25","subject":"Re: [PATCH v4 16/21] ipa: rkisp1: ccm: Use Q4_7 format directly","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Nov 14, 2025 at 12:54:20AM +0000, Kieran Bingham wrote:\n> Replace the legacy call to floatingToFixedPoint with the new FixedPoint\n> quantizer to explicitly describe the type used by the RKISP1 Colour\n> Correction Matrix.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/ipa/rkisp1/algorithms/ccm.cpp | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\n> index de2b6fe775aa..a99336c478b1 100644\n> --- a/src/ipa/rkisp1/algorithms/ccm.cpp\n> +++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n> @@ -115,10 +115,11 @@ void Ccm::setParameters(struct rkisp1_cif_isp_ctk_config &config,\n> \t * 4 bit integer and 7 bit fractional, ranging from -8 (0x400) to\n> \t * +7.9921875 (0x3ff)\n> \t */\n> +\tusing Q4_7 = Quantized>;\n> +\n> \tfor (unsigned int i = 0; i < 3; i++) {\n> \t\tfor (unsigned int j = 0; j < 3; j++)\n> -\t\t\tconfig.coeff[i][j] =\n> -\t\t\t\tfloatingToFixedPoint<4, 7, uint16_t, double>(matrix[i][j]);\n> +\t\t\tconfig.coeff[i][j] = Q4_7(matrix[i][j]).quantized();\n> \t}\n\nOut of curiosity, what's the impact on the generated code ?\n\n> \n> \tfor (unsigned int i = 0; i < 3; i++)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ACDB9C0F1B\n\tfor ;\n\tWed, 19 Nov 2025 04:31:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53C8B60A7B;\n\tWed, 19 Nov 2025 05:31:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC331609D8\n\tfor ;\n\tWed, 19 Nov 2025 05:30:59 +0100 (CET)","from pendragon.ideasonboard.com (unknown [205.220.129.225])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id AC6C4DD9;\n\tWed, 19 Nov 2025 05:28:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dl5c7aJk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763526535;\n\tbh=dTbG/juHY2xwMH9HqeI2e9zEPubjmHLLbw+zQYJzaPE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dl5c7aJkpw7ylG/JgpRgHXC/wV4J9nVRgTr3vk1ImZt1xHqi5cs6PVMJnxHuUYaZY\n\t1KehT4JRhgoa2AHPbKZYoXzYJj7RISgK+EDzEGRVyoS3bzN444g0pbatelpZffW5PY\n\tg+R1PmbqU972tQYcNrgGvYPjMMaL9qA/aTy3U8Sw=","Date":"Wed, 19 Nov 2025 13:30:25 +0900","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH v4 16/21] ipa: rkisp1: ccm: Use Q4_7 format directly","Message-ID":"<20251119043025.GT10711@pendragon.ideasonboard.com>","References":"<20251114005428.90024-1-kieran.bingham@ideasonboard.com>\n\t<20251114005428.90024-17-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20251114005428.90024-17-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]