{"id":25046,"url":"https://patchwork.libcamera.org/api/patches/25046/?format=json","web_url":"https://patchwork.libcamera.org/patch/25046/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251114005428.90024-17-kieran.bingham@ideasonboard.com>","date":"2025-11-14T00:54:20","name":"[v4,16/21] ipa: rkisp1: ccm: Use Q4_7 format directly","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"cbced71340ee8bc5dffa00d3a0f91a85084dae1b","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25046/mbox/","series":[{"id":5589,"url":"https://patchwork.libcamera.org/api/series/5589/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5589","date":"2025-11-14T00:54:04","name":"libipa: Introduce a Quantized type","version":4,"mbox":"https://patchwork.libcamera.org/series/5589/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25046/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25046/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2C5AFC3334\n\tfor ;\n\tFri, 14 Nov 2025 00:55:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C0C9E60AA4;\n\tFri, 14 Nov 2025 01:55:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9FE1960A81\n\tfor ;\n\tFri, 14 Nov 2025 01:54:53 +0100 (CET)","from charm.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 204B719B5;\n\tFri, 14 Nov 2025 01:52:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oPj9lYFA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763081573;\n\tbh=r1ZXJQShnSWr/dg4t9QvGQ2E3oU88IEwg8g8aeTsFfk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=oPj9lYFAThzrzll5jxaJ0aVSLIgOtGFoiYXy0MSu3OXHg45TJ2DhdjpBO0lGxywTI\n\t4aZ4ygwvKY2CqWw35QRgVMLRQnuEF9RkTlNtJdZSnizsTyZEg3Y4ZI/0yiAhlFhtUI\n\t6IKdIwDSNCX/kjp1cOKhi94C1uF+zqvSub4hlOX8=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham ","Subject":"[PATCH v4 16/21] ipa: rkisp1: ccm: Use Q4_7 format directly","Date":"Fri, 14 Nov 2025 00:54:20 +0000","Message-ID":"<20251114005428.90024-17-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.51.1","In-Reply-To":"<20251114005428.90024-1-kieran.bingham@ideasonboard.com>","References":"<20251114005428.90024-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Replace the legacy call to floatingToFixedPoint with the new FixedPoint\nquantizer to explicitly describe the type used by the RKISP1 Colour\nCorrection Matrix.\n\nSigned-off-by: Kieran Bingham \n---\n src/ipa/rkisp1/algorithms/ccm.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\nindex de2b6fe775aa..a99336c478b1 100644\n--- a/src/ipa/rkisp1/algorithms/ccm.cpp\n+++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n@@ -115,10 +115,11 @@ void Ccm::setParameters(struct rkisp1_cif_isp_ctk_config &config,\n \t * 4 bit integer and 7 bit fractional, ranging from -8 (0x400) to\n \t * +7.9921875 (0x3ff)\n \t */\n+\tusing Q4_7 = Quantized>;\n+\n \tfor (unsigned int i = 0; i < 3; i++) {\n \t\tfor (unsigned int j = 0; j < 3; j++)\n-\t\t\tconfig.coeff[i][j] =\n-\t\t\t\tfloatingToFixedPoint<4, 7, uint16_t, double>(matrix[i][j]);\n+\t\t\tconfig.coeff[i][j] = Q4_7(matrix[i][j]).quantized();\n \t}\n \n \tfor (unsigned int i = 0; i < 3; i++)\n","prefixes":["v4","16/21"]}