[{"id":36838,"web_url":"https://patchwork.libcamera.org/comment/36838/","msgid":"","date":"2025-11-14T18:09:01","subject":"Re: [PATCH v4 13/21] ipa: rkisp1: cproc: Report metadata","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 11. 14. 1:54 keltezéssel, Kieran Bingham írta:\n> Presently the colour processing component exposes controls for\n> brightness, saturation, and contrast to the applications which are\n> handled and processed accordingly on the ISP.\n> \n> The implementation lacks reporting the values that are set back to the\n> application.\n> \n> Utilise the new Quantised types to provide the values that were applied\n> to the hardware and report them in the completed request metadata.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n\nLooks ok to me.\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/ipa/rkisp1/algorithms/cproc.cpp | 12 ++++++++++++\n> src/ipa/rkisp1/algorithms/cproc.h | 4 ++++\n> 2 files changed, 16 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp\n> index 4637a824af03..7475e6c1b609 100644\n> --- a/src/ipa/rkisp1/algorithms/cproc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/cproc.cpp\n> @@ -145,6 +145,18 @@ void ColorProcessing::prepare([[maybe_unused]] IPAContext &context,\n> \tconfig->sat = frameContext.cproc.saturation.quantized();\n> }\n> \n> +/**\n> + * \\copydoc libcamera::ipa::Algorithm::process\n> + */\n> +void ColorProcessing::process([[maybe_unused]] IPAContext &context, [[maybe_unused]] const uint32_t frame,\n> +\t\t\t IPAFrameContext &frameContext, [[maybe_unused]] const rkisp1_stat_buffer *stats,\n> +\t\t\t ControlList &metadata)\n> +{\n> +\tmetadata.set(controls::Brightness, frameContext.cproc.brightness.value());\n> +\tmetadata.set(controls::Contrast, frameContext.cproc.contrast.value());\n> +\tmetadata.set(controls::Saturation, frameContext.cproc.saturation.value());\n> +}\n> +\n> REGISTER_IPA_ALGORITHM(ColorProcessing, \"ColorProcessing\")\n> \n> } /* namespace ipa::rkisp1::algorithms */\n> diff --git a/src/ipa/rkisp1/algorithms/cproc.h b/src/ipa/rkisp1/algorithms/cproc.h\n> index fd38fd17e8bb..9b589ebd4ad7 100644\n> --- a/src/ipa/rkisp1/algorithms/cproc.h\n> +++ b/src/ipa/rkisp1/algorithms/cproc.h\n> @@ -30,6 +30,10 @@ public:\n> \tvoid prepare(IPAContext &context, const uint32_t frame,\n> \t\t IPAFrameContext &frameContext,\n> \t\t RkISP1Params *params) override;\n> +\tvoid process(IPAContext &context, const uint32_t frame,\n> +\t\t IPAFrameContext &frameContext,\n> +\t\t const rkisp1_stat_buffer *stats,\n> +\t\t ControlList &metadata) override;\n> };\n> \n> } /* namespace ipa::rkisp1::algorithms */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7C343C32DB\n\tfor ;\n\tFri, 14 Nov 2025 18:09:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E406060AAB;\n\tFri, 14 Nov 2025 19:09:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4BFB9606E6\n\tfor ;\n\tFri, 14 Nov 2025 19:09:03 +0100 (CET)","from [192.168.33.35] (185.221.143.100.nat.pool.zt.hu\n\t[185.221.143.100])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F2BFC77;\n\tFri, 14 Nov 2025 19:07:01 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"b8Af4uFX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763143622;\n\tbh=xemedX+xw8Iq7mi/+mYTHQXFiQzQIfI2gU44kQ8JM8g=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=b8Af4uFXh5MgPdRWVK2iWjXidf+z6YexMLXe/FAzO+LvqdPS46b5Ir0jtMkNyx7o4\n\tUYR/aor6dCLRW5q7jp1zxMu1yRyzcxX34IZDdgUwTZ4Hz8Qv1GRKHMUm7ETJ863prV\n\tOwh5OYpcxXfnKgWQ+JLZI4bPZmurdBiSxGsyVa4s=","Message-ID":"","Date":"Fri, 14 Nov 2025 19:09:01 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 13/21] ipa: rkisp1: cproc: Report metadata","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20251114005428.90024-1-kieran.bingham@ideasonboard.com>\n\t<20251114005428.90024-14-kieran.bingham@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251114005428.90024-14-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36879,"web_url":"https://patchwork.libcamera.org/comment/36879/","msgid":"<176346963632.880260.13179398545601197968@isaac-ThinkPad-T16-Gen-2>","date":"2025-11-18T12:40:36","subject":"Re: [PATCH v4 13/21] ipa: rkisp1: cproc: Report metadata","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/people/215/","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch!\n\nReviewed-by: Isaac Scott \n\nQuoting Kieran Bingham (2025-11-14 00:54:17)\n> Presently the colour processing component exposes controls for\n> brightness, saturation, and contrast to the applications which are\n> handled and processed accordingly on the ISP.\n> \n> The implementation lacks reporting the values that are set back to the\n> application.\n> \n> Utilise the new Quantised types to provide the values that were applied\n> to the hardware and report them in the completed request metadata.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/ipa/rkisp1/algorithms/cproc.cpp | 12 ++++++++++++\n> src/ipa/rkisp1/algorithms/cproc.h | 4 ++++\n> 2 files changed, 16 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp\n> index 4637a824af03..7475e6c1b609 100644\n> --- a/src/ipa/rkisp1/algorithms/cproc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/cproc.cpp\n> @@ -145,6 +145,18 @@ void ColorProcessing::prepare([[maybe_unused]] IPAContext &context,\n> config->sat = frameContext.cproc.saturation.quantized();\n> }\n> \n> +/**\n> + * \\copydoc libcamera::ipa::Algorithm::process\n> + */\n> +void ColorProcessing::process([[maybe_unused]] IPAContext &context, [[maybe_unused]] const uint32_t frame,\n> + IPAFrameContext &frameContext, [[maybe_unused]] const rkisp1_stat_buffer *stats,\n> + ControlList &metadata)\n> +{\n> + metadata.set(controls::Brightness, frameContext.cproc.brightness.value());\n> + metadata.set(controls::Contrast, frameContext.cproc.contrast.value());\n> + metadata.set(controls::Saturation, frameContext.cproc.saturation.value());\n> +}\n> +\n> REGISTER_IPA_ALGORITHM(ColorProcessing, \"ColorProcessing\")\n> \n> } /* namespace ipa::rkisp1::algorithms */\n> diff --git a/src/ipa/rkisp1/algorithms/cproc.h b/src/ipa/rkisp1/algorithms/cproc.h\n> index fd38fd17e8bb..9b589ebd4ad7 100644\n> --- a/src/ipa/rkisp1/algorithms/cproc.h\n> +++ b/src/ipa/rkisp1/algorithms/cproc.h\n> @@ -30,6 +30,10 @@ public:\n> void prepare(IPAContext &context, const uint32_t frame,\n> IPAFrameContext &frameContext,\n> RkISP1Params *params) override;\n> + void process(IPAContext &context, const uint32_t frame,\n> + IPAFrameContext &frameContext,\n> + const rkisp1_stat_buffer *stats,\n> + ControlList &metadata) override;\n> };\n> \n> } /* namespace ipa::rkisp1::algorithms */\n> -- \n> 2.51.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE8D7BD80A\n\tfor ;\n\tTue, 18 Nov 2025 12:40:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6064860A85;\n\tTue, 18 Nov 2025 13:40:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF4D2606D5\n\tfor ;\n\tTue, 18 Nov 2025 13:40:38 +0100 (CET)","from thinkpad.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3C7E0D52;\n\tTue, 18 Nov 2025 13:38:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OSkmSHoD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763469515;\n\tbh=s0KwU3/aMtKKBd06WX1ci7gGomm3EYpPz96pUCVrmA0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=OSkmSHoDUhr0y4vYFgqEE57RojptJi6FW+cRx63OupJwi5mWqgdir90w5FqA/LR5Q\n\trVFtL1GZDXX+qduacWPA839M/oNfex/IDLCNrS5NMUSozI8X0kXYHrFLiZl5JidgRn\n\tg8Y5A7gU+UU47i2iglb8LMIHNZTC4DE87t43Vlek=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251114005428.90024-14-kieran.bingham@ideasonboard.com>","References":"<20251114005428.90024-1-kieran.bingham@ideasonboard.com>\n\t<20251114005428.90024-14-kieran.bingham@ideasonboard.com>","Subject":"Re: [PATCH v4 13/21] ipa: rkisp1: cproc: Report metadata","From":"Isaac Scott ","Cc":"Kieran Bingham ","To":"Kieran Bingham ,\n\tlibcamera devel ","Date":"Tue, 18 Nov 2025 12:40:36 +0000","Message-ID":"<176346963632.880260.13179398545601197968@isaac-ThinkPad-T16-Gen-2>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36903,"web_url":"https://patchwork.libcamera.org/comment/36903/","msgid":"<20251119043050.GU10711@pendragon.ideasonboard.com>","date":"2025-11-19T04:30:50","subject":"Re: [PATCH v4 13/21] ipa: rkisp1: cproc: Report metadata","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Nov 14, 2025 at 12:54:17AM +0000, Kieran Bingham wrote:\n> Presently the colour processing component exposes controls for\n> brightness, saturation, and contrast to the applications which are\n> handled and processed accordingly on the ISP.\n> \n> The implementation lacks reporting the values that are set back to the\n> application.\n> \n> Utilise the new Quantised types to provide the values that were applied\n> to the hardware and report them in the completed request metadata.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/ipa/rkisp1/algorithms/cproc.cpp | 12 ++++++++++++\n> src/ipa/rkisp1/algorithms/cproc.h | 4 ++++\n> 2 files changed, 16 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp\n> index 4637a824af03..7475e6c1b609 100644\n> --- a/src/ipa/rkisp1/algorithms/cproc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/cproc.cpp\n> @@ -145,6 +145,18 @@ void ColorProcessing::prepare([[maybe_unused]] IPAContext &context,\n> \tconfig->sat = frameContext.cproc.saturation.quantized();\n> }\n> \n> +/**\n> + * \\copydoc libcamera::ipa::Algorithm::process\n> + */\n> +void ColorProcessing::process([[maybe_unused]] IPAContext &context, [[maybe_unused]] const uint32_t frame,\n> +\t\t\t IPAFrameContext &frameContext, [[maybe_unused]] const rkisp1_stat_buffer *stats,\n> +\t\t\t ControlList &metadata)\n\nWith line wraps,\n\nReviewed-by: Laurent Pinchart \n\n> +{\n> +\tmetadata.set(controls::Brightness, frameContext.cproc.brightness.value());\n> +\tmetadata.set(controls::Contrast, frameContext.cproc.contrast.value());\n> +\tmetadata.set(controls::Saturation, frameContext.cproc.saturation.value());\n> +}\n> +\n> REGISTER_IPA_ALGORITHM(ColorProcessing, \"ColorProcessing\")\n> \n> } /* namespace ipa::rkisp1::algorithms */\n> diff --git a/src/ipa/rkisp1/algorithms/cproc.h b/src/ipa/rkisp1/algorithms/cproc.h\n> index fd38fd17e8bb..9b589ebd4ad7 100644\n> --- a/src/ipa/rkisp1/algorithms/cproc.h\n> +++ b/src/ipa/rkisp1/algorithms/cproc.h\n> @@ -30,6 +30,10 @@ public:\n> \tvoid prepare(IPAContext &context, const uint32_t frame,\n> \t\t IPAFrameContext &frameContext,\n> \t\t RkISP1Params *params) override;\n> +\tvoid process(IPAContext &context, const uint32_t frame,\n> +\t\t IPAFrameContext &frameContext,\n> +\t\t const rkisp1_stat_buffer *stats,\n> +\t\t ControlList &metadata) override;\n> };\n> \n> } /* namespace ipa::rkisp1::algorithms */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F18ADC0F1B\n\tfor ;\n\tWed, 19 Nov 2025 04:31:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B2D0660A85;\n\tWed, 19 Nov 2025 05:31:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5174A609D8\n\tfor ;\n\tWed, 19 Nov 2025 05:31:25 +0100 (CET)","from pendragon.ideasonboard.com (unknown [205.220.129.225])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 34803DD9;\n\tWed, 19 Nov 2025 05:29:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"k9d+GTE2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763526561;\n\tbh=0wLr0TqUDK47WyaHumrka3aI0j7X6h/30hgtoCPK5lg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=k9d+GTE2OUMmLW6J1xYNJr0DaLuz9DQgAMYfegfdfWqhI5h8XuS5vr5rRRKbTpoGR\n\tlCFbiiKuf3ydiN+NCyU9lo3QMoS2blWfAuyaPFAO0ImoV4SFfniQ2IuC/DsQo5vNJs\n\tFkA0o5CFYzJYqOwMenUbJzrLuZ9IBc5uvwEanSvk=","Date":"Wed, 19 Nov 2025 13:30:50 +0900","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH v4 13/21] ipa: rkisp1: cproc: Report metadata","Message-ID":"<20251119043050.GU10711@pendragon.ideasonboard.com>","References":"<20251114005428.90024-1-kieran.bingham@ideasonboard.com>\n\t<20251114005428.90024-14-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20251114005428.90024-14-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]