{"id":25038,"url":"https://patchwork.libcamera.org/api/patches/25038/?format=json","web_url":"https://patchwork.libcamera.org/patch/25038/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251114005428.90024-9-kieran.bingham@ideasonboard.com>","date":"2025-11-14T00:54:12","name":"[v4,08/21] ipa: libipa: Provide Q5.8 FixedPoint support","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"96576777a0e66d2f7f3c99972195a7a183ba9f2e","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25038/mbox/","series":[{"id":5589,"url":"https://patchwork.libcamera.org/api/series/5589/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5589","date":"2025-11-14T00:54:04","name":"libipa: Introduce a Quantized type","version":4,"mbox":"https://patchwork.libcamera.org/series/5589/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25038/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25038/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BDA62C3317\n\tfor ;\n\tFri, 14 Nov 2025 00:55:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7860B60AA8;\n\tFri, 14 Nov 2025 01:54:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B5D3F60AA7\n\tfor ;\n\tFri, 14 Nov 2025 01:54:50 +0100 (CET)","from charm.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 369218FA;\n\tFri, 14 Nov 2025 01:52:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"plz86knk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763081570;\n\tbh=6G2ZcQHiEZLvQTYgB1pu+nA9XQdJ0oX8jEE+U0kKygw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=plz86knkwgkbusvEZlxhOYWOiRqFQNiW4Vf1w0gly/8WYEpojQJuPJFWxOF6TksKT\n\tM36gXSqvG8NKRROZVeytjNKgAzwz5zkEwClI2WikTqqDRYr+8/O6woLVs3PVJ9Gbos\n\tzShopYWrAeaeJmK7s/EjOFLro2QgHJL4hYa+7xwQ=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham ","Subject":"[PATCH v4 08/21] ipa: libipa: Provide Q5.8 FixedPoint support","Date":"Fri, 14 Nov 2025 00:54:12 +0000","Message-ID":"<20251114005428.90024-9-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.51.1","In-Reply-To":"<20251114005428.90024-1-kieran.bingham@ideasonboard.com>","References":"<20251114005428.90024-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Provide a FixedPoint Quantized type to support the Q5.8 format\nrepresenting values in the range [0 .. 31.9961] with a resolution of\n1/256.\n\nSigned-off-by: Kieran Bingham \n\n---\nThis type is used by the Mali-C55 Digital Gain component.\n\n src/ipa/libipa/fixedpoint.cpp | 9 +++++++++\n src/ipa/libipa/fixedpoint.h | 1 +\n test/ipa/libipa/fixedpoint.cpp | 5 +++++\n 3 files changed, 15 insertions(+)","diff":"diff --git a/src/ipa/libipa/fixedpoint.cpp b/src/ipa/libipa/fixedpoint.cpp\nindex 967b00bcd7c2..a6f8ef351c32 100644\n--- a/src/ipa/libipa/fixedpoint.cpp\n+++ b/src/ipa/libipa/fixedpoint.cpp\n@@ -148,6 +148,15 @@ namespace ipa {\n * values in the range [-16.0, 15.9375] with a resolution of 1/16.\n */\n \n+/**\n+ * \\typedef UQ5_8\n+ * \\brief 5.8 unsigned fixed-point quantizer\n+ *\n+ * A Quantized type using 5 bits for the integer part and 8 bits for the\n+ * fractional part, stored in an unsigned 16-bit integer (\\c uint16_t). Represents\n+ * values in the range [0.0, 31.9961] with a resolution of 1/256.\n+ */\n+\n /**\n * \\typedef Q12_4\n * \\brief 12.4 signed fixed-point quantizer\ndiff --git a/src/ipa/libipa/fixedpoint.h b/src/ipa/libipa/fixedpoint.h\nindex ce621cb01a5a..8f095210a918 100644\n--- a/src/ipa/libipa/fixedpoint.h\n+++ b/src/ipa/libipa/fixedpoint.h\n@@ -106,6 +106,7 @@ using Q1_7 = Quantized>;\n using UQ1_7 = Quantized>;\n \n using Q5_4 = Quantized>;\n+using UQ5_8 = Quantized>;\n \n using Q12_4 = Quantized>;\n using UQ12_4 = Quantized>;\ndiff --git a/test/ipa/libipa/fixedpoint.cpp b/test/ipa/libipa/fixedpoint.cpp\nindex 1d018c0128df..c830b5f05a19 100644\n--- a/test/ipa/libipa/fixedpoint.cpp\n+++ b/test/ipa/libipa/fixedpoint.cpp\n@@ -195,6 +195,11 @@ protected:\n \t\tfails += quantizedCheck(-16.00f, 0b10000'0000, -16.00f);\n \t\tfails += quantizedCheck( 15.94f, 0b01111'1111, 15.9375f);\n \n+\t\t/* UQ5_8(0 .. 31.9961) Min: [0x0000:0] -- Max: [0x1fff:31.9961] Step:0.00390625 */\n+\t\tintroduce(\"UQ5_8\");\n+\t\tfails += quantizedCheck( 0.00f, 0b00000'00000000, 0.00f);\n+\t\tfails += quantizedCheck(32.00f, 0b11111'11111111, 31.9961f);\n+\n \t\t/* Q12.4(-2048 .. 2047.94) Min: [0x8000:-2048] -- Max: [0x7fff:2047.94] Step:0.0625 */\n \t\tintroduce(\"Q12_4\");\n \t\tfails += quantizedCheck(0.0f, 0b000000000000'0000, 0.0f);\n","prefixes":["v4","08/21"]}