{"id":25037,"url":"https://patchwork.libcamera.org/api/patches/25037/?format=json","web_url":"https://patchwork.libcamera.org/patch/25037/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251114005428.90024-8-kieran.bingham@ideasonboard.com>","date":"2025-11-14T00:54:11","name":"[v4,07/21] ipa: libipa: Provide Q5.4 FixedPoint support","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2e66e0e492e7240500511cd29668e358559f6ed6","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25037/mbox/","series":[{"id":5589,"url":"https://patchwork.libcamera.org/api/series/5589/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5589","date":"2025-11-14T00:54:04","name":"libipa: Introduce a Quantized type","version":4,"mbox":"https://patchwork.libcamera.org/series/5589/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25037/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25037/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF4B1C32DB\n\tfor ;\n\tFri, 14 Nov 2025 00:55:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AC58760AA3;\n\tFri, 14 Nov 2025 01:54:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6710960A9E\n\tfor ;\n\tFri, 14 Nov 2025 01:54:50 +0100 (CET)","from charm.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D812C1306;\n\tFri, 14 Nov 2025 01:52:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Sl4pNZCQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763081570;\n\tbh=WkCHl7q7EkW2IT3c4qk5dJwd7TPeEcVjNIGVOdput9w=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Sl4pNZCQIyHzVOdJctHiSZD7nAMJ5I7udhqDIiYN9ss+TxwwvxmEAqJZsfd6/xHeK\n\tC3HwSPahD60YcrbGTXHAjCcC0SDUXI+vZftoyNfceXHqOc5nTmnGkgv9nEGy50zfUU\n\txtYTWkfEQ31hhRMwJx7IWzSOUmHgaaR581Je+aks=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham ","Subject":"[PATCH v4 07/21] ipa: libipa: Provide Q5.4 FixedPoint support","Date":"Fri, 14 Nov 2025 00:54:11 +0000","Message-ID":"<20251114005428.90024-8-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.51.1","In-Reply-To":"<20251114005428.90024-1-kieran.bingham@ideasonboard.com>","References":"<20251114005428.90024-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Provide a FixedPoint Quantized type to support the Q5.4 format\nrepresenting values in the range [-16.0, 15.9375] with a resolution of\n1/16.\n\nSigned-off-by: Kieran Bingham \n\n---\nThis format is used by the RKISP1 for Chromatic Abberation Correction\nhandling\n\nv4:\n- Fix grammar in type documentation\n\n src/ipa/libipa/fixedpoint.cpp | 9 +++++++++\n src/ipa/libipa/fixedpoint.h | 2 ++\n test/ipa/libipa/fixedpoint.cpp | 5 +++++\n 3 files changed, 16 insertions(+)","diff":"diff --git a/src/ipa/libipa/fixedpoint.cpp b/src/ipa/libipa/fixedpoint.cpp\nindex 4c3ea33497bf..967b00bcd7c2 100644\n--- a/src/ipa/libipa/fixedpoint.cpp\n+++ b/src/ipa/libipa/fixedpoint.cpp\n@@ -139,6 +139,15 @@ namespace ipa {\n * values in the range [0.0, 1.992] with a resolution of 1/128.\n */\n \n+/**\n+ * \\typedef Q5_4\n+ * \\brief 5.4 signed fixed-point quantizer\n+ *\n+ * A Quantized type using 5 bits for the integer part and 4 bits for the\n+ * fractional part, stored in a signed 16-bit integer (\\c int16_t). Represents\n+ * values in the range [-16.0, 15.9375] with a resolution of 1/16.\n+ */\n+\n /**\n * \\typedef Q12_4\n * \\brief 12.4 signed fixed-point quantizer\ndiff --git a/src/ipa/libipa/fixedpoint.h b/src/ipa/libipa/fixedpoint.h\nindex d97e6d6135ad..ce621cb01a5a 100644\n--- a/src/ipa/libipa/fixedpoint.h\n+++ b/src/ipa/libipa/fixedpoint.h\n@@ -105,6 +105,8 @@ struct FixedPointQTraits {\n using Q1_7 = Quantized>;\n using UQ1_7 = Quantized>;\n \n+using Q5_4 = Quantized>;\n+\n using Q12_4 = Quantized>;\n using UQ12_4 = Quantized>;\n \ndiff --git a/test/ipa/libipa/fixedpoint.cpp b/test/ipa/libipa/fixedpoint.cpp\nindex 338571e38f68..1d018c0128df 100644\n--- a/test/ipa/libipa/fixedpoint.cpp\n+++ b/test/ipa/libipa/fixedpoint.cpp\n@@ -190,6 +190,11 @@ protected:\n \t\tfails += quantizedCheck(-0.4f, 0b1111'1001101, -0.398438f);\t/* 0x7cd */\n \t\tfails += quantizedCheck(-1.4f, 0b1110'1001101, -1.39844f);\t/* 0x74d */\n \n+\t\t/* Q5_4(-16 .. 15.9375) Min: [0x0100:-16] -- Max: [0x00ff:15.9375] Step:0.0625 */\n+\t\tintroduce(\"Q5_4\");\n+\t\tfails += quantizedCheck(-16.00f, 0b10000'0000, -16.00f);\n+\t\tfails += quantizedCheck( 15.94f, 0b01111'1111, 15.9375f);\n+\n \t\t/* Q12.4(-2048 .. 2047.94) Min: [0x8000:-2048] -- Max: [0x7fff:2047.94] Step:0.0625 */\n \t\tintroduce(\"Q12_4\");\n \t\tfails += quantizedCheck(0.0f, 0b000000000000'0000, 0.0f);\n","prefixes":["v4","07/21"]}