[{"id":36835,"web_url":"https://patchwork.libcamera.org/comment/36835/","msgid":"","date":"2025-11-14T18:08:28","subject":"Re: [PATCH v4 06/21] test: libipa: Add Q4.7 type and tests to match\n\texisting use case tests","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 11. 14. 1:54 keltezéssel, Kieran Bingham írta:\n> The existing fixed point test cases utilise a signed Q4.7 format. Add\n> matching tests covering the same values and extend to validate the full\n> type.\n\nI must be missing something, but why are these not added in the first round?\n\n\n> \n> Signed-off-by: Kieran Bingham \n> \n> ---\n> v4:\n> - Remove redundant \"No Sign Extension\" comment\n> \n> test/ipa/libipa/fixedpoint.cpp | 18 ++++++++++++++++++\n> 1 file changed, 18 insertions(+)\n> \n> diff --git a/test/ipa/libipa/fixedpoint.cpp b/test/ipa/libipa/fixedpoint.cpp\n> index 3f2d9ac97fe5..338571e38f68 100644\n> --- a/test/ipa/libipa/fixedpoint.cpp\n> +++ b/test/ipa/libipa/fixedpoint.cpp\n> @@ -20,6 +20,9 @@ using namespace std;\n> using namespace libcamera;\n> using namespace ipa;\n> \n> +/* Q4_7(-8 .. 7.99219) Min: [0x0400:-8] -- Max: [0x03ff:7.99219] Step:0.0078125 */\n> +using Q4_7 = Quantized>;\n> +\n> class FixedPointUtilsTest : public Test\n> {\n> protected:\n> @@ -172,6 +175,21 @@ protected:\n> \t\tfails += quantizedCheck(1.0f, 0b1'0000000, 1.0f);\t\t/* Mid */\n> \t\tfails += quantizedCheck(1.992f, 0b1'1111111, 1.99219f);\t\t/* Max */\n> \n> +\t\t/* Q4_7(-8 .. 7.99219) Min: [0x0400:-8] -- Max: [0x03ff:7.99219] Step:0.0078125 */\n> +\t\tintroduce(\"Q4_7\");\n> +\t\tfails += quantizedCheck(-8.0f, 0b1000'0000000, -8.0f);\t\t/* Min */\n> +\t\tfails += quantizedCheck(-0.008f, 0b1111'1111111, -0.0078125);\t/* -1 step */\n> +\t\tfails += quantizedCheck( 0.0f, 0b0000'0000000, 0.0f);\t\t/* Zero */\n> +\t\tfails += quantizedCheck( 0.008f, 0b0000'0000001, 0.0078125f);\t/* +1 step */\n> +\t\tfails += quantizedCheck( 7.992f, 0b0111'1111111, 7.99219f);\t/* Max */\n> +\n> +\t\t/* Retain additional tests from original testFixedPoint() */\n> +\t\tfails += quantizedCheck( 0.2f, 0b0000'0011010, 0.203125f);\t/* 0x01a */\n> +\t\tfails += quantizedCheck(-0.2f, 0b1111'1100110, -0.203125f);\t/* 0x7e6 */\n> +\t\tfails += quantizedCheck(-0.8f, 0b1111'0011010, -0.796875f);\t/* 0x79a */\n> +\t\tfails += quantizedCheck(-0.4f, 0b1111'1001101, -0.398438f);\t/* 0x7cd */\n> +\t\tfails += quantizedCheck(-1.4f, 0b1110'1001101, -1.39844f);\t/* 0x74d */\n> +\n> \t\t/* Q12.4(-2048 .. 2047.94) Min: [0x8000:-2048] -- Max: [0x7fff:2047.94] Step:0.0625 */\n> \t\tintroduce(\"Q12_4\");\n> \t\tfails += quantizedCheck(0.0f, 0b000000000000'0000, 0.0f);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 570F7C3263\n\tfor ;\n\tFri, 14 Nov 2025 18:08:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14ADA60AA0;\n\tFri, 14 Nov 2025 19:08:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ADA9B60A9E\n\tfor ;\n\tFri, 14 Nov 2025 19:08:29 +0100 (CET)","from [192.168.33.35] (185.221.143.100.nat.pool.zt.hu\n\t[185.221.143.100])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2F470BD2;\n\tFri, 14 Nov 2025 19:06:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NlWZKAR9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763143588;\n\tbh=AyPH0VvdrkkqIE+DysE5NR16qhZRBSGnx/+4SKu772o=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=NlWZKAR99QuIffeSYb3MgSX4RNa7+CE2JiwHXwg9TzZ4do/Dwn2ewk7MUVj3HGYtv\n\tMcjJ3xU0LlxpDk5uok/NsCF6vgPAuMMvairhFJVnwvU+/lR/GPQbwQe0S4bprIiyXs\n\tBUgVP7a4s3SmWVuCJWHtpHoTMgkNLUlwL4dXoqN4=","Message-ID":"","Date":"Fri, 14 Nov 2025 19:08:28 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 06/21] test: libipa: Add Q4.7 type and tests to match\n\texisting use case tests","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20251114005428.90024-1-kieran.bingham@ideasonboard.com>\n\t<20251114005428.90024-7-kieran.bingham@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251114005428.90024-7-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36839,"web_url":"https://patchwork.libcamera.org/comment/36839/","msgid":"<176314629196.567526.15393144623565749185@ping.linuxembedded.co.uk>","date":"2025-11-14T18:51:31","subject":"Re: [PATCH v4 06/21] test: libipa: Add Q4.7 type and tests to match\n\texisting use case tests","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-11-14 18:08:28)\n> 2025. 11. 14. 1:54 keltezéssel, Kieran Bingham írta:\n> > The existing fixed point test cases utilise a signed Q4.7 format. Add\n> > matching tests covering the same values and extend to validate the full\n> > type.\n> \n> I must be missing something, but why are these not added in the first round?\n> \n\nThese are the replication of the existing fixed point test cases. So\nthey are here separated to make it clear that these *duplicate* the\ntests higher in the file which use the old helpers directly.\n\n--\nKieran\n\n> \n> > \n> > Signed-off-by: Kieran Bingham \n> > \n> > ---\n> > v4:\n> > - Remove redundant \"No Sign Extension\" comment\n> > \n> > test/ipa/libipa/fixedpoint.cpp | 18 ++++++++++++++++++\n> > 1 file changed, 18 insertions(+)\n> > \n> > diff --git a/test/ipa/libipa/fixedpoint.cpp b/test/ipa/libipa/fixedpoint.cpp\n> > index 3f2d9ac97fe5..338571e38f68 100644\n> > --- a/test/ipa/libipa/fixedpoint.cpp\n> > +++ b/test/ipa/libipa/fixedpoint.cpp\n> > @@ -20,6 +20,9 @@ using namespace std;\n> > using namespace libcamera;\n> > using namespace ipa;\n> > \n> > +/* Q4_7(-8 .. 7.99219) Min: [0x0400:-8] -- Max: [0x03ff:7.99219] Step:0.0078125 */\n> > +using Q4_7 = Quantized>;\n> > +\n> > class FixedPointUtilsTest : public Test\n> > {\n> > protected:\n> > @@ -172,6 +175,21 @@ protected:\n> > fails += quantizedCheck(1.0f, 0b1'0000000, 1.0f); /* Mid */\n> > fails += quantizedCheck(1.992f, 0b1'1111111, 1.99219f); /* Max */\n> > \n> > + /* Q4_7(-8 .. 7.99219) Min: [0x0400:-8] -- Max: [0x03ff:7.99219] Step:0.0078125 */\n> > + introduce(\"Q4_7\");\n> > + fails += quantizedCheck(-8.0f, 0b1000'0000000, -8.0f); /* Min */\n> > + fails += quantizedCheck(-0.008f, 0b1111'1111111, -0.0078125); /* -1 step */\n> > + fails += quantizedCheck( 0.0f, 0b0000'0000000, 0.0f); /* Zero */\n> > + fails += quantizedCheck( 0.008f, 0b0000'0000001, 0.0078125f); /* +1 step */\n> > + fails += quantizedCheck( 7.992f, 0b0111'1111111, 7.99219f); /* Max */\n> > +\n> > + /* Retain additional tests from original testFixedPoint() */\n> > + fails += quantizedCheck( 0.2f, 0b0000'0011010, 0.203125f); /* 0x01a */\n> > + fails += quantizedCheck(-0.2f, 0b1111'1100110, -0.203125f); /* 0x7e6 */\n> > + fails += quantizedCheck(-0.8f, 0b1111'0011010, -0.796875f); /* 0x79a */\n> > + fails += quantizedCheck(-0.4f, 0b1111'1001101, -0.398438f); /* 0x7cd */\n> > + fails += quantizedCheck(-1.4f, 0b1110'1001101, -1.39844f); /* 0x74d */\n> > +\n> > /* Q12.4(-2048 .. 2047.94) Min: [0x8000:-2048] -- Max: [0x7fff:2047.94] Step:0.0625 */\n> > introduce(\"Q12_4\");\n> > fails += quantizedCheck(0.0f, 0b000000000000'0000, 0.0f);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8ADEFC3241\n\tfor ;\n\tFri, 14 Nov 2025 18:51:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A06C460A8B;\n\tFri, 14 Nov 2025 19:51:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5697B606E6\n\tfor ;\n\tFri, 14 Nov 2025 19:51:35 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 24E24161;\n\tFri, 14 Nov 2025 19:49:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"itcQNAo5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763146174;\n\tbh=EDzyRFgjZEMDKII9G4GoIQ7gx20AswfQp8gntFZJz3w=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=itcQNAo5jL+TB6dECE7cioopgSRXa3bmAWCp9Zg3x369X5ErhOhQrp1XKwqVnx/hk\n\th85DHlGhtR3Wfdq6bYOhtpwm+/yulnRDHSrM+aKyw/F5i8RtY9zABIQHZjRFsCyyUL\n\tuvAV8LYhh01k3j/StdiGVocUAVN46kHIHNn1yCWU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20251114005428.90024-1-kieran.bingham@ideasonboard.com>\n\t<20251114005428.90024-7-kieran.bingham@ideasonboard.com>\n\t","Subject":"Re: [PATCH v4 06/21] test: libipa: Add Q4.7 type and tests to match\n\texisting use case tests","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera devel ","Date":"Fri, 14 Nov 2025 18:51:31 +0000","Message-ID":"<176314629196.567526.15393144623565749185@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36872,"web_url":"https://patchwork.libcamera.org/comment/36872/","msgid":"<176346951878.880260.11423236214199652326@isaac-ThinkPad-T16-Gen-2>","date":"2025-11-18T12:38:38","subject":"Re: [PATCH v4 06/21] test: libipa: Add Q4.7 type and tests to match\n\texisting use case tests","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/people/215/","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch!\n\nReviewed-by: Isaac Scott \n\nQuoting Kieran Bingham (2025-11-14 00:54:10)\n> The existing fixed point test cases utilise a signed Q4.7 format. Add\n> matching tests covering the same values and extend to validate the full\n> type.\n> \n> Signed-off-by: Kieran Bingham \n> \n> ---\n> v4:\n> - Remove redundant \"No Sign Extension\" comment\n> \n> test/ipa/libipa/fixedpoint.cpp | 18 ++++++++++++++++++\n> 1 file changed, 18 insertions(+)\n> \n> diff --git a/test/ipa/libipa/fixedpoint.cpp b/test/ipa/libipa/fixedpoint.cpp\n> index 3f2d9ac97fe5..338571e38f68 100644\n> --- a/test/ipa/libipa/fixedpoint.cpp\n> +++ b/test/ipa/libipa/fixedpoint.cpp\n> @@ -20,6 +20,9 @@ using namespace std;\n> using namespace libcamera;\n> using namespace ipa;\n> \n> +/* Q4_7(-8 .. 7.99219) Min: [0x0400:-8] -- Max: [0x03ff:7.99219] Step:0.0078125 */\n> +using Q4_7 = Quantized>;\n> +\n> class FixedPointUtilsTest : public Test\n> {\n> protected:\n> @@ -172,6 +175,21 @@ protected:\n> fails += quantizedCheck(1.0f, 0b1'0000000, 1.0f); /* Mid */\n> fails += quantizedCheck(1.992f, 0b1'1111111, 1.99219f); /* Max */\n> \n> + /* Q4_7(-8 .. 7.99219) Min: [0x0400:-8] -- Max: [0x03ff:7.99219] Step:0.0078125 */\n> + introduce(\"Q4_7\");\n> + fails += quantizedCheck(-8.0f, 0b1000'0000000, -8.0f); /* Min */\n> + fails += quantizedCheck(-0.008f, 0b1111'1111111, -0.0078125); /* -1 step */\n> + fails += quantizedCheck( 0.0f, 0b0000'0000000, 0.0f); /* Zero */\n> + fails += quantizedCheck( 0.008f, 0b0000'0000001, 0.0078125f); /* +1 step */\n> + fails += quantizedCheck( 7.992f, 0b0111'1111111, 7.99219f); /* Max */\n> +\n> + /* Retain additional tests from original testFixedPoint() */\n> + fails += quantizedCheck( 0.2f, 0b0000'0011010, 0.203125f); /* 0x01a */\n> + fails += quantizedCheck(-0.2f, 0b1111'1100110, -0.203125f); /* 0x7e6 */\n> + fails += quantizedCheck(-0.8f, 0b1111'0011010, -0.796875f); /* 0x79a */\n> + fails += quantizedCheck(-0.4f, 0b1111'1001101, -0.398438f); /* 0x7cd */\n> + fails += quantizedCheck(-1.4f, 0b1110'1001101, -1.39844f); /* 0x74d */\n> +\n> /* Q12.4(-2048 .. 2047.94) Min: [0x8000:-2048] -- Max: [0x7fff:2047.94] Step:0.0625 */\n> introduce(\"Q12_4\");\n> fails += quantizedCheck(0.0f, 0b000000000000'0000, 0.0f);\n> -- \n> 2.51.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF9B4BD80A\n\tfor ;\n\tTue, 18 Nov 2025 12:38:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C1A660AA0;\n\tTue, 18 Nov 2025 13:38:43 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B10B606D5\n\tfor ;\n\tTue, 18 Nov 2025 13:38:41 +0100 (CET)","from thinkpad.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CE59FD52;\n\tTue, 18 Nov 2025 13:36:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ah463VsX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763469397;\n\tbh=i/BSIgx51LmwUaoPlkiOgLKrr6gvWX2qkFSmjxyXI+g=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Ah463VsXungBrhHR/VeY37CjWnS2hlayzmQBysexNGlxKl311G4HkVWSKvcmFW3jX\n\tPHeRz3b/yGa3FUVAY/SX9rsyJ8IkW7XtX9PE5uQYLzEbLRRh9377R1Gstpugu4nWp1\n\tJq3SZUZRoj185wQrTw3qFZElrNPy9A5Bgnr16Zcg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251114005428.90024-7-kieran.bingham@ideasonboard.com>","References":"<20251114005428.90024-1-kieran.bingham@ideasonboard.com>\n\t<20251114005428.90024-7-kieran.bingham@ideasonboard.com>","Subject":"Re: [PATCH v4 06/21] test: libipa: Add Q4.7 type and tests to match\n\texisting use case tests","From":"Isaac Scott ","Cc":"Kieran Bingham ","To":"Kieran Bingham ,\n\tlibcamera devel ","Date":"Tue, 18 Nov 2025 12:38:38 +0000","Message-ID":"<176346951878.880260.11423236214199652326@isaac-ThinkPad-T16-Gen-2>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]