{"id":25036,"url":"https://patchwork.libcamera.org/api/patches/25036/?format=json","web_url":"https://patchwork.libcamera.org/patch/25036/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251114005428.90024-7-kieran.bingham@ideasonboard.com>","date":"2025-11-14T00:54:10","name":"[v4,06/21] test: libipa: Add Q4.7 type and tests to match existing use case tests","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d1de8338d499df06b45cf2eb15551b5f667e35c0","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25036/mbox/","series":[{"id":5589,"url":"https://patchwork.libcamera.org/api/series/5589/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5589","date":"2025-11-14T00:54:04","name":"libipa: Introduce a Quantized type","version":4,"mbox":"https://patchwork.libcamera.org/series/5589/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25036/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25036/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C4FDBC32DC\n\tfor ;\n\tFri, 14 Nov 2025 00:55:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 598BF60B0B;\n\tFri, 14 Nov 2025 01:54:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C33160A9D\n\tfor ;\n\tFri, 14 Nov 2025 01:54:50 +0100 (CET)","from charm.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 886A51ADF;\n\tFri, 14 Nov 2025 01:52:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rsCgRSrH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763081569;\n\tbh=S7W+F4U77Cj+CteLPKx3s8t6Hevdo98NcKTO5qf8Ql8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rsCgRSrH4l1zNa51u6dmve+8UMohJ9VN7mOFFJhSm6YnZ8xRDwR8FqB/GLk2+Ikuo\n\t22Bq7s+bNMNq3peqzSWATW8emj4MX/292t1ftq19hpmwAVeOdRXaao2ZbVp2UPPRzQ\n\tGEkVLu4s7H6LcDLsdSpbzjxVyTv4/1bJrFqLcGcY=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham ","Subject":"[PATCH v4 06/21] test: libipa: Add Q4.7 type and tests to match\n\texisting use case tests","Date":"Fri, 14 Nov 2025 00:54:10 +0000","Message-ID":"<20251114005428.90024-7-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.51.1","In-Reply-To":"<20251114005428.90024-1-kieran.bingham@ideasonboard.com>","References":"<20251114005428.90024-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The existing fixed point test cases utilise a signed Q4.7 format. Add\nmatching tests covering the same values and extend to validate the full\ntype.\n\nSigned-off-by: Kieran Bingham \n\n---\nv4:\n- Remove redundant \"No Sign Extension\" comment\n\n test/ipa/libipa/fixedpoint.cpp | 18 ++++++++++++++++++\n 1 file changed, 18 insertions(+)","diff":"diff --git a/test/ipa/libipa/fixedpoint.cpp b/test/ipa/libipa/fixedpoint.cpp\nindex 3f2d9ac97fe5..338571e38f68 100644\n--- a/test/ipa/libipa/fixedpoint.cpp\n+++ b/test/ipa/libipa/fixedpoint.cpp\n@@ -20,6 +20,9 @@ using namespace std;\n using namespace libcamera;\n using namespace ipa;\n \n+/* Q4_7(-8 .. 7.99219) Min: [0x0400:-8] -- Max: [0x03ff:7.99219] Step:0.0078125 */\n+using Q4_7 = Quantized>;\n+\n class FixedPointUtilsTest : public Test\n {\n protected:\n@@ -172,6 +175,21 @@ protected:\n \t\tfails += quantizedCheck(1.0f, 0b1'0000000, 1.0f);\t\t/* Mid */\n \t\tfails += quantizedCheck(1.992f, 0b1'1111111, 1.99219f);\t\t/* Max */\n \n+\t\t/* Q4_7(-8 .. 7.99219) Min: [0x0400:-8] -- Max: [0x03ff:7.99219] Step:0.0078125 */\n+\t\tintroduce(\"Q4_7\");\n+\t\tfails += quantizedCheck(-8.0f, 0b1000'0000000, -8.0f);\t\t/* Min */\n+\t\tfails += quantizedCheck(-0.008f, 0b1111'1111111, -0.0078125);\t/* -1 step */\n+\t\tfails += quantizedCheck( 0.0f, 0b0000'0000000, 0.0f);\t\t/* Zero */\n+\t\tfails += quantizedCheck( 0.008f, 0b0000'0000001, 0.0078125f);\t/* +1 step */\n+\t\tfails += quantizedCheck( 7.992f, 0b0111'1111111, 7.99219f);\t/* Max */\n+\n+\t\t/* Retain additional tests from original testFixedPoint() */\n+\t\tfails += quantizedCheck( 0.2f, 0b0000'0011010, 0.203125f);\t/* 0x01a */\n+\t\tfails += quantizedCheck(-0.2f, 0b1111'1100110, -0.203125f);\t/* 0x7e6 */\n+\t\tfails += quantizedCheck(-0.8f, 0b1111'0011010, -0.796875f);\t/* 0x79a */\n+\t\tfails += quantizedCheck(-0.4f, 0b1111'1001101, -0.398438f);\t/* 0x7cd */\n+\t\tfails += quantizedCheck(-1.4f, 0b1110'1001101, -1.39844f);\t/* 0x74d */\n+\n \t\t/* Q12.4(-2048 .. 2047.94) Min: [0x8000:-2048] -- Max: [0x7fff:2047.94] Step:0.0625 */\n \t\tintroduce(\"Q12_4\");\n \t\tfails += quantizedCheck(0.0f, 0b000000000000'0000, 0.0f);\n","prefixes":["v4","06/21"]}