[{"id":3364,"web_url":"https://patchwork.libcamera.org/comment/3364/","msgid":"<20200107190407.GI533370@oden.dyn.berto.se>","date":"2020-01-07T19:04:07","subject":"Re: [libcamera-devel] [PATCH 07/14] libcamera: bound_method: Store\n\tmethod arguments in a class","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-01-04 07:09:40 +0200, Laurent Pinchart wrote:\n> Create a new BoundMethodPack class to replace the PackType type alias.\n> This will allow adding additional fields to the arguments pack, when\n> adding support for propagation of bound method return values.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> Documentation/Doxyfile.in | 1 +\n> include/libcamera/bound_method.h | 21 +++++++++++++++++----\n> 2 files changed, 18 insertions(+), 4 deletions(-)\n> \n> diff --git a/Documentation/Doxyfile.in b/Documentation/Doxyfile.in\n> index 840c1b4c76c5..9e5efae33919 100644\n> --- a/Documentation/Doxyfile.in\n> +++ b/Documentation/Doxyfile.in\n> @@ -873,6 +873,7 @@ EXCLUDE_PATTERNS =\n> EXCLUDE_SYMBOLS = libcamera::BoundMemberMethod \\\n> libcamera::BoundMethodArgs \\\n> libcamera::BoundMethodBase \\\n> + libcamera::BoundMethodPack \\\n> libcamera::BoundStaticMethod \\\n> libcamera::SignalBase \\\n> std::*\n> diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\n> index 9fd58c69a0e9..d194cd4133bb 100644\n> --- a/include/libcamera/bound_method.h\n> +++ b/include/libcamera/bound_method.h\n> @@ -67,17 +67,30 @@ private:\n> \tConnectionType connectionType_;\n> };\n> \n> +template\n> +class BoundMethodPack\n> +{\n> +public:\n> +\tBoundMethodPack(const Args &... args)\n> +\t\t: args_(args...)\n> +\t{\n> +\t}\n> +\n> +\tstd::tuple::type...> args_;\n> +};\n> +\n> template\n> class BoundMethodArgs : public BoundMethodBase\n> {\n> -private:\n> -\tusing PackType = std::tuple::type...>;\n> +public:\n> +\tusing PackType = BoundMethodPack;\n> \n> +private:\n> \ttemplate\n> \tvoid invokePack(void *pack, BoundMethodBase::sequence)\n> \t{\n> \t\tPackType *args = static_cast(pack);\n> -\t\tinvoke(std::get(*args)...);\n> +\t\tinvoke(std::get(args->args_)...);\n> \t\tdelete args;\n> \t}\n> \n> @@ -98,7 +111,7 @@ template\n> class BoundMemberMethod : public BoundMethodArgs\n> {\n> public:\n> -\tusing PackType = std::tuple::type...>;\n> +\tusing PackType = typename BoundMethodArgs::PackType;\n> \n> \tBoundMemberMethod(T *obj, Object *object, void (T::*func)(Args...),\n> \t\t\t ConnectionType type = ConnectionTypeAuto)\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5466C6063B\n\tfor ;\n\tTue, 7 Jan 2020 20:04:09 +0100 (CET)","by mail-lj1-x244.google.com with SMTP id y6so736432lji.0\n\tfor ;\n\tTue, 07 Jan 2020 11:04:09 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\ts13sm216660lje.35.2020.01.07.11.04.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 07 Jan 2020 11:04:08 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=mdlUndle1Xx1rb4czImFRBpcx0cciU60GftWePQwQyY=;\n\tb=Ff6ANnNVFIDzZM7BzjQ9JB5D1SjOn4aZW93gf1IstW5Ok87hpWiF2UxRtxOOoYb90U\n\tPh39FauDc7KvTKHZUSA9yOKv3Vd4Cvtr1BA3lskC5nYGz+UlpwdO8lXx5sBGEV81ZnPe\n\t/JZm2mErfUWY5417HEoA24X/R2KgxTJCiErN4CHc1q/f5UR4tquWYV8mR/BQM7bSsbZh\n\t67vKdHzaOO/nt4NaSJ/vAt4OKmG3JrnSItXLoD/5os76/blNE27Vy1oAdsETmmBu1rEm\n\tWZ/NnPLOFxIb9JGQYdu7ht/3aYL05+GSKBkQ+Dk9MUU8XjIIiLVqq5TA98vzXqNPCEiZ\n\t71Kw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=mdlUndle1Xx1rb4czImFRBpcx0cciU60GftWePQwQyY=;\n\tb=REOQZPaKREX5ujgg7LuCJ4lv0Ibef1Tb4/Chyv9SP+XXQhLX2lQh/egx8Yx65Dsi9P\n\tQZnDoSzmTGEFu0GRJ3rbcA9OShn+iu8Yn/aIeOuH/dlOdJL3/+f1oJQjc9Hkh6GXxk6E\n\t3qDpIMDyWa4jr+WT6RTDBR1eaz0nEP7stAHezw8kBeslRYpuMAHQrtYInTWJO+DrrYfU\n\t6JOPBaBOG7Wg1Q+nKYHzMFjQgVUxqJfELFL/jJwxY3O6AkHJl1am/5pDRjWLv3UssujE\n\tvGHdnavzVw6Kp3KoqVSigBwrnFEc2cWmbUkCyNIkKfBbQxlsPfGA+GboaRKrHKEv3Xx5\n\tel9A==","X-Gm-Message-State":"APjAAAXlYfXarjnNbwNGyffBAmjK9jUQ55IqsW2QYyK+dU0YTaSEjiHh\n\tAkXT/W5i4vmGtYbbea3VEdbtNg==","X-Google-Smtp-Source":"APXvYqyojUG1HLNSb9mVZ4QXMV9V26d2QV9LO5wKrSjIdEtHYG5uPcKqjhAOI5A0vSNDBvJk/c9NyQ==","X-Received":"by 2002:a2e:8797:: with SMTP id n23mr547814lji.176.1578423848824;\n\tTue, 07 Jan 2020 11:04:08 -0800 (PST)","Date":"Tue, 7 Jan 2020 20:04:07 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200107190407.GI533370@oden.dyn.berto.se>","References":"<20200104050947.7673-1-laurent.pinchart@ideasonboard.com>\n\t<20200104050947.7673-8-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200104050947.7673-8-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 07/14] libcamera: bound_method: Store\n\tmethod arguments in a class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 07 Jan 2020 19:04:09 -0000"}}]