{"id":25029,"url":"https://patchwork.libcamera.org/api/patches/25029/?format=json","web_url":"https://patchwork.libcamera.org/patch/25029/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251113135840.610653-1-barnabas.pocze@ideasonboard.com>","date":"2025-11-13T13:58:40","name":"[v1] gstreamer: allocator: Remove use of `g_once_init_*()`","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"bac888481e310ef4a7c10fb7e2848b942e409727","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25029/mbox/","series":[{"id":5588,"url":"https://patchwork.libcamera.org/api/series/5588/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5588","date":"2025-11-13T13:58:40","name":"[v1] gstreamer: allocator: Remove use of `g_once_init_*()`","version":1,"mbox":"https://patchwork.libcamera.org/series/5588/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25029/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25029/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DCC1EC3241\n\tfor ;\n\tThu, 13 Nov 2025 13:58:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B476260A8B;\n\tThu, 13 Nov 2025 14:58:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C982960805\n\tfor ;\n\tThu, 13 Nov 2025 14:58:43 +0100 (CET)","from pb-laptop.local (185.221.140.239.nat.pool.zt.hu\n\t[185.221.140.239])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E243446;\n\tThu, 13 Nov 2025 14:56:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gumHmM/d\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763042203;\n\tbh=+nx0ATjEZzJ4GKE51fEjyqffVAH2f6nDaiUQuI5/Rd8=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=gumHmM/dXH5L2gVb2KYo75B+BgqSFWAJ9M3XS3chlJkvGmPTlo5a2ejW19hvLHxIA\n\tkUfrC3IHUkLzoqVhv0J57Pt2fRrYko+TEYbxddMOFdH+9OM4fkXXfmwO1uOm7iTB7Q\n\t1PWN0kO0MFGpJisvVxZafL0XqnwpMR2LfEQ9MVoA=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Laurent Pinchart ,\n\tNicolas Dufresne ","Subject":"[PATCH v1] gstreamer: allocator: Remove use of `g_once_init_*()`","Date":"Thu, 13 Nov 2025 14:58:40 +0100","Message-ID":"<20251113135840.610653-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.51.2","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"`g_once_init_enter()` can trigger `-Wvolatile` in certain configurations,\nso replace it by just a normal initialization since the required\nsynchronization is guaranteed since C++11. Additionally, switch to\nusing `g_quark_from_static_string()` since a string literal is used.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/gstreamer/gstlibcameraallocator.cpp | 7 +------\n 1 file changed, 1 insertion(+), 6 deletions(-)","diff":"diff --git a/src/gstreamer/gstlibcameraallocator.cpp b/src/gstreamer/gstlibcameraallocator.cpp\nindex d4492d994b..164f16b1be 100644\n--- a/src/gstreamer/gstlibcameraallocator.cpp\n+++ b/src/gstreamer/gstlibcameraallocator.cpp\n@@ -76,12 +76,7 @@ FrameWrap::~FrameWrap()\n \n GQuark FrameWrap::getQuark()\n {\n-\tstatic gsize frame_quark = 0;\n-\n-\tif (g_once_init_enter(&frame_quark)) {\n-\t\tGQuark quark = g_quark_from_string(\"GstLibcameraFrameWrap\");\n-\t\tg_once_init_leave(&frame_quark, quark);\n-\t}\n+\tstatic const GQuark frame_quark = g_quark_from_static_string(\"GstLibcameraFrameWrap\");\n \n \treturn frame_quark;\n }\n","prefixes":["v1"]}