[{"id":3363,"web_url":"https://patchwork.libcamera.org/comment/3363/","msgid":"<20200107190254.GH533370@oden.dyn.berto.se>","date":"2020-01-07T19:02:54","subject":"Re: [libcamera-devel] [PATCH 06/14] libcamera: bound_method: Move\n\tsequence and generator to BoundMethodBase","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-01-04 07:09:39 +0200, Laurent Pinchart wrote:\n> The sequence and generator member types of BoundMethodArgs are not\n> dependent on the template arguments of BoundMethodArgs. To prepare for\n> template specialization of BoundMethodArgs and avoid code duplication,\n> move them to the BoundMethodBase class.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/bound_method.h | 30 +++++++++++++++---------------\n> 1 file changed, 15 insertions(+), 15 deletions(-)\n> \n> diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\n> index a1541212ff3d..9fd58c69a0e9 100644\n> --- a/include/libcamera/bound_method.h\n> +++ b/include/libcamera/bound_method.h\n> @@ -39,19 +39,6 @@ public:\n> \tvirtual void invokePack(void *pack) = 0;\n> \n> protected:\n> -\tvoid activatePack(void *pack, bool deleteMethod);\n> -\n> -\tvoid *obj_;\n> -\tObject *object_;\n> -\n> -private:\n> -\tConnectionType connectionType_;\n> -};\n> -\n> -template\n> -class BoundMethodArgs : public BoundMethodBase\n> -{\n> -private:\n> #ifndef __DOXYGEN__\n> \t/*\n> \t * This is a cheap partial implementation of std::integer_sequence<>\n> @@ -71,10 +58,23 @@ private:\n> \t};\n> #endif\n> \n> +\tvoid activatePack(void *pack, bool deleteMethod);\n> +\n> +\tvoid *obj_;\n> +\tObject *object_;\n> +\n> +private:\n> +\tConnectionType connectionType_;\n> +};\n> +\n> +template\n> +class BoundMethodArgs : public BoundMethodBase\n> +{\n> +private:\n> \tusing PackType = std::tuple::type...>;\n> \n> \ttemplate\n> -\tvoid invokePack(void *pack, sequence)\n> +\tvoid invokePack(void *pack, BoundMethodBase::sequence)\n> \t{\n> \t\tPackType *args = static_cast(pack);\n> \t\tinvoke(std::get(*args)...);\n> @@ -87,7 +87,7 @@ public:\n> \n> \tvoid invokePack(void *pack) override\n> \t{\n> -\t\tinvokePack(pack, typename generator::type());\n> +\t\tinvokePack(pack, typename BoundMethodBase::generator::type());\n> \t}\n> \n> \tvirtual void activate(Args... args, bool deleteMethod = false) = 0;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C60876063B\n\tfor ;\n\tTue, 7 Jan 2020 20:02:55 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id j1so714718lja.2\n\tfor ;\n\tTue, 07 Jan 2020 11:02:55 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tw6sm254175lfq.95.2020.01.07.11.02.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 07 Jan 2020 11:02:54 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=D64NyhGR8UtYPZZiJiiEELVRUnwz1Uml9Lc1AOaEUTg=;\n\tb=h2XdkKdxXiIzhusjkKBeYvind9t5/rJvl0rZYX+TJNTlt32/C2EpG1E21iL6IkQun1\n\taR/Y1pM9OX1FLDi3zZ3m3/X6bFkEO3iAat2hECNqnUoajfI/tUh383baIVaqeBjriU1a\n\tcP0nKELZSpRT706sLxaIFgIR4jAo8YN0Xpo3EqDrnpFIkjDWdGVz0rjTq4t/qkxhnR3c\n\ty6Q200JPT6qHsmQ8sAH8ppQUqbiGaNhj0nZbwrIjKwIYfm+PqYiOCBFE26Z6RidnyOlU\n\txP+H+Iko10BoZO1kVcd0b3RondnkopWHCANmEOwdngg2LPr6j2ujM1S4jQhxo92BhJ9T\n\tqOeQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=D64NyhGR8UtYPZZiJiiEELVRUnwz1Uml9Lc1AOaEUTg=;\n\tb=luXYe4aQd82hhMWB49vvIIQxvDnrDvFawiIbPday8fQ1s13Zc6BVh5JTvYqxLMsnfO\n\tOQWT6SgFUlFfy5ixuFNCtJXpQj4Y7ch7Fvh3i8+Z+YbPM5On243iJC/wUr2cPDQuG142\n\tGYxPW6U5KtUXUEGl6MZE5gAukkaI/aeh6Q89RgefLrMDMP1ugr3fZGJTqfKxAEy9gKQw\n\tp4CC6+HuYkqJx9PCq5Tvq+46j+1r5ovpNazbVyS2bCzopT6tdoVXtYRHLRY45XaansTm\n\t51Dgpg/kpVrJ4b+b2450/mTEC6ne+B2mXbavFqLAB+zxNzz5ubi5ehzh3VjxhXkw2BMU\n\tigWA==","X-Gm-Message-State":"APjAAAWFIwuvoHet50EI0rpylKv0EgbbR5IYlWRtceCFqtLE68/ixYbH\n\toeN7iW6inDnuO6OkNAwdcPfFShsenFuczw==","X-Google-Smtp-Source":"APXvYqy3yiHcvmzZUIfluFSRJA2q29d6it2HDGe1lj33OILTGCvixs/fTCwiqvdsuaPYmlSKltcRJg==","X-Received":"by 2002:a05:651c:1b3:: with SMTP id\n\tc19mr572902ljn.115.1578423775106; \n\tTue, 07 Jan 2020 11:02:55 -0800 (PST)","Date":"Tue, 7 Jan 2020 20:02:54 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200107190254.GH533370@oden.dyn.berto.se>","References":"<20200104050947.7673-1-laurent.pinchart@ideasonboard.com>\n\t<20200104050947.7673-7-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200104050947.7673-7-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 06/14] libcamera: bound_method: Move\n\tsequence and generator to BoundMethodBase","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 07 Jan 2020 19:02:55 -0000"}}]