[{"id":3362,"web_url":"https://patchwork.libcamera.org/comment/3362/","msgid":"<20200107190113.GG533370@oden.dyn.berto.se>","date":"2020-01-07T19:01:13","subject":"Re: [libcamera-devel] [PATCH 05/14] libcamera: bound_method: Drop\n\tunused BoundMethodBase::connectionType()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-01-04 07:09:38 +0200, Laurent Pinchart wrote:\n> The BoundMethodBase::connectionType() method isn't used, drop it. While\n> it at make the connectionType_ member private as it is only used by the\n> class.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/bound_method.h | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\n> index f23b17c7dd98..a1541212ff3d 100644\n> --- a/include/libcamera/bound_method.h\n> +++ b/include/libcamera/bound_method.h\n> @@ -35,7 +35,6 @@ public:\n> \tbool match(Object *object) { return object == object_; }\n> \n> \tObject *object() const { return object_; }\n> -\tConnectionType connectionType() const { return connectionType_; }\n> \n> \tvirtual void invokePack(void *pack) = 0;\n> \n> @@ -44,6 +43,8 @@ protected:\n> \n> \tvoid *obj_;\n> \tObject *object_;\n> +\n> +private:\n> \tConnectionType connectionType_;\n> };\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B2326063B\n\tfor ;\n\tTue, 7 Jan 2020 20:01:15 +0100 (CET)","by mail-lf1-x144.google.com with SMTP id 15so538619lfr.2\n\tfor ;\n\tTue, 07 Jan 2020 11:01:15 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tp26sm260501lfh.64.2020.01.07.11.01.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 07 Jan 2020 11:01:13 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=Y9J+gZ5aAcO+TdspYsMix2AhuLlboBA1ZOpVMFudpoI=;\n\tb=fIVoR6v+UAwS3gKGiYjXcugegMLOoOjGIMBAh00BmpHf5Qf01mJX63RnRHzylYZPJk\n\tKJc8JtdSmWq7x2pfNqKb/7qBaDLLs10HVoUJ2tl9PfVt0q3sAmbwsITGPQ5ikEDTjQCE\n\teytQBh6JBflBBIywCRMHSgPk2JI+YSMmK8BXa1UUQM4m1n1a/E+Exa+kZE716KnN/CTU\n\tlAhf74iMu1lA8UucJu9bz54sSYR9rEvyhKBjPMDp9tIL1fXqWlbupnMcvUWSm2IjwpWD\n\trK6jPvmD2GG8wxQ59/FdsegRMLzc+cWuALqMOATGeMJoja8Leh5cn+ovAkEwDCVyTvxe\n\tHLIw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=Y9J+gZ5aAcO+TdspYsMix2AhuLlboBA1ZOpVMFudpoI=;\n\tb=N9Be0+NBBiQcOzi+B7D4otUpAaPKhXAmAXpuAe1LfpeFj+Y8/xWQ8NJb0QD6V2+Fwl\n\tMW6kT8FU1Eg92cuL5T3Q3wlFEUhuldN/pZzKVo8h/D2g4EsCsDUBIZzdKG1glinx8SdQ\n\txyCmWBf703nwTx6WftceE4b6IeKyv1ebwNaskVgARrTECSHCG+QNvbI171OPUT5gv9mY\n\t0O2aQJHU+Q9jlWMzAaavOatKU0mWz+mDBN5V0oO8b0Pr2kL6/GSotX3g6OUtq6PViNQT\n\tifBjYwhu06Gy1o07eZ2AEA3N6Frg4pDjeNnWYbY4aDssNpRZsbwvn3r4cqRqxCPkzxXO\n\tB+Yw==","X-Gm-Message-State":"APjAAAXdQpq58fiVdclhMGaetLb1+v0Kdaw6LBfwIeiOWEL0XyUkLl41\n\tilNKg0MJ0RmP8Lb7WJ9tflvwEw==","X-Google-Smtp-Source":"APXvYqwN6yQZgTVXKf7gBGq3tDXVz5CMBOIjnN9QMl73Kl2aTF+zZR9b7K3J84KGgFWmMPGtiIT/0g==","X-Received":"by 2002:a19:4351:: with SMTP id m17mr560995lfj.61.1578423674149; \n\tTue, 07 Jan 2020 11:01:14 -0800 (PST)","Date":"Tue, 7 Jan 2020 20:01:13 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200107190113.GG533370@oden.dyn.berto.se>","References":"<20200104050947.7673-1-laurent.pinchart@ideasonboard.com>\n\t<20200104050947.7673-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200104050947.7673-6-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 05/14] libcamera: bound_method: Drop\n\tunused BoundMethodBase::connectionType()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 07 Jan 2020 19:01:15 -0000"}}]