{"id":2501,"url":"https://patchwork.libcamera.org/api/patches/2501/?format=json","web_url":"https://patchwork.libcamera.org/patch/2501/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200104050947.7673-6-laurent.pinchart@ideasonboard.com>","date":"2020-01-04T05:09:38","name":"[libcamera-devel,05/14] libcamera: bound_method: Drop unused BoundMethodBase::connectionType()","commit_ref":"9fe225a79fe1f3a3b63c7064bba5e1920974effd","pull_url":null,"state":"accepted","archived":false,"hash":"8af03d92a5441857aa23d506c1c049d32e91f423","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2501/mbox/","series":[{"id":600,"url":"https://patchwork.libcamera.org/api/series/600/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=600","date":"2020-01-04T05:09:33","name":"object: Propagate return value of invoked method","version":1,"mbox":"https://patchwork.libcamera.org/series/600/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2501/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2501/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 98C5060466\n\tfor ;\n\tSat, 4 Jan 2020 06:10:04 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 32245A49\n\tfor ;\n\tSat, 4 Jan 2020 06:10:04 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1578114604;\n\tbh=x364z7FBmwdlMhCMITkp8M8WEN2FwwItMd5D6b6058w=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=ofraQdrCGnkX0gQAisRVgLyvHP76cGUe18VdH8jJq7My/ByE2HcdEZj3UVdzSgSgL\n\tTW2u8h0BGNUfo1xIIPUzfWjtKy02eM3+Fqmrc4ULOj0L66O7YWrRiw9D0SkGJm+B3K\n\tw9J13ABFTSaB2PMhipYBVHpQLAJ4RX0fhi5EXw9M=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 4 Jan 2020 07:09:38 +0200","Message-Id":"<20200104050947.7673-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200104050947.7673-1-laurent.pinchart@ideasonboard.com>","References":"<20200104050947.7673-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 05/14] libcamera: bound_method: Drop\n\tunused BoundMethodBase::connectionType()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 04 Jan 2020 05:10:04 -0000"},"content":"The BoundMethodBase::connectionType() method isn't used, drop it. While\nit at make the connectionType_ member private as it is only used by the\nclass.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/bound_method.h | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\nindex f23b17c7dd98..a1541212ff3d 100644\n--- a/include/libcamera/bound_method.h\n+++ b/include/libcamera/bound_method.h\n@@ -35,7 +35,6 @@ public:\n \tbool match(Object *object) { return object == object_; }\n \n \tObject *object() const { return object_; }\n-\tConnectionType connectionType() const { return connectionType_; }\n \n \tvirtual void invokePack(void *pack) = 0;\n \n@@ -44,6 +43,8 @@ protected:\n \n \tvoid *obj_;\n \tObject *object_;\n+\n+private:\n \tConnectionType connectionType_;\n };\n \n","prefixes":["libcamera-devel","05/14"]}