{"id":25003,"url":"https://patchwork.libcamera.org/api/patches/25003/?format=json","web_url":"https://patchwork.libcamera.org/patch/25003/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251112082715.17823-6-mzamazal@redhat.com>","date":"2025-11-12T08:27:13","name":"[RFC,5/7] libcamera: ipa: simple: Introduce a general correction matrix","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b6eaf41e9e66ead88be76356a229fbf4ec4bd31e","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25003/mbox/","series":[{"id":5582,"url":"https://patchwork.libcamera.org/api/series/5582/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5582","date":"2025-11-12T08:27:08","name":"Simple pipeline IPA cleanup","version":1,"mbox":"https://patchwork.libcamera.org/series/5582/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25003/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25003/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EEFAAC32DB\n\tfor ;\n\tWed, 12 Nov 2025 08:27:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 58C3F60AA1;\n\tWed, 12 Nov 2025 09:27:36 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B278C60A8A\n\tfor ;\n\tWed, 12 Nov 2025 09:27:32 +0100 (CET)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-692-3uao4zJzMguN3TnRciv4SQ-1;\n\tWed, 12 Nov 2025 03:27:30 -0500","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.93])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 87E2718001FE for ;\n\tWed, 12 Nov 2025 08:27:29 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.33.149])\n\tby mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 54ED11800872; Wed, 12 Nov 2025 08:27:28 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Sm7sN1CT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1762936051;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=NNsPcsRF9u7DUssA+mlF7TlhOIJYP1/loldQ9u+0kzA=;\n\tb=Sm7sN1CTQcZ0jwHtMrMjHvOGYIadZuzf/n6thZ10MKFmKYPzuCnZj4vLjyhyprlhgwEaa1\n\tlQy3w2oFUSFV8KrdDnQBkc2L23eg6BlzmVhEU2f6ScKjzlFi2vg69jbYcN7bu5IgCUUJw3\n\tPK/Jz6y8NjMt6QLWHaR8bPkhNVoHVGk=","X-MC-Unique":"3uao4zJzMguN3TnRciv4SQ-1","X-Mimecast-MFC-AGG-ID":"3uao4zJzMguN3TnRciv4SQ_1762936049","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ","Subject":"[RFC PATCH 5/7] libcamera: ipa: simple: Introduce a general\n\tcorrection matrix","Date":"Wed, 12 Nov 2025 09:27:13 +0100","Message-ID":"<20251112082715.17823-6-mzamazal@redhat.com>","In-Reply-To":"<20251112082715.17823-1-mzamazal@redhat.com>","References":"<20251112082715.17823-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"GN_czdKybibUliPEV84-MCB-B4CHiLY5QWCniM8ioos_1762936049","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Let's introduce IPAActiveState::correctionMatrix that is separate from\nIPAActiveState::ccm and represents the overall correction matrix, not\nonly the sensor colour correction matrix.\n\nIPAActiveState::ccm still includes everything; this is changed in the\nfollowup patch.\n\nSigned-off-by: Milan Zamazal \n---\n src/ipa/simple/algorithms/ccm.cpp | 1 +\n src/ipa/simple/algorithms/lut.cpp | 2 +-\n src/ipa/simple/ipa_context.h | 1 +\n 3 files changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/simple/algorithms/ccm.cpp b/src/ipa/simple/algorithms/ccm.cpp\nindex e05e5bc28..3e9528a91 100644\n--- a/src/ipa/simple/algorithms/ccm.cpp\n+++ b/src/ipa/simple/algorithms/ccm.cpp\n@@ -104,6 +104,7 @@ void Ccm::prepare(IPAContext &context, const uint32_t frame,\n \tif (saturation)\n \t\tapplySaturation(ccm, saturation.value());\n \n+\tcontext.activeState.correctionMatrix = ccm;\n \tcontext.activeState.ccm = ccm;\n \tframeContext.saturation = saturation;\n \tcontext.activeState.matrixChanged = true;\ndiff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex b27491042..8751bb31c 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -123,7 +123,7 @@ void Lut::prepare(IPAContext &context,\n \t\tMatrix gainMatrix = { { gains.r(), 0, 0,\n \t\t\t\t\t\t 0, gains.g(), 0,\n \t\t\t\t\t\t 0, 0, gains.b() } };\n-\t\tauto matrix = context.activeState.ccm * gainMatrix;\n+\t\tauto matrix = context.activeState.correctionMatrix * gainMatrix;\n \t\tauto &red = params->redCcm;\n \t\tauto &green = params->greenCcm;\n \t\tauto &blue = params->blueCcm;\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex b6b3cbfed..14680c726 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -61,6 +61,7 @@ struct IPAActiveState {\n \t} gamma;\n \n \tMatrix ccm;\n+\tMatrix correctionMatrix;\n \tbool matrixChanged = false;\n \n \tstruct {\n","prefixes":["RFC","5/7"]}