[{"id":3361,"web_url":"https://patchwork.libcamera.org/comment/3361/","msgid":"<20200107190039.GF533370@oden.dyn.berto.se>","date":"2020-01-07T19:00:39","subject":"Re: [libcamera-devel] [PATCH 04/14] libcamera: bound_method: Mark\n\toverriden methods with override","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-01-04 07:09:37 +0200, Laurent Pinchart wrote:\n> Mark the activate() and invoke() methods with the override keyword where\n> appropriate.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/bound_method.h | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\n> index 5743cacf5388..f23b17c7dd98 100644\n> --- a/include/libcamera/bound_method.h\n> +++ b/include/libcamera/bound_method.h\n> @@ -107,7 +107,7 @@ public:\n> \n> \tbool match(void (T::*func)(Args...)) const { return func == func_; }\n> \n> -\tvoid activate(Args... args, bool deleteMethod = false)\n> +\tvoid activate(Args... args, bool deleteMethod = false) override\n> \t{\n> \t\tif (this->object_)\n> \t\t\tBoundMethodBase::activatePack(new PackType{ args... }, deleteMethod);\n> @@ -115,7 +115,7 @@ public:\n> \t\t\t(static_cast(this->obj_)->*func_)(args...);\n> \t}\n> \n> -\tvoid invoke(Args... args)\n> +\tvoid invoke(Args... args) override\n> \t{\n> \t\t(static_cast(this->obj_)->*func_)(args...);\n> \t}\n> @@ -136,12 +136,12 @@ public:\n> \n> \tbool match(void (*func)(Args...)) const { return func == func_; }\n> \n> -\tvoid activate(Args... args, bool deleteMethod = false)\n> +\tvoid activate(Args... args, bool deleteMethod = false) override\n> \t{\n> \t\t(*func_)(args...);\n> \t}\n> \n> -\tvoid invoke(Args...) {}\n> +\tvoid invoke(Args...) override {}\n> \n> private:\n> \tvoid (*func_)(Args...);\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D0B66063B\n\tfor ;\n\tTue, 7 Jan 2020 20:00:41 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id y19so505299lfl.9\n\tfor ;\n\tTue, 07 Jan 2020 11:00:41 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\ta9sm267864lfk.23.2020.01.07.11.00.39\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 07 Jan 2020 11:00:39 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=jVL7r22ilvdQ+NaAFa2dGHp/qiF4e2FMnwZbN5Fj7FQ=;\n\tb=xitQ/p+eXfYJ5WHWJaDYtcvkcNZorudxjk+efGnaeQ9Y9xSFUD/AxLpI7CZi4mIMxd\n\t4WzCPtH1JJYVJhq22iRtyIJvCjhqU95gkvL5EVmS75GssrdEIuuZo0dERn0gYLvQzFUq\n\t1wR3PEMtd5+JzkgrQuKSzqXsoRH3GZaJyJ9aPNRRq+4z7OSOv8peLQQvhUfGBAxqURKM\n\trUaxggVuAW8+iPlppCc6w2dFIbX1ceKyCcRbawye7b8EvhA/SqjjEQmPJ9jgxS8+LxbJ\n\tQsq2QdWw/8rjjQpPTfYI38yhMq2UAVfgt6ShcqHeNk4etlmmNUuWohnqZOZzxX8Kmkqu\n\teW9A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=jVL7r22ilvdQ+NaAFa2dGHp/qiF4e2FMnwZbN5Fj7FQ=;\n\tb=I3XD6pnbFKIg+8f4vTmFXgf6hvxfG7N7PXNnx+1HWXARMlX2M4wz+D7miL37BlsoQt\n\tupLHg7GPYCx7c4HQpGTVagR8CBpcZhQLExaCi74hyhrzHuBWyde4gADr5DWc/kpi+yUb\n\t+KsrxDq2ZBNuN6cEsFkYlfOy/9hVVz9cUBM5ADVdf53aBiHl1yZBr26k4U6uJ1Z4xIRE\n\taTdtSriUySJdAeDUOwWo1YqxzQtVZTPO/sIsodz2Cost7eJXtCvnvWPav55HD2wQLTq8\n\tZHj12y/a5JyM9oM2Cfo+p1QGCWtHXdK3Bs/PIcT4P2ZEOv2ayhE7gIYAQQptPv8dH3bg\n\tsNEA==","X-Gm-Message-State":"APjAAAV5XLI6I9CmmzpClUeES/n0B5Z6FTs7XRmXhcQNXPIPt32s2oKS\n\tBr++Xeu1NMU6Q9t3KDviFercaLaf60T1pA==","X-Google-Smtp-Source":"APXvYqwfR9EnkwHhuKGpP8dXjyq69qHE0vJgJfOt/CeOy6wk6g7swAKYX6NTIsvj9ppH2lz83xam3A==","X-Received":"by 2002:a19:c148:: with SMTP id r69mr579295lff.142.1578423640497;\n\tTue, 07 Jan 2020 11:00:40 -0800 (PST)","Date":"Tue, 7 Jan 2020 20:00:39 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200107190039.GF533370@oden.dyn.berto.se>","References":"<20200104050947.7673-1-laurent.pinchart@ideasonboard.com>\n\t<20200104050947.7673-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200104050947.7673-5-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 04/14] libcamera: bound_method: Mark\n\toverriden methods with override","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 07 Jan 2020 19:00:41 -0000"}}]