[{"id":36778,"web_url":"https://patchwork.libcamera.org/comment/36778/","msgid":"<176294020963.567526.7342009154702431117@ping.linuxembedded.co.uk>","date":"2025-11-12T09:36:49","subject":"Re: [RFC PATCH 1/7] libcamera: ipa: simple: Remove an unused include\n\tfrom awb.cpp","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2025-11-12 08:27:09)\n> is not used any more.\n> \n\nI can't see any use of std::min or std::clamp which might be used in the\nfuture but in that case it could/should be re-added then.\n\nso:\n\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Milan Zamazal \n> ---\n> src/ipa/simple/algorithms/awb.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\n> index cf78e9800..9de422519 100644\n> --- a/src/ipa/simple/algorithms/awb.cpp\n> +++ b/src/ipa/simple/algorithms/awb.cpp\n> @@ -7,7 +7,6 @@\n> \n> #include \"awb.h\"\n> \n> -#include \n> #include \n> #include \n> \n> -- \n> 2.51.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E3048C3241\n\tfor ;\n\tWed, 12 Nov 2025 09:36:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 17206609D8;\n\tWed, 12 Nov 2025 10:36:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE1BD606E6\n\tfor ;\n\tWed, 12 Nov 2025 10:36:52 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3754982E;\n\tWed, 12 Nov 2025 10:34:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QrCt1z60\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762940093;\n\tbh=OF1IjBAxf/mTWkhMAhF8ebTQi5K8fWtIc/3B45eQrQU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=QrCt1z60aJNdkrKimNl12U5xfLfYnnF2ZfFTZKOP+nn0iNGWjv5U13jCj53RZAoFO\n\tC1CirQGym2mdNxJBe9t5JrgzU6ON/8/58iNtWU5N72jqDJ7J3Jaqcci5l9uQmSRPkr\n\t40q44aqJVPCNCEZz4R9JqtbGTQlQADLyfnZzbrhU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251112082715.17823-2-mzamazal@redhat.com>","References":"<20251112082715.17823-1-mzamazal@redhat.com>\n\t<20251112082715.17823-2-mzamazal@redhat.com>","Subject":"Re: [RFC PATCH 1/7] libcamera: ipa: simple: Remove an unused include\n\tfrom awb.cpp","From":"Kieran Bingham ","Cc":"Milan Zamazal ","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Wed, 12 Nov 2025 09:36:49 +0000","Message-ID":"<176294020963.567526.7342009154702431117@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36850,"web_url":"https://patchwork.libcamera.org/comment/36850/","msgid":"","date":"2025-11-17T10:49:45","subject":"Re: [RFC PATCH 1/7] libcamera: ipa: simple: Remove an unused include\n\tfrom awb.cpp","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 11. 12. 9:27 keltezéssel, Milan Zamazal írta:\n> is not used any more.\n\nclangd also says so.\n\n\n> \n> Signed-off-by: Milan Zamazal \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/ipa/simple/algorithms/awb.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\n> index cf78e9800..9de422519 100644\n> --- a/src/ipa/simple/algorithms/awb.cpp\n> +++ b/src/ipa/simple/algorithms/awb.cpp\n> @@ -7,7 +7,6 @@\n> \n> #include \"awb.h\"\n> \n> -#include \n> #include \n> #include \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7B307BD80A\n\tfor ;\n\tMon, 17 Nov 2025 10:49:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1151960A80;\n\tMon, 17 Nov 2025 11:49:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 496B6606A0\n\tfor ;\n\tMon, 17 Nov 2025 11:49:49 +0100 (CET)","from [192.168.33.31] (185.221.143.100.nat.pool.zt.hu\n\t[185.221.143.100])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 41EEC142;\n\tMon, 17 Nov 2025 11:47:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"u/3eDVf9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763376466;\n\tbh=sKVFs3Nn7m9ZKc/obfhAfWR8aBWbyOcl88bP0UDtibo=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=u/3eDVf9dAMf+GdfoLI1Q/yQWZtHuFK8zDoJ6O9vtdJfGjH+QNmpmqKOc/s+nsjur\n\t7c7r0QeaIDaqtp19OrpL03uJQ5TyPVG5cpeJIMPmARM6NGrc1cYIShA4EWrtA/PWRN\n\t+Ii48c1pLhFrZOCm2xEiteywzt689ktuggOJGo/o=","Message-ID":"","Date":"Mon, 17 Nov 2025 11:49:45 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [RFC PATCH 1/7] libcamera: ipa: simple: Remove an unused include\n\tfrom awb.cpp","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","References":"<20251112082715.17823-1-mzamazal@redhat.com>\n\t<20251112082715.17823-2-mzamazal@redhat.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251112082715.17823-2-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]