{"id":24997,"url":"https://patchwork.libcamera.org/api/patches/24997/?format=json","web_url":"https://patchwork.libcamera.org/patch/24997/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251111-denoise_mainline_issue-v1-1-6d5db30d958f@ideasonboard.com>","date":"2025-11-11T15:59:04","name":"ipa: rkisp1: dpf: Enable strength after enable Dpf","commit_ref":"30779421e83fe67487f87fa4b2d01ed995154a81","pull_url":null,"state":"accepted","archived":false,"hash":"9949cc68414cd47c9ab947f9dae5eff29034f547","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24997/mbox/","series":[{"id":5581,"url":"https://patchwork.libcamera.org/api/series/5581/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5581","date":"2025-11-11T15:59:04","name":"ipa: rkisp1: dpf: Enable strength after enable Dpf","version":1,"mbox":"https://patchwork.libcamera.org/series/5581/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24997/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24997/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5F304C3241\n\tfor ;\n\tTue, 11 Nov 2025 15:59:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 96812606A0;\n\tTue, 11 Nov 2025 16:59:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E03B6606A0\n\tfor ;\n\tTue, 11 Nov 2025 16:59:18 +0100 (CET)","from rui-Precision-7560.local (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D67311D29;\n\tTue, 11 Nov 2025 16:57:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dFCy3/mq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762876640;\n\tbh=5NMOfndQO6ZgKUSt8tQv2JrPlmhllWLcHUguoD6JsZU=;\n\th=From:Date:Subject:To:Cc:From;\n\tb=dFCy3/mqU0o69SneidL9c/RI7mcOqI6dj5e1TXdU3bCJjWcI9HYl7SzFRH0KOCkjz\n\tvJnpdeSXqwQikYigzqBjIxsUr1bneP5eN7j77Pu1GxXEmkks9nv0u9FXLbKviyXrHq\n\tQzBp3aOuxF8w1kSy3vm/nrUsVP7MMQ05BnYjL+aE=","From":"Rui Wang ","Date":"Tue, 11 Nov 2025 10:59:04 -0500","Subject":"[PATCH] ipa: rkisp1: dpf: Enable strength after enable Dpf","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20251111-denoise_mainline_issue-v1-1-6d5db30d958f@ideasonboard.com>","X-B4-Tracking":"v=1; b=H4sIAEddE2kC/x2MQQqDMBQFryJ/3UAiEalXERExT/ug/Uo+FUG8e\n\t0NnN4uZSwyZMOmqSzIOGjctEh6VzK9JVzim4lL7ugkFl6AbDeNnor6pGGn2hVvm1qfm6X0MUUq\n\t8Zyw8/+N+uO8f+bd6h2gAAAA=","X-Change-ID":"20251111-denoise_mainline_issue-fc70d5900414","To":"libcamera-devel@lists.libcamera.org","Cc":"Rui Wang ","X-Mailer":"b4 0.14.3","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The filter strength configuration block was previously only enabled on the\nfirst frame (frame == 0). Apply the strength values when denoise is active.\nThis prevents the strength config from being disabled on subsequent frames.\n\nSigned-off-by: Rui Wang \n---\n src/ipa/rkisp1/algorithms/dpf.cpp | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)\n\n\n---\nbase-commit: 06aee9135f9fd135a8c0bc0b55971b29f7617d02\nchange-id: 20251111-denoise_mainline_issue-fc70d5900414\n\nBest regards,","diff":"diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex cb6095da..39f3e461 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -225,8 +225,12 @@ void Dpf::prepare(IPAContext &context, const uint32_t frame,\n \tauto config = params->block();\n \tconfig.setEnabled(frameContext.dpf.denoise);\n \n+\tauto strengthConfig = params->block();\n+\tstrengthConfig.setEnabled(frameContext.dpf.denoise);\n+\n \tif (frameContext.dpf.denoise) {\n \t\t*config = config_;\n+\t\t*strengthConfig = strengthConfig_;\n \n \t\tconst auto &awb = context.configuration.awb;\n \t\tconst auto &lsc = context.configuration.lsc;\n@@ -250,12 +254,6 @@ void Dpf::prepare(IPAContext &context, const uint32_t frame,\n \t\telse\n \t\t\tmode = RKISP1_CIF_ISP_DPF_GAIN_USAGE_DISABLED;\n \t}\n-\n-\tif (frame == 0) {\n-\t\tauto strengthConfig = params->block();\n-\t\tstrengthConfig.setEnabled(true);\n-\t\t*strengthConfig = strengthConfig_;\n-\t}\n }\n \n REGISTER_IPA_ALGORITHM(Dpf, \"Dpf\")\n","prefixes":[]}