[{"id":36825,"web_url":"https://patchwork.libcamera.org/comment/36825/","msgid":"<176313917205.83626.9983584234632211696@localhost>","date":"2025-11-14T16:52:52","subject":"Re: [PATCH v2] ipa: rkisp1: dpf: Enable strength after enable Dpf","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Rui,\n\nThank you for the patch.\n\nQuoting Rui Wang (2025-11-11 15:53:26)\n> The filter strength configuration block was previously only enabled on the\n> first frame (frame == 0). Apply the strength values when denoise is active.\n> This prevents the strength config from being disabled on subsequent frames.\n> \n> Signed-off-by: Rui Wang \n\nReviewed-by: Stefan Klug \n\nYou also got a reviewed-by tag from Kieran on v1. The usual process is\nto collect that (either using b4 or manually) and add it before sending\nout a v2.\n\nAdditionally a short changelog is usually added below the commit\nmessage separated by '---'. How this changelog is added depends on\npersonal preferences. I usually add it when reworking a commit which\nalso helps myself in not forgetting what I changed.\n\nCould you send a v3 just with the collected tags added?\n\nI'll then merge it to mainline.\n\nBest regards,\nStefan\n\n\n> ---\n> src/ipa/rkisp1/algorithms/dpf.cpp | 10 ++++------\n> 1 file changed, 4 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\n> index cb6095da..39f3e461 100644\n> --- a/src/ipa/rkisp1/algorithms/dpf.cpp\n> +++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n> @@ -225,8 +225,12 @@ void Dpf::prepare(IPAContext &context, const uint32_t frame,\n> auto config = params->block();\n> config.setEnabled(frameContext.dpf.denoise);\n> \n> + auto strengthConfig = params->block();\n> + strengthConfig.setEnabled(frameContext.dpf.denoise);\n> +\n> if (frameContext.dpf.denoise) {\n> *config = config_;\n> + *strengthConfig = strengthConfig_;\n> \n> const auto &awb = context.configuration.awb;\n> const auto &lsc = context.configuration.lsc;\n> @@ -250,12 +254,6 @@ void Dpf::prepare(IPAContext &context, const uint32_t frame,\n> else\n> mode = RKISP1_CIF_ISP_DPF_GAIN_USAGE_DISABLED;\n> }\n> -\n> - if (frame == 0) {\n> - auto strengthConfig = params->block();\n> - strengthConfig.setEnabled(true);\n> - *strengthConfig = strengthConfig_;\n> - }\n> }\n> \n> REGISTER_IPA_ALGORITHM(Dpf, \"Dpf\")\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF062C3241\n\tfor ;\n\tFri, 14 Nov 2025 16:52:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C8D160A8B;\n\tFri, 14 Nov 2025 17:52:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56497606E6\n\tfor ;\n\tFri, 14 Nov 2025 17:52:55 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:3cb4:651a:fe0:73ab])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 6165E664;\n\tFri, 14 Nov 2025 17:50:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HBSGVQi1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763139054;\n\tbh=K1/eS011HXfYD08Wn1GSZqiul4tLyJ1KrhlNpYhn+dM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=HBSGVQi1qsYwjO4fiMnSh8zrQOVN0/y5MRlx9TtR3KW8Da8B2sb5VoMZVQzvInbZw\n\teH7i3ZmjJRiEEH/X4BIdU78wDtaL44RVOUcldn7KUoMKuvEFj4/MaOF4ASvubRpotj\n\tbpK8g0H/TKUjN5+R8AOZtUS22lT470CqzUKMtcCc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251111145326.1194122-1-rui.wang@ideasonboard.com>","References":"<20251111145326.1194122-1-rui.wang@ideasonboard.com>","Subject":"Re: [PATCH v2] ipa: rkisp1: dpf: Enable strength after enable Dpf","From":"Stefan Klug ","Cc":"Rui Wang ","To":"Rui Wang , libcamera-devel@lists.libcamera.org","Date":"Fri, 14 Nov 2025 17:52:52 +0100","Message-ID":"<176313917205.83626.9983584234632211696@localhost>","User-Agent":"alot/0.12.dev8+g2c003385c862.d20250602","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36829,"web_url":"https://patchwork.libcamera.org/comment/36829/","msgid":"<176314213189.567526.7456948379819539377@ping.linuxembedded.co.uk>","date":"2025-11-14T17:42:11","subject":"Re: [PATCH v2] ipa: rkisp1: dpf: Enable strength after enable Dpf","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-11-14 16:52:52)\n> Hi Rui,\n> \n> Thank you for the patch.\n> \n> Quoting Rui Wang (2025-11-11 15:53:26)\n> > The filter strength configuration block was previously only enabled on the\n> > first frame (frame == 0). Apply the strength values when denoise is active.\n> > This prevents the strength config from being disabled on subsequent frames.\n> > \n> > Signed-off-by: Rui Wang \n> \n> Reviewed-by: Stefan Klug \n> \n> You also got a reviewed-by tag from Kieran on v1. The usual process is\n> to collect that (either using b4 or manually) and add it before sending\n> out a v2.\n> \n> Additionally a short changelog is usually added below the commit\n> message separated by '---'. How this changelog is added depends on\n> personal preferences. I usually add it when reworking a commit which\n> also helps myself in not forgetting what I changed.\n> \n> Could you send a v3 just with the collected tags added?\n\nIf this is just missing my tag I'll add it for patchworks sake:\n\nReviewed-by: Kieran Bingham \n\n> \n> I'll then merge it to mainline.\n> \n> Best regards,\n> Stefan\n> \n> \n> > ---\n> > src/ipa/rkisp1/algorithms/dpf.cpp | 10 ++++------\n> > 1 file changed, 4 insertions(+), 6 deletions(-)\n> > \n> > diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\n> > index cb6095da..39f3e461 100644\n> > --- a/src/ipa/rkisp1/algorithms/dpf.cpp\n> > +++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n> > @@ -225,8 +225,12 @@ void Dpf::prepare(IPAContext &context, const uint32_t frame,\n> > auto config = params->block();\n> > config.setEnabled(frameContext.dpf.denoise);\n> > \n> > + auto strengthConfig = params->block();\n> > + strengthConfig.setEnabled(frameContext.dpf.denoise);\n> > +\n> > if (frameContext.dpf.denoise) {\n> > *config = config_;\n> > + *strengthConfig = strengthConfig_;\n> > \n> > const auto &awb = context.configuration.awb;\n> > const auto &lsc = context.configuration.lsc;\n> > @@ -250,12 +254,6 @@ void Dpf::prepare(IPAContext &context, const uint32_t frame,\n> > else\n> > mode = RKISP1_CIF_ISP_DPF_GAIN_USAGE_DISABLED;\n> > }\n> > -\n> > - if (frame == 0) {\n> > - auto strengthConfig = params->block();\n> > - strengthConfig.setEnabled(true);\n> > - *strengthConfig = strengthConfig_;\n> > - }\n> > }\n> > \n> > REGISTER_IPA_ALGORITHM(Dpf, \"Dpf\")\n> > -- \n> > 2.43.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53FB3C3241\n\tfor ;\n\tFri, 14 Nov 2025 17:42:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92F1B60A80;\n\tFri, 14 Nov 2025 18:42:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 773C6606E6\n\tfor ;\n\tFri, 14 Nov 2025 18:42:14 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F1E9169;\n\tFri, 14 Nov 2025 18:40:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"adajjYXu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763142013;\n\tbh=JE8OXXvDnNt+xkzSFRw09eD2jWyGhOo/nz60fLLEMig=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=adajjYXuSDKX+6OG8Jt6Io8SdIkAAZQfyyxuxWiaImrPMzKrCMl+n1JvyHiNXK0Wq\n\tnw9y60JCwMDpfhDhbMZVpqSZFyQYIYRCGqxTeHJCmeO3cy/H9J083uLv6jNolZNNh3\n\tsQ2vzcQFygGgbqbgrn/IuLXJCQXuNwRy54Dr2pB4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<176313917205.83626.9983584234632211696@localhost>","References":"<20251111145326.1194122-1-rui.wang@ideasonboard.com>\n\t<176313917205.83626.9983584234632211696@localhost>","Subject":"Re: [PATCH v2] ipa: rkisp1: dpf: Enable strength after enable Dpf","From":"Kieran Bingham ","Cc":"Rui Wang ","To":"Rui Wang ,\n\tStefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 14 Nov 2025 17:42:11 +0000","Message-ID":"<176314213189.567526.7456948379819539377@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]