{"id":24989,"url":"https://patchwork.libcamera.org/api/patches/24989/?format=json","web_url":"https://patchwork.libcamera.org/patch/24989/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251111120015.1130493-2-rui.wang@ideasonboard.com>","date":"2025-11-11T11:59:59","name":"[v2] ipa: rkisp1: dpf: Enable strength after enable Dpf","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9949cc68414cd47c9ab947f9dae5eff29034f547","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24989/mbox/","series":[{"id":5573,"url":"https://patchwork.libcamera.org/api/series/5573/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5573","date":"2025-11-11T11:59:59","name":"[v2] ipa: rkisp1: dpf: Enable strength after enable Dpf","version":2,"mbox":"https://patchwork.libcamera.org/series/5573/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24989/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24989/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CFB9FC32DB\n\tfor ;\n\tTue, 11 Nov 2025 12:00:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78B9460A80;\n\tTue, 11 Nov 2025 13:00:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82D2C609DE\n\tfor ;\n\tTue, 11 Nov 2025 13:00:22 +0100 (CET)","from rui-Precision-7560.local (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 97F0D50A;\n\tTue, 11 Nov 2025 12:58:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y/tPZ1he\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762862304;\n\tbh=sk4RG1+0bLxU9pSX1cxGsoAR2eI44Ygk15XdXXbNKe4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Y/tPZ1heymItjkeWEqtrUft7Ym7fZ2zmNEc5Vn9ArOn2dCxJEDlrQd20BN6inHGt8\n\tkltcse7N8TKn9TzDvvO0INSKFYIuZNaMZEwHhrJthPZJZv+yjMBa3T9a3/oxwDYQ2i\n\tkTISBbl9T3FvBXodByHBAmCwwnps/Pmt9yAnYgaE=","From":"Rui Wang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Rui Wang ","Subject":"[PATCH v2] ipa: rkisp1: dpf: Enable strength after enable Dpf","Date":"Tue, 11 Nov 2025 06:59:59 -0500","Message-ID":"<20251111120015.1130493-2-rui.wang@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20251024120107.681968-1-rui.wang@ideasonboard.com>","References":"\n\t<20251024120107.681968-1-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The filter strength configuration block was previously only enabled on the\nfirst frame (frame == 0). Apply the strength values when denoise is active.\nThis prevents the strength config from being disabled on subsequent frames.\n\nSigned-off-by: Rui Wang \n---\n src/ipa/rkisp1/algorithms/dpf.cpp | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex cb6095da..39f3e461 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -225,8 +225,12 @@ void Dpf::prepare(IPAContext &context, const uint32_t frame,\n \tauto config = params->block();\n \tconfig.setEnabled(frameContext.dpf.denoise);\n \n+\tauto strengthConfig = params->block();\n+\tstrengthConfig.setEnabled(frameContext.dpf.denoise);\n+\n \tif (frameContext.dpf.denoise) {\n \t\t*config = config_;\n+\t\t*strengthConfig = strengthConfig_;\n \n \t\tconst auto &awb = context.configuration.awb;\n \t\tconst auto &lsc = context.configuration.lsc;\n@@ -250,12 +254,6 @@ void Dpf::prepare(IPAContext &context, const uint32_t frame,\n \t\telse\n \t\t\tmode = RKISP1_CIF_ISP_DPF_GAIN_USAGE_DISABLED;\n \t}\n-\n-\tif (frame == 0) {\n-\t\tauto strengthConfig = params->block();\n-\t\tstrengthConfig.setEnabled(true);\n-\t\t*strengthConfig = strengthConfig_;\n-\t}\n }\n \n REGISTER_IPA_ALGORITHM(Dpf, \"Dpf\")\n","prefixes":["v2"]}