[{"id":36767,"web_url":"https://patchwork.libcamera.org/comment/36767/","msgid":"<20251111112723.GB4270@pendragon.ideasonboard.com>","date":"2025-11-11T11:27:23","subject":"Re: [RFC PATCH v1] libcamera: pipeline: uvcvideo: Reject sensor\n\tconfiguration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Nov 11, 2025 at 10:23:19AM +0100, Barnabás Pőcze wrote:\n> The UVC pipeline handler cannot set the sensor configuration so if the\n> desired `CameraConfiguration` specifies one, then reject it.\n> \n> Signed-off-by: Barnabás Pőcze \n\nMakes sense and seems simple enough.\n\nReviewed-by: Laurent Pinchart \n\nPlease merge.\n\n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 4b5816dfdd..48d6b39d53 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -143,6 +143,9 @@ CameraConfiguration::Status UVCCameraConfiguration::validate()\n> \tif (config_.empty())\n> \t\treturn Invalid;\n> \n> +\tif (sensorConfig)\n> +\t\treturn Invalid;\n> +\n> \tif (orientation != Orientation::Rotate0) {\n> \t\torientation = Orientation::Rotate0;\n> \t\tstatus = Adjusted;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0E11C3263\n\tfor ;\n\tTue, 11 Nov 2025 11:27:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7AAD4606D5;\n\tTue, 11 Nov 2025 12:27:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C38D606A0\n\tfor ;\n\tTue, 11 Nov 2025 12:27:29 +0100 (CET)","from pendragon.ideasonboard.com (82-203-161-95.bb.dnainternet.fi\n\t[82.203.161.95])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 418C150A;\n\tTue, 11 Nov 2025 12:25:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"C4SRJGQa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762860330;\n\tbh=eS8A9v90no35bB1w0BNzYqpZr0szXUsfCPfotaARVfs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=C4SRJGQaY08ikjaQQ5CgctxcHx9M+eS+L1NjXA6h03AEqgoXZg8s/rO1nq+iS28aO\n\turPRqtO1KH883bBMFOrwmQ2YUdyS3i/12BaJuvjqU15dlY6inzZkFwQ2W33SB6Jci8\n\tDrWiEA7ZUBtApA8xxeoHDq4viC6cEdw3DlkxHSAE=","Date":"Tue, 11 Nov 2025 13:27:23 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v1] libcamera: pipeline: uvcvideo: Reject sensor\n\tconfiguration","Message-ID":"<20251111112723.GB4270@pendragon.ideasonboard.com>","References":"<20251111092319.2313234-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20251111092319.2313234-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36970,"web_url":"https://patchwork.libcamera.org/comment/36970/","msgid":"<4dnfikrim7olfcynqvsxdegajytq67nmj64x275ldsvapht5wy@hdnonsih6eyx>","date":"2025-11-21T10:20:52","subject":"Re: [RFC PATCH v1] libcamera: pipeline: uvcvideo: Reject sensor\n\tconfiguration","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Tue, Nov 11, 2025 at 10:23:19AM +0100, Barnabás Pőcze wrote:\n> The UVC pipeline handler cannot set the sensor configuration so if the\n> desired `CameraConfiguration` specifies one, then reject it.\n>\n> Signed-off-by: Barnabás Pőcze \n\nAs you correctly pointed out, applications using SensorConfiguration\nare very specialized ones that know on which platform they run on.\n\nOn UVC controlling the sensor config is not possible, so let's refuse\nit\n\nReviewed-by: Jacopo Mondi \n\n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n>\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 4b5816dfdd..48d6b39d53 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -143,6 +143,9 @@ CameraConfiguration::Status UVCCameraConfiguration::validate()\n> \tif (config_.empty())\n> \t\treturn Invalid;\n>\n> +\tif (sensorConfig)\n> +\t\treturn Invalid;\n> +\n> \tif (orientation != Orientation::Rotate0) {\n> \t\torientation = Orientation::Rotate0;\n> \t\tstatus = Adjusted;\n> --\n> 2.51.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E5AEC0F1B\n\tfor ;\n\tFri, 21 Nov 2025 10:20:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 940AC60A80;\n\tFri, 21 Nov 2025 11:20:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4FED3608CF\n\tfor ;\n\tFri, 21 Nov 2025 11:20:56 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4273A66B;\n\tFri, 21 Nov 2025 11:18:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IXTETk3C\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763720330;\n\tbh=hjEtsDrA5LWMZAHusjNScUIRW9zOjWVnLekXzJmp0r8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IXTETk3CkGFQRWS8TbC8mJ7ZLiNfo8jO2qRispOUlkDffQBfB5MBdPos5zjYmUM57\n\t1tcOAQPZnpkO9K5f3Sv7iCplSQEFgTFK/qitFnwyQ3oI4Fpmp+RPqqzLjs0vjkxNqe\n\tFZtcnvtZ7ggv7ESWlP99DCCD8P+I9JiXnHZaVtKc=","Date":"Fri, 21 Nov 2025 11:20:52 +0100","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v1] libcamera: pipeline: uvcvideo: Reject sensor\n\tconfiguration","Message-ID":"<4dnfikrim7olfcynqvsxdegajytq67nmj64x275ldsvapht5wy@hdnonsih6eyx>","References":"<20251111092319.2313234-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20251111092319.2313234-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]