{"id":24969,"url":"https://patchwork.libcamera.org/api/patches/24969/?format=json","web_url":"https://patchwork.libcamera.org/patch/24969/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251104153501.34362-3-mzamazal@redhat.com>","date":"2025-11-04T15:34:53","name":"[v15,2/8] libcamera: simple: Exclude raw configurations from output conversions","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"616c72732193c71cff33afebd9240619557dc716","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24969/mbox/","series":[{"id":5563,"url":"https://patchwork.libcamera.org/api/series/5563/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5563","date":"2025-11-04T15:34:51","name":"Enable raw streams with software ISP","version":15,"mbox":"https://patchwork.libcamera.org/series/5563/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24969/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24969/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 22B96C3241\n\tfor ;\n\tTue, 4 Nov 2025 15:35:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D472E6069A;\n\tTue, 4 Nov 2025 16:35:27 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1F366069A\n\tfor ;\n\tTue, 4 Nov 2025 16:35:25 +0100 (CET)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-671-aIoWKDi1PRWTWNUXf4NBUw-1;\n\tTue, 04 Nov 2025 10:35:21 -0500","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 17B701956052; Tue, 4 Nov 2025 15:35:20 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.225.23])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 5D95B1956056; Tue, 4 Nov 2025 15:35:16 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Cj9ECZ/W\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1762270524;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=fVMpFG1V1uCdiIcSsJX8xxdoZQZIRbLuYwk5oOZ3gtc=;\n\tb=Cj9ECZ/WDU1G+1msNQjuW2vCd3D3wJ/qX9vieCw2yvqUEnXcc4tOQlLCOOkbvCbVjnd63w\n\tPILSj6/eu03EYDgbY7bwoL0seKTH9F7Krh6bMrG3la21rrFXkmewVzKFc+c6vrVFev0HD9\n\txcENG9cNq+quJ+ddM3ho3d3Po0+6BRE=","X-MC-Unique":"aIoWKDi1PRWTWNUXf4NBUw-1","X-Mimecast-MFC-AGG-ID":"aIoWKDi1PRWTWNUXf4NBUw_1762270520","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Laurent Pinchart\n\t, Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Paul Elder\n\t, Umang Jain ","Subject":"[PATCH v15 2/8] libcamera: simple: Exclude raw configurations from\n\toutput conversions","Date":"Tue, 4 Nov 2025 16:34:53 +0100","Message-ID":"<20251104153501.34362-3-mzamazal@redhat.com>","In-Reply-To":"<20251104153501.34362-1-mzamazal@redhat.com>","References":"<20251104153501.34362-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"WsDXGA8CTxiGg5SwIVxV2qqhZtbBSVFOGKdVfJc7adI_1762270520","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In order to support raw streams, we need to add raw formats to software\nISP configurations. In this preparatory patch, the raw formats are\nexcluded from output configurations for conversions.\n\nSigned-off-by: Milan Zamazal \nReviewed-by: Umang Jain \nSigned-off-by: Milan Zamazal \n---\n src/libcamera/pipeline/simple/simple.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 04446a3ef..ba8a22ccc 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -27,6 +27,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n \n@@ -264,6 +265,12 @@ static const SimplePipelineInfo supportedDevices[] = {\n \t{ \"sun6i-csi\", {}, false },\n };\n \n+bool isRaw(const StreamConfiguration &cfg)\n+{\n+\treturn libcamera::PixelFormatInfo::info(cfg.pixelFormat).colourEncoding ==\n+\t libcamera::PixelFormatInfo::ColourEncodingRAW;\n+}\n+\n } /* namespace */\n \n class SimpleCameraData : public Camera::Private\n@@ -1446,7 +1453,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \n \t\tcfg.setStream(&data->streams_[i]);\n \n-\t\tif (data->useConversion_)\n+\t\tif (data->useConversion_ && !isRaw(cfg))\n \t\t\toutputCfgs.push_back(cfg);\n \t}\n \n","prefixes":["v15","2/8"]}