{"id":24961,"url":"https://patchwork.libcamera.org/api/patches/24961/?format=json","web_url":"https://patchwork.libcamera.org/patch/24961/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251103221315.73350-3-uajain@igalia.com>","date":"2025-11-03T22:13:15","name":"[v5,2/2] lc-compliance: Ensure stream's colorspace is set after validate()","commit_ref":"5d8f4d0a20899b5eece8b63f29e667d541a2de0a","pull_url":null,"state":"accepted","archived":false,"hash":"1fcc2772fa082c182710d68607b70d1f85c68b15","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/?format=json","name":"Umang Jain","email":"uajain@igalia.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24961/mbox/","series":[{"id":5560,"url":"https://patchwork.libcamera.org/api/series/5560/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5560","date":"2025-11-03T22:13:13","name":"lc-compliance: Ensure stream's colorspace is set after validate()","version":5,"mbox":"https://patchwork.libcamera.org/series/5560/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24961/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24961/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77F58C3259\n\tfor ;\n\tMon, 3 Nov 2025 22:12:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 410D660A85;\n\tMon, 3 Nov 2025 23:12:47 +0100 (CET)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2B0A606A0\n\tfor ;\n\tMon, 3 Nov 2025 23:12:44 +0100 (CET)","from [81.140.124.245] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1vG2n6-0014tl-0W; Mon, 03 Nov 2025 23:12:44 +0100"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"IUqF4cuN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:Content-Type:MIME-Version:References:\n\tIn-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=TBfewWrmSezXtX+gLZd/PzvEIbXBvFZcoTZptg7F9Uk=;\n\tb=IUqF4cuNxq8EQBp831NB1mr1uy\n\toQrU9cvjtd0WC+XSXa91Trt4sJ+FKVRE7tzKoEnycQ9cCG1nrI1wQcJSM2Nfdjz8N/l7zhILabfaR\n\tYqpEF2bHWBx9Ivot7IlmKzl2Uz6dVJUdzBRcLiZB+71fwxp2r+Xbt3BrUJW0UeZfIMzpJbfPqzRMm\n\tMVfWeC+DvoyXbidNdPnnF8G4nDQ+AEEFcvVBspKKpXiMjU7TcVlWGPd/PXsNpuyzhvnMN9SdPBHMA\n\tmkQX4Xun2Ndye3NvmzgzivZ3/o07T2y/ZOHTMZQy1EZrUU0kfL0ThUZRvnuuIYHGCo8B+rY7AbQ9Z\n\tl/u0mM5A==;","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Umang Jain , Kieran Bingham\n\t, Robert Mader\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","Subject":"[PATCH v5 2/2] lc-compliance: Ensure stream's colorspace is set\n\tafter validate()","Date":"Mon, 3 Nov 2025 22:13:15 +0000","Message-ID":"<20251103221315.73350-3-uajain@igalia.com>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20251103221315.73350-1-uajain@igalia.com>","References":"<20251103221315.73350-1-uajain@igalia.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"StreamConfiguration::colorspace is a std::optional<> and if unset by\nthe user, it should be populated by the pipeline handler after the\nCameraConfiguration::validate().\n\nAdd a EXPECT_TRUE() check to ensure that each stream in the\nCameraConfiguration has a colorspace set.\n\nSigned-off-by: Umang Jain \nReviewed-by: Kieran Bingham \nTested-by: Robert Mader \nReviewed-by: Barnabás Pőcze \n---\n src/apps/lc-compliance/helpers/capture.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/apps/lc-compliance/helpers/capture.cpp b/src/apps/lc-compliance/helpers/capture.cpp\nindex 2a3fa3b6..dbccc3ff 100644\n--- a/src/apps/lc-compliance/helpers/capture.cpp\n+++ b/src/apps/lc-compliance/helpers/capture.cpp\n@@ -52,6 +52,9 @@ void Capture::configure(libcamera::Span roles)\n \t\tFAIL() << \"Configuration not valid\";\n \t}\n \n+\tfor (const auto &cfg : *config_)\n+\t\tEXPECT_TRUE(cfg.colorSpace) << \"Colorspace not set for \" << cfg;\n+\n \tif (camera_->configure(config_.get())) {\n \t\tconfig_.reset();\n \t\tFAIL() << \"Failed to configure camera\";\n","prefixes":["v5","2/2"]}