[{"id":36669,"web_url":"https://patchwork.libcamera.org/comment/36669/","msgid":"<5012797f-b64f-43ad-a500-93a5b0e04f75@ideasonboard.com>","date":"2025-11-03T15:54:46","subject":"Re: [PATCH v4 1/2] libcamera: pipeline_handler: Add accessor for\n\tuseCount_","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 11. 03. 15:03 keltezéssel, Antoine Bouyer írta:\n> Add an accessor for useCount_ parameter, so that PipelineHandler\n> child classes can access it to verify whether the media device\n> is already locked or not.\n> \n> Signed-off-by: Antoine Bouyer \n> Reviewed-by: Kieran Bingham \n> ---\n> include/libcamera/internal/pipeline_handler.h | 1 +\n> src/libcamera/pipeline_handler.cpp | 6 ++++++\n> 2 files changed, 7 insertions(+)\n> \n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index e89d6a33e398..8fe970317fdd 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -73,6 +73,7 @@ public:\n> protected:\n> \tvoid registerCamera(std::shared_ptr camera);\n> \tvoid hotplugMediaDevice(MediaDevice *media);\n> +\tunsigned int useCount() { return useCount_; };\n\nThe method should be `const` qualified.\n\n\n> \n> \tvirtual int queueRequestDevice(Camera *camera, Request *request) = 0;\n> \tvirtual void stopDevice(Camera *camera) = 0;\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index e5f9e55c9783..3f7c20aced13 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -811,6 +811,12 @@ void PipelineHandler::disconnect()\n> * \\return The pipeline handler name\n> */\n> \n> + /**\n> + * \\fn PipelineHandler::useCount()\n> + * \\brief Retrieve the pipeline handler user count\n> + * \\return The pipeline handler user count\n> + */\n\nMaybe I would say something like \"\\return The number of acquired cameras of the pipeline handler\"\nsince it's not immediately clear to me what the \"user count\" is.\n\n\nRegards,\nBarnabás Pőcze\n\n> +\n> /**\n> * \\fn PipelineHandler::cameraManager() const\n> * \\brief Retrieve the CameraManager that this pipeline handler belongs to","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42D72BDE4C\n\tfor ;\n\tMon, 3 Nov 2025 15:54:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F28F8606A0;\n\tMon, 3 Nov 2025 16:54:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A646606A0\n\tfor ;\n\tMon, 3 Nov 2025 16:54:47 +0100 (CET)","from [192.168.33.39] (185.221.140.239.nat.pool.zt.hu\n\t[185.221.140.239])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E7B6C73;\n\tMon, 3 Nov 2025 16:52:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qzJ1RApp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762185174;\n\tbh=ksvzDGG8Mbx2dJu8stfINZ4EvXdBSsi57vTdyeGRDT4=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=qzJ1RAppQwi1AoAKLxPpRu518DrOggfLjJRbwXNNsdcxmhKQlL3f/4AxKlxsnsZVF\n\tKC4I8Xp9bY/53TEsQ0ufqYlgplNi4rjuVNo2LWg4C6iHhazETgl2L5pOJ1hVMUwO7a\n\tjP4p48tcv8PDprQKPODCfwuUNXoeR2WNlggHXor8=","Message-ID":"<5012797f-b64f-43ad-a500-93a5b0e04f75@ideasonboard.com>","Date":"Mon, 3 Nov 2025 16:54:46 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 1/2] libcamera: pipeline_handler: Add accessor for\n\tuseCount_","To":"Antoine Bouyer ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"julien.vuillaumier@nxp.com,\n\tKieran Bingham ","References":"<20251103140325.88535-1-antoine.bouyer@nxp.com>\n\t<20251103140325.88535-2-antoine.bouyer@nxp.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251103140325.88535-2-antoine.bouyer@nxp.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]