[{"id":36661,"web_url":"https://patchwork.libcamera.org/comment/36661/","msgid":"<176218045458.39745.8171335295236480917@localhost>","date":"2025-11-03T14:34:14","subject":"Re: [RFC PATCH v2] utils: checkstyle.py: Accept `Closes` commit\n\ttrailer","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nQuoting Barnabás Pőcze (2025-10-31 10:50:57)\n> `Closes: ` is recognized by gitlab[0] and closes the referenced issue\n> automatically when a commit is made to the project's default branch. Now\n> that issues are hosted on gitlab, it will be the preferred way to reference\n> the fixed issue from a commit, so replace the previously used `Bug` with it\n> in the checkstlye.py script.\n> \n> [0]: https://docs.gitlab.com/user/project/issues/managing_issues/#default-closing-pattern\n> \n> Signed-off-by: Barnabás Pőcze \n> Reviewed-by: Kieran Bingham \n> ---\n> changes in v2:\n> * remove `Bug`\n> \n> v1: https://patchwork.libcamera.org/patch/24888/\n> ---\n> Still one potential question remains: should the url be restricted?\n> I think it makes sense to allow arbitrary urls to support different\n> bug trackers (e.g. rpi github).\n\nAfter reading through the previous discussions, I'd vote for the\nnon-strict url check as I (personally) value the ability to reference a\nbug in some other bug tracking system higher than the guard against\ntypos.\n\nReviewed-by: Stefan Klug \n\nRegards,\nStefan\n\n> ---\n> utils/checkstyle.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index f6229bbd86..fa1355c173 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -541,7 +541,7 @@ class TrailersChecker(CommitChecker):\n> \n> known_trailers = {\n> 'Acked-by': email_regex,\n> - 'Bug': link_regex,\n> + 'Closes': link_regex,\n> 'Co-developed-by': email_regex,\n> 'Fixes': commit_regex,\n> 'Link': link_regex,\n> --\n> 2.51.1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D3C52C3241\n\tfor ;\n\tMon, 3 Nov 2025 14:34:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B493A60A80;\n\tMon, 3 Nov 2025 15:34:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24394606A0\n\tfor ;\n\tMon, 3 Nov 2025 15:34:18 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:1b71:26a2:a362:3fd7])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id E88447CE;\n\tMon, 3 Nov 2025 15:32:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FJtCseJq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762180345;\n\tbh=FgzVfRauvRVi1GKmITB3k+bDbz3+6Tpq3UlhiBVaN7M=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=FJtCseJqg7uGMrtStqBd89SAE486xPx718vHVAupD4nGnZYISrbXhotbU/ZFb7aWk\n\thFNtY9eAy6EvXKxmxhTZa5IfFuXQsUZvF5cMxUrhI6cBKai5s/xf2Ih86m8CBWiMZa\n\tkRdhlwmsmdqKVLv15HUgqOhN/Uyvr0BLnFE9zH10=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251031095057.1181439-1-barnabas.pocze@ideasonboard.com>","References":"<20251031095057.1181439-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [RFC PATCH v2] utils: checkstyle.py: Accept `Closes` commit\n\ttrailer","From":"Stefan Klug ","Cc":"Laurent Pinchart ,\n\tKieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 03 Nov 2025 15:34:14 +0100","Message-ID":"<176218045458.39745.8171335295236480917@localhost>","User-Agent":"alot/0.12.dev8+g2c003385c862.d20250602","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]