[{"id":36609,"web_url":"https://patchwork.libcamera.org/comment/36609/","msgid":"<176209649228.2973778.16075328242507457216@ping.linuxembedded.co.uk>","date":"2025-11-02T15:14:52","subject":"Re: [RFC PATCH v3 11/22] libcamera: request: Store `MetadataList`","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-10-30 16:58:05)\n> Add a `MetadataList` to the `Request` object to store the metadata items\n> returned by the camera. The metadata list is initialized using the camera's\n> `MetadataListPlan` object, which is supposed to be filled by the pipeline\n> handlers.\n> \n> This new list is exposed as `metadata2`, and the old `ControlList` is\n> still present for now.\n\nWhy are we keeping metadata() as a ControlList? will we remove it and\nreplace as a MetadataList ?\n\nDo applications have to use the new list quite differently ?\n\n> \n> Signed-off-by: Barnabás Pőcze \n> Reviewed-by: Jacopo Mondi \n> Reviewed-by: Paul Elder \n> ---\n> include/libcamera/request.h | 5 +++++\n> src/libcamera/request.cpp | 2 ++\n> 2 files changed, 7 insertions(+)\n> \n> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> index 0c5939f7b3..23e7bde72c 100644\n> --- a/include/libcamera/request.h\n> +++ b/include/libcamera/request.h\n> @@ -18,6 +18,7 @@\n> \n> #include \n> #include \n> +#include \n> \n> namespace libcamera {\n> \n> @@ -51,6 +52,9 @@ public:\n> \n> ControlList &controls() { return *controls_; }\n> ControlList &metadata() { return *metadata_; }\n> +#ifndef __DOXYGEN__\n> + [[nodiscard]] MetadataList &metadata2() { return metadata2_; }\n> +#endif\n> const BufferMap &buffers() const { return bufferMap_; }\n> int addBuffer(const Stream *stream, FrameBuffer *buffer,\n> std::unique_ptr &&fence = {});\n> @@ -69,6 +73,7 @@ private:\n> \n> ControlList *controls_;\n> ControlList *metadata_;\n> + MetadataList metadata2_;\n> BufferMap bufferMap_;\n> \n> const uint64_t cookie_;\n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index 992d476e09..0ff465e6f7 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -357,6 +357,7 @@ void Request::Private::timeout()\n> */\n> Request::Request(Camera *camera, uint64_t cookie)\n> : Extensible(std::make_unique(camera)),\n> + metadata2_(camera->_d()->metadataPlan_),\n> cookie_(cookie), status_(RequestPending)\n> {\n> controls_ = new ControlList(controls::controls,\n> @@ -410,6 +411,7 @@ void Request::reuse(ReuseFlag flags)\n> \n> controls_->clear();\n> metadata_->clear();\n> + metadata2_.clear();\n> }\n> \n> /**\n> -- \n> 2.51.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E10C5C3241\n\tfor ;\n\tSun, 2 Nov 2025 15:14:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 36C7160AA0;\n\tSun, 2 Nov 2025 16:14:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 545C76096B\n\tfor ;\n\tSun, 2 Nov 2025 16:14:55 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17EC6177B;\n\tSun, 2 Nov 2025 16:13:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"F9FZPls+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762096383;\n\tbh=vrYbzwSiB5ewdiMM7mMgossm2kNmz5DtRAgoS7cUSJ4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=F9FZPls+I1NilYJUb76q2eSni5PgMTIE/tBxAXXtdYXp9LhLWYqnUs5JqBz88DJF0\n\tQYtYlBGH5m7mlzPqs4oyV7hQlXW7UcMcr5rhfFhsikEWwZzBtQ8uFYvZAmyl1CBT42\n\t2X+taGxe4stccU5hOJtCYPGmvpZUQ9cIFFjCfcHQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251030165816.1095180-12-barnabas.pocze@ideasonboard.com>","References":"<20251030165816.1095180-1-barnabas.pocze@ideasonboard.com>\n\t<20251030165816.1095180-12-barnabas.pocze@ideasonboard.com>","Subject":"Re: [RFC PATCH v3 11/22] libcamera: request: Store `MetadataList`","From":"Kieran Bingham ","Cc":"Jacopo Mondi ,\n\tPaul Elder ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sun, 02 Nov 2025 15:14:52 +0000","Message-ID":"<176209649228.2973778.16075328242507457216@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36644,"web_url":"https://patchwork.libcamera.org/comment/36644/","msgid":"<4dc5c0b7-8689-4f6e-9efd-2c1d9e215c95@ideasonboard.com>","date":"2025-11-03T10:20:58","subject":"Re: [RFC PATCH v3 11/22] libcamera: request: Store `MetadataList`","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 11. 02. 16:14 keltezéssel, Kieran Bingham írta:\n> Quoting Barnabás Pőcze (2025-10-30 16:58:05)\n>> Add a `MetadataList` to the `Request` object to store the metadata items\n>> returned by the camera. The metadata list is initialized using the camera's\n>> `MetadataListPlan` object, which is supposed to be filled by the pipeline\n>> handlers.\n>>\n>> This new list is exposed as `metadata2`, and the old `ControlList` is\n>> still present for now.\n> \n> Why are we keeping metadata() as a ControlList? will we remove it and\n> replace as a MetadataList ?\n\nThe two lists are kept mainly for testing. The intention is to remove the\n`ControlList` one. Also see the last change in this series, which is not\ntoo small and would have to be incorporated here if the switch was done right away.\n\n\n> \n> Do applications have to use the new list quite differently ?\n\nThe intention is that changes are minimal, but if something hard-codes\ne.g. the type `ControlList`, then it has to change.\n\n\n> \n>>\n>> Signed-off-by: Barnabás Pőcze \n>> Reviewed-by: Jacopo Mondi \n>> Reviewed-by: Paul Elder \n>> ---\n>> include/libcamera/request.h | 5 +++++\n>> src/libcamera/request.cpp | 2 ++\n>> 2 files changed, 7 insertions(+)\n>>\n>> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n>> index 0c5939f7b3..23e7bde72c 100644\n>> --- a/include/libcamera/request.h\n>> +++ b/include/libcamera/request.h\n>> @@ -18,6 +18,7 @@\n>> \n>> #include \n>> #include \n>> +#include \n>> \n>> namespace libcamera {\n>> \n>> @@ -51,6 +52,9 @@ public:\n>> \n>> ControlList &controls() { return *controls_; }\n>> ControlList &metadata() { return *metadata_; }\n>> +#ifndef __DOXYGEN__\n>> + [[nodiscard]] MetadataList &metadata2() { return metadata2_; }\n>> +#endif\n>> const BufferMap &buffers() const { return bufferMap_; }\n>> int addBuffer(const Stream *stream, FrameBuffer *buffer,\n>> std::unique_ptr &&fence = {});\n>> @@ -69,6 +73,7 @@ private:\n>> \n>> ControlList *controls_;\n>> ControlList *metadata_;\n>> + MetadataList metadata2_;\n>> BufferMap bufferMap_;\n>> \n>> const uint64_t cookie_;\n>> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n>> index 992d476e09..0ff465e6f7 100644\n>> --- a/src/libcamera/request.cpp\n>> +++ b/src/libcamera/request.cpp\n>> @@ -357,6 +357,7 @@ void Request::Private::timeout()\n>> */\n>> Request::Request(Camera *camera, uint64_t cookie)\n>> : Extensible(std::make_unique(camera)),\n>> + metadata2_(camera->_d()->metadataPlan_),\n>> cookie_(cookie), status_(RequestPending)\n>> {\n>> controls_ = new ControlList(controls::controls,\n>> @@ -410,6 +411,7 @@ void Request::reuse(ReuseFlag flags)\n>> \n>> controls_->clear();\n>> metadata_->clear();\n>> + metadata2_.clear();\n>> }\n>> \n>> /**\n>> -- \n>> 2.51.1\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 98E91C3241\n\tfor ;\n\tMon, 3 Nov 2025 10:21:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9188E60A80;\n\tMon, 3 Nov 2025 11:21:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 85B9360805\n\tfor ;\n\tMon, 3 Nov 2025 11:21:02 +0100 (CET)","from [192.168.33.39] (185.221.140.239.nat.pool.zt.hu\n\t[185.221.140.239])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5BD1C111D;\n\tMon, 3 Nov 2025 11:19:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"S8B882bO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762165149;\n\tbh=P6YSIsQ6yVBg++DRS6iXx7CBqIU3gYUICS6N6MvoYZY=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=S8B882bOercE6Eqg3P5b2QeMwTCGIrj3+97L6h8NPH/7gw1N0VcrFRXwQaQVUtWyq\n\tBFGEEtd70Gor1Bi1F7os2WmjJ8SRNSu72TTkad/kelWNzya/wzJ3Xa9pXqFyTZeAgY\n\tzKIC4h/92xgrbwUPdd4N7/5qxC5iuE93VyR4uVQQ=","Message-ID":"<4dc5c0b7-8689-4f6e-9efd-2c1d9e215c95@ideasonboard.com>","Date":"Mon, 3 Nov 2025 11:20:58 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [RFC PATCH v3 11/22] libcamera: request: Store `MetadataList`","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tPaul Elder ","References":"<20251030165816.1095180-1-barnabas.pocze@ideasonboard.com>\n\t<20251030165816.1095180-12-barnabas.pocze@ideasonboard.com>\n\t<176209649228.2973778.16075328242507457216@ping.linuxembedded.co.uk>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<176209649228.2973778.16075328242507457216@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]