[{"id":36610,"web_url":"https://patchwork.libcamera.org/comment/36610/","msgid":"<176209662214.2973778.372491891159036847@ping.linuxembedded.co.uk>","date":"2025-11-02T15:17:02","subject":"Re: [RFC PATCH v3 10/22] libcamera: camera: Store `MetadataListPlan`\n\tin `Camera::Private`","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-10-30 16:58:04)\n> Just like `ControlInfoMap controlInfo_` is a public member of the private\n> camera data for pipeline handlers to populate, add a `MetadataListPlan` as\n> well for the pipeline handlers to fill. This will be used to initialize\n> the `MetadataList` of each request created by the camera.\n> \n> Also add `Camera::metadata()`, which makes it accessible for applications.\n> \n> Signed-off-by: Barnabás Pőcze \n> Reviewed-by: Jacopo Mondi \n> Reviewed-by: Paul Elder \n> ---\n> changes in v2:\n> * make it available in `Camera::metadata()`\n> ---\n> include/libcamera/camera.h | 2 ++\n> include/libcamera/internal/camera.h | 2 ++\n> src/libcamera/camera.cpp | 21 +++++++++++++++++++++\n> 3 files changed, 25 insertions(+)\n> \n> diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\n> index b24a297400..53089282a4 100644\n> --- a/include/libcamera/camera.h\n> +++ b/include/libcamera/camera.h\n> @@ -31,6 +31,7 @@ class FrameBuffer;\n> class FrameBufferAllocator;\n> class PipelineHandler;\n> class Request;\n> +class MetadataListPlan;\n> \n> class SensorConfiguration\n> {\n> @@ -131,6 +132,7 @@ public:\n> \n> const ControlInfoMap &controls() const;\n> const ControlList &properties() const;\n> + const MetadataListPlan &metadata() const;\n> \n> const std::set &streams() const;\n> \n> diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\n> index 8a2e9ed589..016c1ae512 100644\n> --- a/include/libcamera/internal/camera.h\n> +++ b/include/libcamera/internal/camera.h\n> @@ -18,6 +18,7 @@\n> #include \n> \n> #include \n> +#include \n> \n> namespace libcamera {\n> \n> @@ -40,6 +41,7 @@ public:\n> std::queue waitingRequests_;\n> ControlInfoMap controlInfo_;\n> ControlList properties_;\n> + MetadataListPlan metadataPlan_;\n> \n> uint32_t requestSequence_;\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 2e1e146a25..7bfa50b52c 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -658,6 +658,14 @@ Camera::Private::~Private()\n> * when creating the camera, and shall not be modified afterwards.\n> */\n> \n> +/**\n> + * \\var Camera::Private::metadataPlan_\n> + * \\brief The set of metadata supported by the camera\n> + *\n> + * The metadata information shall be initialised by the pipeline handler when\n> + * creating the camera.\n> + */\n> +\n> /**\n> * \\var Camera::Private::requestSequence_\n> * \\brief The queuing sequence number of the request\n> @@ -1074,6 +1082,19 @@ const ControlInfoMap &Camera::controls() const\n> return _d()->controlInfo_;\n> }\n> \n> +/**\n> + * \\brief Retrieve the set of metadata supported by the camera\n> + *\n> + * The list of metadata controls that may be reported by the camera\n> + * for a \\ref Request::metadata() \"request\".\n> + *\n> + * \\return A MetadataListPlan listing the metadata controls supported by the camera\n> + */\n> +const MetadataListPlan &Camera::metadata() const\n> +{\n> + return _d()->metadataPlan_;\n> +}\n\nI think exposing this is a good thing, and means generic applications\ncan identify what they will receive in advance. Might help with\nconstruction of UI etc before the stream starts.\n\n\nReviewed-by: Kieran Bingham \n\n> +\n> /**\n> * \\brief Retrieve the list of properties of the camera\n> *\n> -- \n> 2.51.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E01E8BDE4C\n\tfor ;\n\tSun, 2 Nov 2025 15:17:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0BB1260A80;\n\tSun, 2 Nov 2025 16:17:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BAC52606E6\n\tfor ;\n\tSun, 2 Nov 2025 16:17:05 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 888AD10D4;\n\tSun, 2 Nov 2025 16:15:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LaGPI+6S\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762096513;\n\tbh=8Z7mCwCrjHHQBCb2odZsSFkUTzfv6oWjnCTzFrdiBok=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=LaGPI+6SCdX/L4FOiuLmGcOFRuolcolDy58bpaTmODRBVhV5691SdNbIdr9ZmYeWN\n\tP2O5cPZ5rWpRPs1JjmIPVXEIHXm4m4J9f4Gnni6xMz+QTlC1IJg9xYcwv76xILuned\n\tKKnExt2OAtAw35Y+5tJns6j8DcOQzNZtvDYqIqMU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251030165816.1095180-11-barnabas.pocze@ideasonboard.com>","References":"<20251030165816.1095180-1-barnabas.pocze@ideasonboard.com>\n\t<20251030165816.1095180-11-barnabas.pocze@ideasonboard.com>","Subject":"Re: [RFC PATCH v3 10/22] libcamera: camera: Store `MetadataListPlan`\n\tin `Camera::Private`","From":"Kieran Bingham ","Cc":"Jacopo Mondi ,\n\tPaul Elder ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sun, 02 Nov 2025 15:17:02 +0000","Message-ID":"<176209662214.2973778.372491891159036847@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]