[{"id":36563,"web_url":"https://patchwork.libcamera.org/comment/36563/","msgid":"<176190068616.567526.8862050172210177408@ping.linuxembedded.co.uk>","date":"2025-10-31T08:51:26","subject":"Re: [RFC PATCH v3 03/22] libcamera: base: Add file for C++20\n\tpolyfills","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-10-30 16:57:57)\n> Add `cxx20.h` that will contain (possibly limited) C++17 implementations\n> of some C++20 standard library features.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> include/libcamera/base/internal/cxx20.h | 18 ++++++++++++++++++\n> include/libcamera/base/meson.build | 7 +++++++\n> 2 files changed, 25 insertions(+)\n> create mode 100644 include/libcamera/base/internal/cxx20.h\n> \n> diff --git a/include/libcamera/base/internal/cxx20.h b/include/libcamera/base/internal/cxx20.h\n> new file mode 100644\n> index 0000000000..70a43f83c9\n> --- /dev/null\n> +++ b/include/libcamera/base/internal/cxx20.h\n> @@ -0,0 +1,18 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2025, Ideas on Board Oy\n> + *\n> + * C++20 polyfills\n> + */\n> +\n> +#pragma once\n> +\n> +/**\n> + * \\internal\n> + * \\file cxx20.h\n> + * \\brief C++17 implementations of certain C++20 types and functions\n> + */\n> +\n> +namespace libcamera::internal::cxx20 {\n> +\n> +} /* namespace libcamera::internal::cxx20 */\n> diff --git a/include/libcamera/base/meson.build b/include/libcamera/base/meson.build\n> index f28ae4d42a..ee42c9910f 100644\n> --- a/include/libcamera/base/meson.build\n> +++ b/include/libcamera/base/meson.build\n> @@ -31,10 +31,17 @@ libcamera_base_private_headers = files([\n> 'utils.h',\n> ])\n> \n> +libcamera_base_internal_headers = files([\n> + 'internal/cxx20.h',\n> +])\n> +\n> libcamera_base_headers = [\n> libcamera_base_public_headers,\n> libcamera_base_private_headers,\n> + libcamera_base_internal_headers,\n> ]\n> \n> install_headers(libcamera_base_public_headers,\n> subdir : libcamera_base_include_dir)\n> +install_headers(libcamera_base_internal_headers,\n> + subdir : libcamera_base_include_dir / 'internal')\n\nEeep ok - so we have to install the internal polyfils on public-api\nspace.\n\nI think I can predict why this is going to be needed, so I'll add this:\n\nAcked-by: Kieran Bingham \n\nI'll be curious if we can do anything like we do for\ninclude/libcamera/base/private.h but I suspect not if this file is going\nto be directly included in public headers.\n\n\n\n> -- \n> 2.51.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64EF4C3259\n\tfor ;\n\tFri, 31 Oct 2025 08:51:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5136060904;\n\tFri, 31 Oct 2025 09:51:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D130606E6\n\tfor ;\n\tFri, 31 Oct 2025 09:51:29 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 95D991989;\n\tFri, 31 Oct 2025 09:49:38 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rg0Zw3Oa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761900578;\n\tbh=xoPpFZhaIw3ePua2qwwTK3XmdLrFWbc9CIvqBoGcb54=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=rg0Zw3Oa/qAiDKwUTmPFlaJNxbQxSKX2j8zFyFNtUZ7Iw5evM30rKsu/VaQV9UOZX\n\tqki7odUKv7JaunywKY8nla29DXTS/pz+tvYF73Xit+/zG7kiF4TaU+SOYeKelON1Ca\n\tJUIim5edsKxwaVviCwx1zVJHvryjdavhUEvyNQhE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251030165816.1095180-4-barnabas.pocze@ideasonboard.com>","References":"<20251030165816.1095180-1-barnabas.pocze@ideasonboard.com>\n\t<20251030165816.1095180-4-barnabas.pocze@ideasonboard.com>","Subject":"Re: [RFC PATCH v3 03/22] libcamera: base: Add file for C++20\n\tpolyfills","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 31 Oct 2025 08:51:26 +0000","Message-ID":"<176190068616.567526.8862050172210177408@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]