{"id":24904,"url":"https://patchwork.libcamera.org/api/patches/24904/?format=json","web_url":"https://patchwork.libcamera.org/patch/24904/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251030165816.1095180-2-barnabas.pocze@ideasonboard.com>","date":"2025-10-30T16:57:55","name":"[RFC,v3,01/22] libcamera: controls: Strings are arrays","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d65d06b01c1bebc72d0123ceac6e83f256947000","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24904/mbox/","series":[{"id":5545,"url":"https://patchwork.libcamera.org/api/series/5545/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5545","date":"2025-10-30T16:57:54","name":"libcamera: Add `MetadataList`","version":3,"mbox":"https://patchwork.libcamera.org/series/5545/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24904/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24904/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80F36C3259\n\tfor ;\n\tThu, 30 Oct 2025 16:58:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0E3D60921;\n\tThu, 30 Oct 2025 17:58:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BFFFD608C8\n\tfor ;\n\tThu, 30 Oct 2025 17:58:20 +0100 (CET)","from pb-laptop.local (185.221.140.239.nat.pool.zt.hu\n\t[185.221.140.239])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9508C15D2;\n\tThu, 30 Oct 2025 17:56:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"omO5JSUl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761843390;\n\tbh=BbJSD/7oCP/mj9yqYWmwjFpiEwHBJuUFMJdxNysWtb8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=omO5JSUlxdicUvln5sQGkjJKUVa9LV+mYibRnL5CkdFavHShRHvM8lhhRQ3+sFzbz\n\tlfbKq1Ai1/IehBi2V6vlQMscznKPaJDI9iCZf8l+zuBL0AuOhM9CgGLPUzCWwoZSg2\n\tmFkHhkuc0URVfMUsk+hp85YnCDSuMEZ5N9q0oiMo=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tIsaac Scott ,\n\tPaul Elder ","Subject":"[RFC PATCH v3 01/22] libcamera: controls: Strings are arrays","Date":"Thu, 30 Oct 2025 17:57:55 +0100","Message-ID":"<20251030165816.1095180-2-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.51.1","In-Reply-To":"<20251030165816.1095180-1-barnabas.pocze@ideasonboard.com>","References":"<20251030165816.1095180-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"`ControlId::isArray()` and `ControlValue::isArray()` disagree\nin the case of strings. Fix it by setting the static size of a\nstring to `libcamera::dynamic_extent` to denote a dynamically\nsized array-like value.\n\nOne unfortunate side effect of this change is that if there were\nstring controls (there are none at the moment), then `cam` would\ndisplay them with an extra `Size: n` annotation.\n\nCloses: https://gitlab.freedesktop.org/camera/libcamera/-/issues/255\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Jacopo Mondi \nReviewed-by: Isaac Scott \nReviewed-by: Paul Elder \n---\n include/libcamera/controls.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex c970e4b7b8..1ee1971c4d 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -98,7 +98,7 @@ struct control_type {\n template<>\n struct control_type {\n \tstatic constexpr ControlType value = ControlTypeString;\n-\tstatic constexpr std::size_t size = 0;\n+\tstatic constexpr std::size_t size = libcamera::dynamic_extent;\n };\n \n template<>\n","prefixes":["RFC","v3","01/22"]}