{"id":24888,"url":"https://patchwork.libcamera.org/api/patches/24888/?format=json","web_url":"https://patchwork.libcamera.org/patch/24888/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251029100847.730477-1-barnabas.pocze@ideasonboard.com>","date":"2025-10-29T10:08:47","name":"[RFC,v1] utils: checkstyle.py: Accept `Closes` commit trailer","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"78101c455111987046eb4708d9deb69ecac7ec5b","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24888/mbox/","series":[{"id":5543,"url":"https://patchwork.libcamera.org/api/series/5543/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5543","date":"2025-10-29T10:08:47","name":"[RFC,v1] utils: checkstyle.py: Accept `Closes` commit trailer","version":1,"mbox":"https://patchwork.libcamera.org/series/5543/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24888/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24888/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 293A5C3259\n\tfor ;\n\tWed, 29 Oct 2025 10:08:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1689D6082E;\n\tWed, 29 Oct 2025 11:08:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 224CD600CC\n\tfor ;\n\tWed, 29 Oct 2025 11:08:51 +0100 (CET)","from pb-laptop.local (185.182.215.162.nat.pool.zt.hu\n\t[185.182.215.162])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8780A15D2\n\tfor ;\n\tWed, 29 Oct 2025 11:07:01 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qg2YhQLe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761732421;\n\tbh=MIorx8uxUUa7uD/nRk8vCVkNWIYW8KbeetvlQXZgxKU=;\n\th=From:To:Subject:Date:From;\n\tb=qg2YhQLewt+duuG+zsmuxNFCaZw22M0liYxkuyqUQTjkI4qAToZbo8n936cdVHI70\n\tCVsyBbt374kUW+uQM26iFhewwMc8i4Ti7r9eYQ6FAKyza+GuZk1sSq1m0zdzQ8Sex1\n\tfJqB8VhoP8NK7cvkTyubKXnCLv3U6nnssHZOQbZA=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1] utils: checkstyle.py: Accept `Closes` commit trailer","Date":"Wed, 29 Oct 2025 11:08:47 +0100","Message-ID":"<20251029100847.730477-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.51.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"`Closes: ` is recognized by gitlab and closes the referenced issue\nautomatically when a commit is made[0] to the project's default branch.\nNow that issues are hosted on gitlab, it will be the preferred way to\nreference the fixed issue from a commit, so add it to the checkstlye.py script.\n\n[0]: https://docs.gitlab.com/user/project/issues/managing_issues/#default-closing-pattern\n\nSigned-off-by: Barnabás Pőcze \n---\nTwo questions remain:\n\n(1) should the regex be stricter? e.g.\n r\"https:\\/\\/gitlab\\.freedesktop\\.org\\/camera\\/libcamera\\/-\\/issues\\/[0-9]+\"\n\n(2) what should happen to `Bug` ?\n---\n utils/checkstyle.py | 1 +\n 1 file changed, 1 insertion(+)\n\n--\n2.51.1","diff":"diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex f6229bbd86..219921bc9d 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -542,6 +542,7 @@ class TrailersChecker(CommitChecker):\n known_trailers = {\n 'Acked-by': email_regex,\n 'Bug': link_regex,\n+ 'Closes': link_regex,\n 'Co-developed-by': email_regex,\n 'Fixes': commit_regex,\n 'Link': link_regex,\n","prefixes":["RFC","v1"]}