[{"id":36528,"web_url":"https://patchwork.libcamera.org/comment/36528/","msgid":"<176166896653.3666756.7613993067652680504@ping.linuxembedded.co.uk>","date":"2025-10-28T16:29:26","subject":"Re: [PATCH v3 1/2] libcamera: pipeline_handler: Move useCount_ to\n\tprotected","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Antoine Bouyer (2025-10-28 16:04:52)\n> Move the useCount_ parameter to protected instead of private, so that\n> PipelineHandler child classes could access it to verify whether the\n> media device is already locked or not.\n> \n> Signed-off-by: Antoine Bouyer \n> ---\n> include/libcamera/internal/pipeline_handler.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index e89d6a33e398..4cefa3c7aba2 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -82,6 +82,7 @@ protected:\n> \n> CameraManager *manager_;\n> const unsigned int maxQueuedRequestsDevice_;\n> + unsigned int useCount_;\n\nPart of me wonders if we should have an accessor instead but I don't\nthink that's completley required. Though I can't imagine why a derived\npipeline handler should ever modify this value ...\n\nSo for now:\n\nReviewed-by: Kieran Bingham \n\n> \n> private:\n> void unlockMediaDevices();\n> @@ -96,7 +97,6 @@ private:\n> std::vector> cameras_;\n> \n> const char *name_;\n> - unsigned int useCount_;\n> \n> friend class PipelineHandlerFactoryBase;\n> };\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6838C3259\n\tfor ;\n\tTue, 28 Oct 2025 16:29:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3CB86606DE;\n\tTue, 28 Oct 2025 17:29:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 94E17606DE\n\tfor ;\n\tTue, 28 Oct 2025 17:29:29 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EFB5711D5;\n\tTue, 28 Oct 2025 17:27:40 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lcapCqY4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761668861;\n\tbh=umoH7UEvqToyQIg6WAKB5EBmE5w/KruLYyEEQ0M2wz4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=lcapCqY45cbjyc4eVe374aER9NFIJR9Onb6aoLf2mhmOZrbe/S4Oy+zT7T91wltDR\n\t46H2zbKt5UT1Z2yLNXDVS2nuKqvkNMD8mm7RCPNi4IDRrtPoiAstdui/vnQ+mzjh0q\n\t6mrrDOn9Liz+t1qphy0JQPjowMWqe697BVLRIiqE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251028160453.3802642-2-antoine.bouyer@nxp.com>","References":"<20251028160453.3802642-1-antoine.bouyer@nxp.com>\n\t<20251028160453.3802642-2-antoine.bouyer@nxp.com>","Subject":"Re: [PATCH v3 1/2] libcamera: pipeline_handler: Move useCount_ to\n\tprotected","From":"Kieran Bingham ","Cc":"julien.vuillaumier@nxp.com, Antoine Bouyer ","To":"Antoine Bouyer ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 28 Oct 2025 16:29:26 +0000","Message-ID":"<176166896653.3666756.7613993067652680504@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36557,"web_url":"https://patchwork.libcamera.org/comment/36557/","msgid":"<176183530759.567526.6093709079924512838@ping.linuxembedded.co.uk>","date":"2025-10-30T14:41:47","subject":"Re: [PATCH v3 1/2] libcamera: pipeline_handler: Move useCount_ to\n\tprotected","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2025-10-28 16:29:26)\n> Quoting Antoine Bouyer (2025-10-28 16:04:52)\n> > Move the useCount_ parameter to protected instead of private, so that\n> > PipelineHandler child classes could access it to verify whether the\n> > media device is already locked or not.\n> > \n> > Signed-off-by: Antoine Bouyer \n> > ---\n> > include/libcamera/internal/pipeline_handler.h | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> > index e89d6a33e398..4cefa3c7aba2 100644\n> > --- a/include/libcamera/internal/pipeline_handler.h\n> > +++ b/include/libcamera/internal/pipeline_handler.h\n> > @@ -82,6 +82,7 @@ protected:\n> > \n> > CameraManager *manager_;\n> > const unsigned int maxQueuedRequestsDevice_;\n> > + unsigned int useCount_;\n> \n> Part of me wonders if we should have an accessor instead but I don't\n> think that's completley required. Though I can't imagine why a derived\n> pipeline handler should ever modify this value ...\n> \n> So for now:\n> \n> Reviewed-by: Kieran Bingham \n\nBy moving this from private to protected the following error is produced\nso this doesn't get through CI:\n\nhttps://gitlab.freedesktop.org/camera/libcamera/-/jobs/86929614#L845\n\nFAILED: Documentation/internal-api\n/usr/bin/doxygen Documentation/Doxyfile-internal\n/builds/camera/libcamera/include/libcamera/internal/pipeline_handler.h:85: error: Member useCount_ (variable) of class libcamera::PipelineHandler is not documented. (warning treated as error, aborting now)\n\nIf you fix that up - I think making it just an accessor protects the\nuseCount_ ...\n\n--\nKieran\n\n\n> \n> > \n> > private:\n> > void unlockMediaDevices();\n> > @@ -96,7 +97,6 @@ private:\n> > std::vector> cameras_;\n> > \n> > const char *name_;\n> > - unsigned int useCount_;\n> > \n> > friend class PipelineHandlerFactoryBase;\n> > };\n> > -- \n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6A13BE080\n\tfor ;\n\tThu, 30 Oct 2025 14:41:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E052D608CC;\n\tThu, 30 Oct 2025 15:41:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51028603ED\n\tfor ;\n\tThu, 30 Oct 2025 15:41:50 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2BFFC2E0;\n\tThu, 30 Oct 2025 15:40:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XSutlXVJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761835200;\n\tbh=DWTU+5QnqtS/f93OWHGDQBJ0Jd3rCz9mx8p3mAavKOg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=XSutlXVJl+vLpr7LrgJyONcgFZaRX5hC8Pnb8XXxfPNg97iex7lw95VnZo5RJdOzx\n\tCAwvKpKL30v3gFaAL8h7gQ9CFtRfAzvPaUbYdA26NI7Jp7J5Mc3b61vq/5Bc+WDHfz\n\tRsyXEjliureH7XArR/FY/Kg1TMTUBxxQYL0OEXP8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<176166896653.3666756.7613993067652680504@ping.linuxembedded.co.uk>","References":"<20251028160453.3802642-1-antoine.bouyer@nxp.com>\n\t<20251028160453.3802642-2-antoine.bouyer@nxp.com>\n\t<176166896653.3666756.7613993067652680504@ping.linuxembedded.co.uk>","Subject":"Re: [PATCH v3 1/2] libcamera: pipeline_handler: Move useCount_ to\n\tprotected","From":"Kieran Bingham ","Cc":"julien.vuillaumier@nxp.com, Antoine Bouyer ","To":"Antoine Bouyer ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 30 Oct 2025 14:41:47 +0000","Message-ID":"<176183530759.567526.6093709079924512838@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]