[{"id":36506,"web_url":"https://patchwork.libcamera.org/comment/36506/","msgid":"<unnfmhrlzwqouokrgmqqpfs2scvqfetw7fkbhgdhnszdtm55pa@rzu7ustreifa>","date":"2025-10-28T08:58:11","subject":"Re: [PATCH] ipa: rpi: vd56g3: Fix frameIntegrationDiff value","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Benjamin\n\nOn Tue, Oct 28, 2025 at 09:46:50AM +0100, Benjamin Mugnier wrote:\n> In the vd56g3 user manual :\n>\n>   MAX_EXPOSURE_COARSE = FRAME_LENGTH − EXP_COARSE_INTG_MARGIN − 7\n>   EXP_COARSE_INTG_MARGIN >= 68\n>\n> Therefore, frameIntegrationDiff is EXP_COARSE_INTG_MARGIN + 7, equals\n> 75. This value is coherent with the VD56G3_EXPOSURE_MARGIN in the kernel\n> driver source code.\n>\n> Reported-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>\n\nThanks for the fix\n\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> ---\n>  src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp b/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp\n> index 140aabd802ad..8a58bc746711 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp\n> +++ b/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp\n> @@ -23,7 +23,7 @@ private:\n>  \t * Smallest difference between the frame length and integration time,\n>  \t * in units of lines.\n>  \t */\n> -\tstatic constexpr int frameIntegrationDiff = 61;\n> +\tstatic constexpr int frameIntegrationDiff = 75;\n>  };\n>\n>  CamHelperVd56g3::CamHelperVd56g3()\n> --\n> 2.25.1\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 25BB4BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Oct 2025 08:58:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12E906079D;\n\tTue, 28 Oct 2025 09:58:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 85197603ED\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Oct 2025 09:58:15 +0100 (CET)","from ideasonboard.com (mob-5-90-58-13.net.vodafone.it [5.90.58.13])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 68BE916CD;\n\tTue, 28 Oct 2025 09:56:26 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MEqFYJc9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761641787;\n\tbh=RxKuDx1WOpSzFxGsSYClwXwgwTxW7R9HPWY6DOc1aCs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MEqFYJc9SscfMZ4FKjStTYE/ogQlAaB8fMIEq+ITkHcjcDasUAqjg9sE3xQhAOO0y\n\toXS+7jW9PAqBLQP43LDTr3VeV4OFXLWMp545LV8QI9jeaV8EBrk+kFnZXRZ79AJ3MY\n\tmDrkU8GMIGQ5Qw/5pMrK8+efnx4bi+fVFx1gRSWo=","Date":"Tue, 28 Oct 2025 09:58:11 +0100","From":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","To":"Benjamin Mugnier <benjamin.mugnier@foss.st.com>","Cc":"libcamera-devel@lists.libcamera.org, \n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>","Subject":"Re: [PATCH] ipa: rpi: vd56g3: Fix frameIntegrationDiff value","Message-ID":"<unnfmhrlzwqouokrgmqqpfs2scvqfetw7fkbhgdhnszdtm55pa@rzu7ustreifa>","References":"<20251028084650.13043-1-benjamin.mugnier@foss.st.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20251028084650.13043-1-benjamin.mugnier@foss.st.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":36513,"web_url":"https://patchwork.libcamera.org/comment/36513/","msgid":"<176164944589.3666756.4955893849315483248@ping.linuxembedded.co.uk>","date":"2025-10-28T11:04:05","subject":"Re: [PATCH] ipa: rpi: vd56g3: Fix frameIntegrationDiff value","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Benjamin Mugnier (2025-10-28 08:46:50)\n> In the vd56g3 user manual :\n> \n>   MAX_EXPOSURE_COARSE = FRAME_LENGTH − EXP_COARSE_INTG_MARGIN − 7\n>   EXP_COARSE_INTG_MARGIN >= 68\n> \n> Therefore, frameIntegrationDiff is EXP_COARSE_INTG_MARGIN + 7, equals\n> 75. This value is coherent with the VD56G3_EXPOSURE_MARGIN in the kernel\n> driver source code.\n> \n> Reported-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> ---\n>  src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp b/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp\n> index 140aabd802ad..8a58bc746711 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp\n> +++ b/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp\n> @@ -23,7 +23,7 @@ private:\n>          * Smallest difference between the frame length and integration time,\n>          * in units of lines.\n>          */\n> -       static constexpr int frameIntegrationDiff = 61;\n> +       static constexpr int frameIntegrationDiff = 75;\n>  };\n>  \n>  CamHelperVd56g3::CamHelperVd56g3()\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B6ACBE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Oct 2025 11:04:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0070A607A7;\n\tTue, 28 Oct 2025 12:04:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD5F7606DE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Oct 2025 12:04:08 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F14F9AB4;\n\tTue, 28 Oct 2025 12:02:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i6sTzfOi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761649340;\n\tbh=J+IA2a5vsDA7HwGD+bhV6n86b4JIobyo19st5jy22CI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=i6sTzfOiBfJkSQoJCfBIqS6Zczj15kD/B5SgF7IEwfxjMobsAULKHeQWjxZidXu/q\n\tQ5VkA0cI04ZyT7Nd9lC3Om+3ApYvws2YSUI15t+oMwIgbK3L2TDohBaNgujZiv+88C\n\tWf5k3Zjx2wJ2SrWzfhKFBkgJAhmEEzfuB50eijg0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251028084650.13043-1-benjamin.mugnier@foss.st.com>","References":"<20251028084650.13043-1-benjamin.mugnier@foss.st.com>","Subject":"Re: [PATCH] ipa: rpi: vd56g3: Fix frameIntegrationDiff value","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Benjamin Mugnier <benjamin.mugnier@foss.st.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>","To":"Benjamin Mugnier <benjamin.mugnier@foss.st.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 28 Oct 2025 11:04:05 +0000","Message-ID":"<176164944589.3666756.4955893849315483248@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":36518,"web_url":"https://patchwork.libcamera.org/comment/36518/","msgid":"<CAEmqJPpJDdPV+whaauDFboUbNHoVyVhAq+sJAuPP5KHWE0U8rQ@mail.gmail.com>","date":"2025-10-28T15:03:19","subject":"Re: [PATCH] ipa: rpi: vd56g3: Fix frameIntegrationDiff value","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Benjamin,\n\nOn Tue, 28 Oct 2025 at 08:47, Benjamin Mugnier\n<benjamin.mugnier@foss.st.com> wrote:\n>\n> In the vd56g3 user manual :\n>\n>   MAX_EXPOSURE_COARSE = FRAME_LENGTH − EXP_COARSE_INTG_MARGIN − 7\n>   EXP_COARSE_INTG_MARGIN >= 68\n>\n> Therefore, frameIntegrationDiff is EXP_COARSE_INTG_MARGIN + 7, equals\n> 75. This value is coherent with the VD56G3_EXPOSURE_MARGIN in the kernel\n> driver source code.\n>\n> Reported-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>\n\nI'm a bit confused why the datasheet would not fold the 7 lines into\nEXP_COARSE_INTG_MARGIN?\nBut since these numbers are correct according to the datasheet,\n\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\n\n> ---\n>  src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp b/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp\n> index 140aabd802ad..8a58bc746711 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp\n> +++ b/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp\n> @@ -23,7 +23,7 @@ private:\n>          * Smallest difference between the frame length and integration time,\n>          * in units of lines.\n>          */\n> -       static constexpr int frameIntegrationDiff = 61;\n> +       static constexpr int frameIntegrationDiff = 75;\n>  };\n>\n>  CamHelperVd56g3::CamHelperVd56g3()\n> --\n> 2.25.1\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC041BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Oct 2025 15:04:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CF4CF607D9;\n\tTue, 28 Oct 2025 16:04:00 +0100 (CET)","from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com\n\t[IPv6:2607:f8b0:4864:20::e2c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE517606DE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Oct 2025 16:03:57 +0100 (CET)","by mail-vs1-xe2c.google.com with SMTP id\n\tada2fe7eead31-5db21dc0a3dso321646137.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Oct 2025 08:03:57 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"uALRQtxf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1761663837; x=1762268637;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=XdEQqSgdNm0LugRv+sTiv2IFbS6heKbYf7VmaDsQNyE=;\n\tb=uALRQtxfkDc7y7F7BA5n8ze4AdrwPhieUMIlyEYZoHFg585zN7yEwEPtiETIIGDsE9\n\t40pnCvo9WpCwFZrRYAcavjE2ux8XUeBclPvU+BuEcAtvYEto3pn4HlFAe9MK5cK1Qgg5\n\tnWx8xk+EoVEk716O2L8Gn7l5y+xVlKmkKFW88nNItsu5RKF7jZ2jVWUIJF6Eba0LtVaO\n\tJ9zXAbQRy3S7zihYsUV611imV/snqnU2Zym961kvXH+BNenIprFXm75GttZTuw9SR8Py\n\ttAe5y1XMHmZrxbYiLOFQLFIWcDK/eoMdY87A0TVDXncvXrN+H9XkwMFf7MQx8oncLgEr\n\t9AXQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1761663837; x=1762268637;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=XdEQqSgdNm0LugRv+sTiv2IFbS6heKbYf7VmaDsQNyE=;\n\tb=QPv5JPCHm8c3tDIw+E9K+88pZ7lor63rvpurZxMMJVCmlUR+mUFb9iRKj7mIcbjxVG\n\tAJqhpHl0mLsqHUnYbauPyYGKbLyVmQM6pR50ScS0K0SYwUNnMZCLfOz14A3m3fWWHMhS\n\t1kmXfaoVE87H3m5PdFEaCliudbd8sulXjOjCqImTSV0jcmxJVd6M2oSfZJH0Z3cLojrE\n\toE2Eu9PvF661YNkCHdKZMEM99bLltcoFgofCHESDcUzZugzffP28D4CELoYVhVyBzscE\n\tG71oxRRlAism3YI3d7juSfy2lixnFc9BtsGI9OhTUjNJMDvP5vHk1qdVatdbv+ZKXaoO\n\tU8Zg==","X-Gm-Message-State":"AOJu0Yyrl6jcOjX8oBufJ8psaVysAPA1I1zptAe05AEXSYWd+R2M5z6B\n\tB1ZAleFtA58/MDA4yGs2tzi9Gua5B7NNQakOMIVHRoYt1RDU0A226rKKuFhnD6D31Ckim0+noXV\n\tdfX6GSn7T9PFRH+NkdzaB3ZHZh6MIkErtd/ko5bp7fgGXLiz4ZsNCbck=","X-Gm-Gg":"ASbGncvB7KdrPcRsUUr/OJ2CcW3eic9ij4oW25oafm9MgdPmgR5EEvjNJDLEfWgVqY8\n\tZ/LwZhsSL60b2MY7xDlc21Z3XfBw8wPfDJHnZwA3THrPSi2IKHG0NQGQepduE5wZp/SG1m4vJRP\n\tSSG1c/YOvZuOpyXVwF/QHLYQY1J/UiinEHdYv03SllsricnV7inp7dYvw65F4FqxvB33Xdd9wf9\n\tN77Qpw7RsPlUDOD47N/dYxQv4gK63uqDsdKyvwRhhPWXiCoxyGDdgwyBIhS","X-Google-Smtp-Source":"AGHT+IFAzeQ4ZInh9EW71qhe3ID6AMlrCflPf1VH3gssJMivCAfrbful+uvrc4mS8VC10CnWiMGeUiAkVbrYJXA+aW8=","X-Received":"by 2002:a05:6102:1496:b0:5db:3585:78bf with SMTP id\n\tada2fe7eead31-5db7cb81ef5mr741943137.4.1761663835087; Tue, 28 Oct 2025\n\t08:03:55 -0700 (PDT)","MIME-Version":"1.0","References":"<20251028084650.13043-1-benjamin.mugnier@foss.st.com>","In-Reply-To":"<20251028084650.13043-1-benjamin.mugnier@foss.st.com>","From":"Naushir Patuck <naush@raspberrypi.com>","Date":"Tue, 28 Oct 2025 15:03:19 +0000","X-Gm-Features":"AWmQ_bnVd19PWYihXUiLXYM8UhCivrLWjAf4uHis29Sh4azXfACVppkj1Qt_lmU","Message-ID":"<CAEmqJPpJDdPV+whaauDFboUbNHoVyVhAq+sJAuPP5KHWE0U8rQ@mail.gmail.com>","Subject":"Re: [PATCH] ipa: rpi: vd56g3: Fix frameIntegrationDiff value","To":"Benjamin Mugnier <benjamin.mugnier@foss.st.com>","Cc":"libcamera-devel@lists.libcamera.org, \n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":36519,"web_url":"https://patchwork.libcamera.org/comment/36519/","msgid":"<fb1adb58-c964-4e7c-962a-a435ba1d05d1@foss.st.com>","date":"2025-10-28T15:23:31","subject":"Re: [PATCH] ipa: rpi: vd56g3: Fix frameIntegrationDiff value","submitter":{"id":227,"url":"https://patchwork.libcamera.org/api/people/227/","name":"Benjamin Mugnier","email":"benjamin.mugnier@foss.st.com"},"content":"Hi Naush,\n\nOn 10/28/25 16:03, Naushir Patuck wrote:\n> Hi Benjamin,\n> \n> On Tue, 28 Oct 2025 at 08:47, Benjamin Mugnier\n> <benjamin.mugnier@foss.st.com> wrote:\n>>\n>> In the vd56g3 user manual :\n>>\n>>   MAX_EXPOSURE_COARSE = FRAME_LENGTH − EXP_COARSE_INTG_MARGIN − 7\n>>   EXP_COARSE_INTG_MARGIN >= 68\n>>\n>> Therefore, frameIntegrationDiff is EXP_COARSE_INTG_MARGIN + 7, equals\n>> 75. This value is coherent with the VD56G3_EXPOSURE_MARGIN in the kernel\n>> driver source code.\n>>\n>> Reported-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n>> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>\n> \n> I'm a bit confused why the datasheet would not fold the 7 lines into\n> EXP_COARSE_INTG_MARGIN?\n> But since these numbers are correct according to the datasheet,\n\nI had the same surprise. Documentation writers choose not to merge the 7\ninto EXP_COARSE_INTG_MARGIN because in the firmware the sensor is\neffectively stopped for 7 lines, which differs from the integration time\nper se.\n\nHaving the 7 defined behind a constant may help the reading\n  MAX_EXPOSURE_COARSE = FRAME_LENGTH − EXP_COARSE_INTG_MARGIN −\nSENSOR_STOP_LINES\n\nWith SENSOR_STOP_LINES = 7. But we're talking about very specific stuff.\n\n> Reviewed-by: Naushir Patuck <naush@raspberrypi.com>\n> \n>> ---\n>>  src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp | 2 +-\n>>  1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp b/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp\n>> index 140aabd802ad..8a58bc746711 100644\n>> --- a/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp\n>> +++ b/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp\n>> @@ -23,7 +23,7 @@ private:\n>>          * Smallest difference between the frame length and integration time,\n>>          * in units of lines.\n>>          */\n>> -       static constexpr int frameIntegrationDiff = 61;\n>> +       static constexpr int frameIntegrationDiff = 75;\n>>  };\n>>\n>>  CamHelperVd56g3::CamHelperVd56g3()\n>> --\n>> 2.25.1\n>>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 102BDC3259\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Oct 2025 15:23:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 505F4607DB;\n\tTue, 28 Oct 2025 16:23:38 +0100 (CET)","from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com\n\t[185.132.182.106])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6FFF7606DE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Oct 2025 16:23:36 +0100 (CET)","from pps.filterd (m0241204.ppops.net [127.0.0.1])\n\tby mx07-00178001.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t59SF0Xd1488479; Tue, 28 Oct 2025 16:23:35 +0100","from db3pr0202cu003.outbound.protection.outlook.com\n\t(mail-northeuropeazon11010026.outbound.protection.outlook.com\n\t[52.101.84.26])\n\tby mx07-00178001.pphosted.com (PPS) with ESMTPS id 4a2w37gw4v-1\n\t(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); \n\tTue, 28 Oct 2025 16:23:35 +0100 (CET)","from DB8P191CA0006.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::16)\n\tby AM7PR10MB3207.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:104::15)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9253.18;\n\tTue, 28 Oct 2025 15:23:33 +0000","from DB5PEPF00014B9A.eurprd02.prod.outlook.com\n\t(2603:10a6:10:130:cafe::e0) by DB8P191CA0006.outlook.office365.com\n\t(2603:10a6:10:130::16) with Microsoft SMTP Server (version=TLS1_3,\n\tcipher=TLS_AES_256_GCM_SHA384) id 15.20.9253.18 via Frontend\n\tTransport; Tue, 28 Oct 2025 15:23:32 +0000","from smtpO365.st.com (164.130.1.43) by\n\tDB5PEPF00014B9A.mail.protection.outlook.com (10.167.8.167) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.9275.10 via Frontend Transport; Tue, 28 Oct 2025 15:23:32 +0000","from SHFDAG1NODE1.st.com (10.75.129.69) by smtpO365.st.com\n\t(10.250.44.66) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.57;\n\tTue, 28 Oct 2025 16:21:17 +0100","from [10.130.78.67] (10.130.78.67) by SHFDAG1NODE1.st.com\n\t(10.75.129.69) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.57;\n\tTue, 28 Oct 2025 16:23:31 +0100"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=foss.st.com header.i=@foss.st.com\n\theader.b=\"LSay7Vkg\"; dkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=bfQ5VTePwmsOYm0/o7weg3ZJL35yZLnoC1qPA1npRoABdv/HSkYxjOD/dCOPJ8vYT5yJTTc8CECtykwc+7DWRuWiaXXu2waK3JzHfu4aACoov88QqVzf8cxFI3OSGgTOeT9I0S8j5j1A42GWy9S2eWp7YrI5k+Z5b4oXPKKhL14D8Dgjn2jWz1+YLI8Q3TZ1Qow2aTOvBE4zCPeEg1u/36dmUA6g+L6tTMuiHagxewbGlcgchaYxDkbn+G1vHQZjnTX1FjT+UrSWbdi0BZD+Tcua9/gndRIShn7O1rNt8XDYVop+SZcPRJ5VirQWuee2c668bS7oObz77eug82MAkw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=WrSOX4CXYQ4AjmU7ylXBr3pR1Wp1lpThSurI8PyKKhg=;\n\tb=mHojMvnCxlG+e1N9H8LNYNfpPXMbe/n/e76KB9+0NVas84nyTjsIN4fhPG8OiZyDcUlQcDgEx+MMxMwhqy4lgeoyU6iFKF6QYBJJaUNj1+WGFe33D0oRWNF9f0qTVTPXAB6xQtWxNMBCsJWUxhBefJk5hnEIJ/SXgQyjTDD7B+8JNUBnTdjvJ4vy/Oiw6m3amAMKEdEWdmS7DPb5LwqVpLJsceof11Jh9rN1DhI3GrpuJYLbkCBT2rYVKSx/Db50IzuS85b6gu8SjMq5Vt+0M4FccMsE6s2GMsg1JrviDYc8cZ5Ma2svCh41skHYTcwFv9wV+TmkOm1R5rcqZQN1EQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=fail (sender ip is\n\t164.130.1.43) smtp.rcpttodomain=raspberrypi.com\n\tsmtp.mailfrom=foss.st.com; \n\tdmarc=fail (p=none sp=none pct=100) action=none\n\theader.from=foss.st.com; \n\tdkim=none (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com;\n\ts=selector2;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=WrSOX4CXYQ4AjmU7ylXBr3pR1Wp1lpThSurI8PyKKhg=;\n\tb=LSay7Vkgt6AzL/CgsXAM4us2vjjk8xQ06oG0fELmR1MX+cFuT6wux5KNNgFB0heStOCMxem2ZFX/C0XjRo5nS6wzerFflRzOYTvoEqkmAvoDynMbVOOwg+wqSvLhWeZ1c2o2uBOXqjduFM+xpJs+I7Vn87K9aV5cxKqSro90VnQhxiAsW5rJSkJzuu/Nm9YpZss8cOqLzLiayKPb8+OIcxFN7s+baj8xdkbAmfnymQyW8ugl7k2GJ9/brtWIqfcC9brL0sEdG424bJ2qAYu52VojruBsgXzTRhz8uTtH1jdkAMoykuONkC7JusEl7Tb+XtvT5I+TBJvDY+eUUFJhoQ==","X-MS-Exchange-Authentication-Results":"spf=fail (sender IP is 164.130.1.43)\n\tsmtp.mailfrom=foss.st.com; dkim=none (message not signed)\n\theader.d=none;dmarc=fail action=none header.from=foss.st.com;","Received-SPF":"Fail (protection.outlook.com: domain of foss.st.com does not\n\tdesignate 164.130.1.43 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=164.130.1.43; helo=smtpO365.st.com;","Message-ID":"<fb1adb58-c964-4e7c-962a-a435ba1d05d1@foss.st.com>","Date":"Tue, 28 Oct 2025 16:23:31 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] ipa: rpi: vd56g3: Fix frameIntegrationDiff value","To":"Naushir Patuck <naush@raspberrypi.com>","CC":"<libcamera-devel@lists.libcamera.org>, Jacopo Mondi\n\t<jacopo.mondi@ideasonboard.com>","References":"<20251028084650.13043-1-benjamin.mugnier@foss.st.com>\n\t<CAEmqJPpJDdPV+whaauDFboUbNHoVyVhAq+sJAuPP5KHWE0U8rQ@mail.gmail.com>","Content-Language":"en-US","From":"Benjamin Mugnier <benjamin.mugnier@foss.st.com>","In-Reply-To":"<CAEmqJPpJDdPV+whaauDFboUbNHoVyVhAq+sJAuPP5KHWE0U8rQ@mail.gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"8bit","X-Originating-IP":"[10.130.78.67]","X-ClientProxiedBy":"EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE1.st.com\n\t(10.75.129.69)","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DB5PEPF00014B9A:EE_|AM7PR10MB3207:EE_","X-MS-Office365-Filtering-Correlation-Id":"68150adc-9b2d-498c-ce65-08de1635f49f","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n\tARA:13230040|82310400026|36860700013|376014|1800799024|7053199007; ","X-Microsoft-Antispam-Message-Info":"=?utf-8?q?QNYqj9iQtaF145vQLw2UmFVyWIod?=\n\t=?utf-8?q?tLgrST9BEfZQ1FAh9i0QXW/k+aABShOH6t38OHlHwybONlcch81aLaGK?=\n\t=?utf-8?q?I78G8GzrakQydIAGo6sIEmhsXzt7A6mYWRL1uQbSJ0vSI+q8CwMp2W33?=\n\t=?utf-8?q?xvxvmUjwHHevg/QvoJ89JdCOhpsZrN9SB6BQljWL6SKkm0Jg5yOGwPVa?=\n\t=?utf-8?q?PrfAX9uqU5w/z0HLhZLLbgqxfeFbl4yz9bARj+wU7PspC6ZtDu9QAa8u?=\n\t=?utf-8?q?F/6zrxQkcM8PLpUZ3W3XUJbV4abGyxuxkBjTqx9fmha0vYxRxYjAuDN3?=\n\t=?utf-8?q?j0tQBSOI5o6GM8bBHcEJsPp8hB81t4IkX1TuNdMp+YYhpq+onw+iKHfT?=\n\t=?utf-8?q?8SAgrUV2G6LfAZL4gksWMw9zj4BfvZYdNfa+NTvXMMfhWLkBRKsYqiI5?=\n\t=?utf-8?q?BV/h1gIitUQpkh8YP+ozuopYmtFZO0uNHUyE5wXEww7xk68FScDt+kxE?=\n\t=?utf-8?q?XFwVoy7VZ052ctLJJolWLKb4cwqMFflFes/i/jHDdvIfryjLAJ2IQmuK?=\n\t=?utf-8?q?W42X2EPwgZnJ18Alb/yyKRlCyZCPARpExx9u4uWys7yogjgn7F8CABp4?=\n\t=?utf-8?q?3qCqf6zlkdsG0rU5hSa8DNX+XiEnPXzGSKnRvztQAMbFsjJZ5KZKtD6s?=\n\t=?utf-8?q?vGpEzqaNVNqf8+sngJyff+jdWlzUzf5IfR5mITIIjd1rdszm6xJABg+s?=\n\t=?utf-8?q?eK68OiLEQNNDTitlLts+ZjfWrSQT+NmwSm1hYPzgDzr9z22CtLTGo4b1?=\n\t=?utf-8?q?/LB06TJLGrNndvtQTA/szZbkhppcboUiO/AwWBGYq4TcfFs0pIF6JqZC?=\n\t=?utf-8?q?FrOQPzhYpzESX4N//rry1sQsUgFsxEubuYZRCIgRBWWBhlWEV8Xlry0S?=\n\t=?utf-8?q?W8YWloJkuGsAlcGiqkuh7AOekrGuHoCaK25n5CNb9QdfoinWzlkl7vor?=\n\t=?utf-8?q?vE+FtlDwm+1Xa65V9BsoVMaTGSLU3zqWcjx4lSVdIi8wfMHBBYkm1ybn?=\n\t=?utf-8?q?PvLiGgGqV70pQnYyNkt+PqE0YlLeP9CjD84rj18MuEwPhbD7QH0ZocNd?=\n\t=?utf-8?q?Dj6cykLqbKE1NPxRvCps4vmkQBBufR/I/JSfb/V8HtZCpCGGZrv/vERE?=\n\t=?utf-8?q?B6IBx7xs9XGpIAIBBkc2S3MlEp/NoE0teEgdctHapflSLJYKpANNDjDv?=\n\t=?utf-8?q?hFI2k6IFVHH+evbF97wu4ANuDihyW1muPfPhA8FJqpf/+LY/zuIxD1di?=\n\t=?utf-8?q?g0l66huVlX9RSsuHFc82fkXCFJ8OFCgXa5x3JKsJIn5kX9sDbkfa6jyk?=\n\t=?utf-8?q?2gUrBmU66p5BTf0rXtaDkZrlYTZFVM5Q+ktsHYFRKYzlxDZ3CfQf5sHt?=\n\t=?utf-8?q?75ZwxiDJsKNiqOWJIQz71cQKP/ojOSlYArW22RJFMtOQbGrlpPlaFzp0?=\n\t=?utf-8?q?+6G9gVqK1qlzkHcAQmjxc3A086eYmmAQbvt6yt92UOD30JR4aVuvmNMe?=\n\t=?utf-8?q?3GER/Gn/nXCo8zJHgm3HqKlAy7Tc0qXy5OIWjI2GO58vYHDht/AMre+4?=\n\t=?utf-8?q?NuNunnY7aPyW75fDYeeVGi6xui31u/Hn/viAFWDYxtYi/h/y9vfNUwwH?=\n\t=?utf-8?q?U40mc4ie4dJ2LPp8lfUgyO2W6lLU9CHtLQH6L0o=3D?=","X-Forefront-Antispam-Report":"CIP:164.130.1.43; CTRY:IT; LANG:en; SCL:1; SRV:;\n\tIPV:CAL; SFV:NSPM; H:smtpO365.st.com; PTR:InfoDomainNonexistent;\n\tCAT:NONE; \n\tSFS:(13230040)(82310400026)(36860700013)(376014)(1800799024)(7053199007);\n\tDIR:OUT; SFP:1101; ","X-OriginatorOrg":"foss.st.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"28 Oct 2025 15:23:32.5203\n\t(UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"68150adc-9b2d-498c-ce65-08de1635f49f","X-MS-Exchange-CrossTenant-Id":"75e027c9-20d5-47d5-b82f-77d7cd041e8f","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;\n\tIp=[164.130.1.43]; \n\tHelo=[smtpO365.st.com]","X-MS-Exchange-CrossTenant-AuthSource":"DB5PEPF00014B9A.eurprd02.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM7PR10MB3207","X-Proofpoint-GUID":"BQA8tZA34_XPvwVS6WV_ALJ0C1erG7UM","X-Authority-Analysis":"v=2.4 cv=bY1mkePB c=1 sm=1 tr=0 ts=6900dff7 cx=c_pps\n\ta=/z/ujZMLhdj11oxtLm6Teg==:117 a=peP7VJn1Wk7OJvVWh4ABVQ==:17\n\ta=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=WaRyL3-Hq7oA:10 a=IkcTkHD0fZMA:10\n\ta=x6icFKpwvdMA:10 a=s63m1ICgrNkA:10 a=KrXZwBdWH7kA:10\n\ta=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=P1BnusSwAAAA:8\n\ta=RF00TdSWAAAA:8\n\ta=Homf0S_khd6Ld92SFxwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10\n\ta=T3LWEMljR5ZiDmsYVIUa:22 a=D0XLA9XvdZm18NrgonBM:22\n\ta=_nx8FpPT0le-2JWwMI5O:22","X-Proofpoint-ORIG-GUID":"BQA8tZA34_XPvwVS6WV_ALJ0C1erG7UM","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjUxMDI4MDEyOSBTYWx0ZWRfX/xNpQiO/lLwQ\n\t+D/7pe2vv6u6CTo+0/5/yKQF+dNSJPDNB2yVqGZZcwQw+Knk2BLY4Yo3ijF/ivYhGWvn/LlxxrT\n\ttlixUhy4gTCp/BTVVOaVxrg5t8YP2f6ID4Cj5NMZ5yX+c5kfkut5xLIPpM1KbffLZ9nNP+1mTwL\n\tPesb2BZ8HcDJGMbQrrC5VkFbWaOtkruchjD5WD0gj+vT1zXwhUv7P/LaEJ7lk7IscMiqoWcldtS\n\tTWGOeDjKltF8rXkO5BOZDPUbbGPU27o+wi4PFuqVf+HUKFod8raMOpRbGya6zF64XRVdqTKWauY\n\tIRUYHURDLkYTdlPrEwseGB1zUrYYuLSYlhYEPipPq7bgjvsZHMX5Fqq4hAwjvzvWY8nHB4PTDk3\n\tg042v3Uq5DKmt2pKuRfo+m8nralRwg==","X-Proofpoint-Virus-Version":"vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.9,\n\tFMLib:17.12.80.40\n\tdefinitions=2025-10-28_05,2025-10-22_01,2025-03-28_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0\n\timpostorscore=0\n\tadultscore=0 clxscore=1015 bulkscore=0\n\tmalwarescore=0 phishscore=0\n\tlowpriorityscore=0 spamscore=0 suspectscore=0 priorityscore=1501\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2510020000\n\tdefinitions=main-2510280129","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]