{"id":2483,"url":"https://patchwork.libcamera.org/api/patches/2483/?format=json","web_url":"https://patchwork.libcamera.org/patch/2483/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200102235311.12009-1-laurent.pinchart@ideasonboard.com>","date":"2020-01-02T23:53:10","name":"[libcamera-devel,1/2] test: object-invoke: Test invocation of method taking a reference argument","commit_ref":"7141ac74fd282cfe62de1a61a1f0edaee3c14d8e","pull_url":null,"state":"accepted","archived":false,"hash":"6ed60d395669d1cc6358d048c8067da385874125","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2483/mbox/","series":[{"id":597,"url":"https://patchwork.libcamera.org/api/series/597/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=597","date":"2020-01-02T23:53:10","name":"[libcamera-devel,1/2] test: object-invoke: Test invocation of method taking a reference argument","version":1,"mbox":"https://patchwork.libcamera.org/series/597/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2483/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2483/checks/","tags":{},"headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51AEF60467\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  3 Jan 2020 00:53:25 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C1B3B516\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  3 Jan 2020 00:53:24 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1578009204;\n\tbh=uNqQmLSHAXsMLPj8HA5Fa4lkEHdR6JU16IO6QksnNaM=;\n\th=From:To:Subject:Date:From;\n\tb=lANtWYa+HgJ3q/38gbRU2ffk8wyb3D6LWoiYy6e9j58oEh21KXFsIB6Y8oRKgmOub\n\tEQKOwd/ZD7xM5bYKKCd1/292evT+jefU4lWo++0O2LMnys3WYUzzpjXvFeYEznkW1e\n\tOO+0nTHbwBSErukDvWC42gxqQnfFMgto1BOF4iDo=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri,  3 Jan 2020 01:53:10 +0200","Message-Id":"<20200102235311.12009-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] test: object-invoke: Test invocation\n\tof method taking a reference argument","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 02 Jan 2020 23:53:25 -0000"},"content":"Object::invokeMethod() fails with a compilation error when the invoked\nmethod takes a reference argument. Add a test case for this issue.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/object-invoke.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)","diff":"diff --git a/test/object-invoke.cpp b/test/object-invoke.cpp\nindex 560adee14e3a..f9a8bea9dce2 100644\n--- a/test/object-invoke.cpp\n+++ b/test/object-invoke.cpp\n@@ -49,6 +49,10 @@ public:\n \t\tvalue_ = value;\n \t}\n \n+\tvoid methodWithReference(const int &value)\n+\t{\n+\t}\n+\n private:\n \tStatus status_;\n \tint value_;\n@@ -119,6 +123,14 @@ protected:\n \t\t\treturn TestFail;\n \t\t}\n \n+\t\t/*\n+\t\t * Test invoking a method that takes reference arguments. This\n+\t\t * targets compilation, there's no need to check runtime\n+\t\t * results.\n+\t\t */\n+\t\tobject_.invokeMethod(&InvokedObject::methodWithReference,\n+\t\t\t\t     ConnectionTypeBlocking, 42);\n+\n \t\treturn TestPass;\n \t}\n \n","prefixes":["libcamera-devel","1/2"]}