[{"id":36526,"web_url":"https://patchwork.libcamera.org/comment/36526/","msgid":"<197433ce661bb1a55f1786e2745a75820b128733.camel@collabora.com>","date":"2025-10-28T16:14:37","subject":"Re: [PATCH v3 3/4] gstreamer: Improve logging for buffer pool\n\tactivation","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"Hi,\n\nLe samedi 25 octobre 2025 à 15:22 +0100, Umang Jain a écrit :\n> If the negotiation is going to fail, log the GST_ELEMENT_ERROR in\n> gst_libcamera_src_negotiate(), instead of logging in downstream method\n> chain.\n> \n> Signed-off-by: Umang Jain \n> Reviewed-by: Nicolas Dufresne \n> Reviewed-by: Barnabás Pőcze \n> ---\n>  src/gstreamer/gstlibcamerasrc.cpp | 10 ++++++----\n>  1 file changed, 6 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp\n> b/src/gstreamer/gstlibcamerasrc.cpp\n> index a3c48b1d..7bf42be2 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -575,9 +575,7 @@ gst_libcamera_create_video_pool(GstLibcameraSrc *self,\n> GstPad *srcpad,\n>  \t}\n>  \n>  \tif (!gst_buffer_pool_set_active(pool, true)) {\n> -\t\tGST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,\n> -\t\t\t\t  (\"Failed to active buffer pool\"),\n> -\t\t\t\t  (\"gst_libcamera_src_negotiate() failed.\"));\n> +\t\tGST_ERROR_OBJECT(self, \"Failed to activate buffer pool.\");\n\nThis is redundant now, drop.\n\nNicolas\n\n>  \t\treturn { nullptr, -EINVAL };\n>  \t}\n>  \n> @@ -680,8 +678,12 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)\n>  \t\t\tstd::tie(video_pool, ret) =\n>  \t\t\t\tgst_libcamera_create_video_pool(self, srcpad,\n>  \t\t\t\t\t\t\t\tcaps, &info);\n> -\t\t\tif (ret)\n> +\t\t\tif (ret) {\n> +\t\t\t\tGST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,\n> +\t\t\t\t\t\t  (\"Failed to create video\n> pool: %s\", g_strerror(-ret)),\n> +\t\t\t\t\t\t \n> (\"gst_libcamera_src_negotiate() failed.\"));\n>  \t\t\t\treturn false;\n> +\t\t\t}\n>  \t\t}\n>  \n>  \t\tGstLibcameraPool *pool = gst_libcamera_pool_new(self-\n> >allocator,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7698DC3259\n\tfor ;\n\tTue, 28 Oct 2025 16:16:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ABD73607F3;\n\tTue, 28 Oct 2025 17:16:52 +0100 (CET)","from bali.collaboradmins.com (bali.collaboradmins.com\n\t[IPv6:2a01:4f8:201:9162::2])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BDDB7606DE\n\tfor ;\n\tTue, 28 Oct 2025 17:16:50 +0100 (CET)","from [192.168.11.9] (ip-217-65-134-16.ptr.icomera.net\n\t[217.65.134.16])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256)\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bali.collaboradmins.com (Postfix) with ESMTPSA id 3C4FE17E139C;\n\tTue, 28 Oct 2025 17:16:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=collabora.com header.i=@collabora.com\n\theader.b=\"J4aVrh6P\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;\n\ts=mail; t=1761668210;\n\tbh=O2gWfja+9NbuQUiZFxbAGcGLRv5l17UVPgItwD0vHU4=;\n\th=Subject:From:To:Cc:Date:In-Reply-To:References:From;\n\tb=J4aVrh6PWIMQ0LcN6lBsREQT1830IjQca8kdFdl1hxI9JmfUhjxTWBGtAnjdYLcLf\n\t7UgQCANtdg3ZUGRNPP7FnHdN5yrro1YfY1elq4H87TgmWHNhopcLLGvNjgJ673YkUf\n\t3uM004GXIMCx8ZvA6OKKrkCFq5aLVRrzaLMONdEGECoUl+rwZwYmPIKfExNk24kT7m\n\talCocfREEZAO7qWYf2x4TXxoA685njn9u1HuTvR03WCa0s0vzZLkRRFbjWBUYJALC5\n\t2jtWfdslghdH0cRrmTr/NgG2Joq3gUEDi1Hj808OVqZjnK9lhbxbtdgqNMwDWQo6Do\n\tINSmIOI+FPo8g==","Message-ID":"<197433ce661bb1a55f1786e2745a75820b128733.camel@collabora.com>","Subject":"Re: [PATCH v3 3/4] gstreamer: Improve logging for buffer pool\n\tactivation","From":"Nicolas Dufresne ","To":"Umang Jain , libcamera-devel@lists.libcamera.org","Cc":"barnabas.pocze@ideasonboard.com","Date":"Tue, 28 Oct 2025 16:14:37 +0000","In-Reply-To":"<20251025142300.64480-4-uajain@igalia.com>","References":"<20251025142300.64480-1-uajain@igalia.com>\n\t<20251025142300.64480-4-uajain@igalia.com>","Autocrypt":"addr=nicolas.dufresne@collabora.com; prefer-encrypt=mutual;\n\tkeydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD\n\t/e0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPoicBBMWCgBEAhsDBQsJCA\n\tcCAiICBhUKCQgLAgQWAgMBAh4HAheABQkJZfd1FiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrjo\n\tCGQEACgkQ2UGUUSlgcvQlQwD/RjpU1SZYcKG6pnfnQ8ivgtTkGDRUJ8gP3fK7+XUjRNIA/iXfhXMN\n\tabIWxO2oCXKf3TdD7aQ4070KO6zSxIcxgNQFtDFOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1Z\n\tnJlc25lQGNvbGxhYm9yYS5jb20+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4\n\tAWIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyyxgUJCWX3dQAKCRDZQZRRKWBy9ARJAP96pFmLffZ\n\tsmBUpkyVBfFAf+zq6BJt769R0al3kHvUKdgD9G7KAHuioxD2v6SX7idpIazjzx8b8rfzwTWyOQWHC\n\tAAS0LU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPoiZBBMWCgBBF\n\tiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrGYCGwMFCQll93UFCwkIBwICIgIGFQoJCAsCBBYCAw\n\tECHgcCF4AACgkQ2UGUUSlgcvRObgD/YnQjfi4+L8f4fI7p1pPMTwRTcaRdy6aqkKEmKsCArzQBAK8\n\tbRLv9QjuqsE6oQZra/RB4widZPvphs78H0P6NmpIJ","Organization":"Collabora Canada","Content-Type":"multipart/signed; micalg=\"pgp-sha512\";\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"=-RcjQGX9QM1IbICZTbn7D\"","User-Agent":"Evolution 3.56.2 (3.56.2-2.fc42) ","MIME-Version":"1.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]