[{"id":36525,"web_url":"https://patchwork.libcamera.org/comment/36525/","msgid":"<73b66568b88cb459f0d36810dd7cccd6f5b04451.camel@collabora.com>","date":"2025-10-28T16:11:07","subject":"Re: [PATCH v3 1/4] gstreamer: Shorten function name","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"Hi,\n\nLe samedi 25 octobre 2025 à 15:22 +0100, Umang Jain a écrit :\n> Shorten the following utility function name:\n> \tgst_libcamera_stream_configuration_to_caps()\n> to\n> \tgst_libcamera_stream_cfg_to_caps()\n> \n> Comestic fix only for slight readability enhancement.\n> \n> Signed-off-by: Umang Jain \n> Reviewed-by: Barnabás Pőcze \n> Reviewed-by: Nicolas Dufresne \n\nDidn't Laurent voted to remove this one ? Please agree with him first, my\npreference was also aligned to Laurent on this one.\n\nNicolas\n\n> ---\n>  src/gstreamer/gstlibcamera-utils.cpp | 4 ++--\n>  src/gstreamer/gstlibcamera-utils.h   | 4 ++--\n>  src/gstreamer/gstlibcamerasrc.cpp    | 4 ++--\n>  3 files changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp\n> b/src/gstreamer/gstlibcamera-utils.cpp\n> index bfb094c9..09f274b5 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -408,8 +408,8 @@ gst_libcamera_stream_formats_to_caps(const StreamFormats\n> &formats)\n>  }\n>  \n>  GstCaps *\n> -gst_libcamera_stream_configuration_to_caps(const StreamConfiguration\n> &stream_cfg,\n> -\t\t\t\t\t   GstVideoTransferFunction transfer)\n> +gst_libcamera_stream_cfg_to_caps(const StreamConfiguration &stream_cfg,\n> +\t\t\t\t GstVideoTransferFunction transfer)\n>  {\n>  \tGstCaps *caps = gst_caps_new_empty();\n>  \tGstStructure *s = bare_structure_from_format(stream_cfg.pixelFormat);\n> diff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-\n> utils.h\n> index 35df56fb..06ea9289 100644\n> --- a/src/gstreamer/gstlibcamera-utils.h\n> +++ b/src/gstreamer/gstlibcamera-utils.h\n> @@ -16,8 +16,8 @@\n>  #include \n>  \n>  GstCaps *gst_libcamera_stream_formats_to_caps(const libcamera::StreamFormats\n> &formats);\n> -GstCaps *gst_libcamera_stream_configuration_to_caps(const\n> libcamera::StreamConfiguration &stream_cfg,\n> -\t\t\t\t\t\t    GstVideoTransferFunction\n> transfer);\n> +GstCaps *gst_libcamera_stream_cfg_to_caps(const\n> libcamera::StreamConfiguration &stream_cfg,\n> +\t\t\t\t\t  GstVideoTransferFunction transfer);\n>  void gst_libcamera_configure_stream_from_caps(libcamera::StreamConfiguration\n> &stream_cfg,\n>  \t\t\t\t\t      GstCaps *caps,\n> GstVideoTransferFunction *transfer);\n>  void gst_libcamera_get_framerate_from_caps(GstCaps *caps, GstStructure\n> *element_caps);\n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp\n> b/src/gstreamer/gstlibcamerasrc.cpp\n> index 011a12fc..a1556cc5 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -639,7 +639,7 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)\n>  \t\tGstPad *srcpad = state->srcpads_[i];\n>  \t\tconst StreamConfiguration &stream_cfg = state->config_-\n> >at(i);\n>  \n> -\t\tg_autoptr(GstCaps) caps =\n> gst_libcamera_stream_configuration_to_caps(stream_cfg, transfer[i]);\n> +\t\tg_autoptr(GstCaps) caps =\n> gst_libcamera_stream_cfg_to_caps(stream_cfg, transfer[i]);\n>  \t\tgst_libcamera_framerate_to_caps(caps, element_caps);\n>  \n>  \t\tif (status == CameraConfiguration::Adjusted &&\n> @@ -667,7 +667,7 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)\n>  \t\tGstBufferPool *video_pool = nullptr;\n>  \t\tGstVideoInfo info;\n>  \n> -\t\tg_autoptr(GstCaps) caps =\n> gst_libcamera_stream_configuration_to_caps(stream_cfg, transfer[i]);\n> +\t\tg_autoptr(GstCaps) caps =\n> gst_libcamera_stream_cfg_to_caps(stream_cfg, transfer[i]);\n>  \n>  \t\tgst_video_info_from_caps(&info, caps);\n>  \t\tgst_libcamera_pad_set_video_info(srcpad, &info);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5FBDFBE080\n\tfor ;\n\tTue, 28 Oct 2025 16:12:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C9745607E0;\n\tTue, 28 Oct 2025 17:12:25 +0100 (CET)","from bali.collaboradmins.com (bali.collaboradmins.com\n\t[148.251.105.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF61D606DE\n\tfor ;\n\tTue, 28 Oct 2025 17:12:23 +0100 (CET)","from [192.168.11.9] (ip-217-65-134-16.ptr.icomera.net\n\t[217.65.134.16])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256)\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bali.collaboradmins.com (Postfix) with ESMTPSA id 055DE17E1276;\n\tTue, 28 Oct 2025 17:11:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=collabora.com header.i=@collabora.com\n\theader.b=\"ouG6Qa9c\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;\n\ts=mail; t=1761667943;\n\tbh=8MJMtzI4X+IidJxXhjElMGgd5ZFBA2SCNhTsWoD/2Sw=;\n\th=Subject:From:To:Cc:Date:In-Reply-To:References:From;\n\tb=ouG6Qa9cMbpJJ0rVyKwMAhpGOQLtjTHC1qk8rVAGUX8JnO6Pl/6kqZAYTRyc4z8JB\n\tsrrzBt+oORPPt5i3DbgV5/MzcpYSz37XZlvPlDCElFUug4iAdZ6oroEo2yh1R/SL3F\n\td8/NesrsW7ptDnn0qrzt7UGwcBpH9iVmh+1Q2JEJY3yD4oBWqhZaHsraj6+Vl7kHct\n\tDY/Z2tq1Cq3r06XXHNbzLKDWC1fYsLhio3jjwxow9NXNI1TOEiGl3eHsXIr256GsKF\n\tPUzoGyy58XP8rD/wyYKCmQNRON9mLUl/zd0EUvq8xet1+LndAtKhVEDeq0IBpCPmfE\n\tIcmjFuzebIgPA==","Message-ID":"<73b66568b88cb459f0d36810dd7cccd6f5b04451.camel@collabora.com>","Subject":"Re: [PATCH v3 1/4] gstreamer: Shorten function name","From":"Nicolas Dufresne ","To":"Umang Jain , libcamera-devel@lists.libcamera.org","Cc":"barnabas.pocze@ideasonboard.com","Date":"Tue, 28 Oct 2025 16:11:07 +0000","In-Reply-To":"<20251025142300.64480-2-uajain@igalia.com>","References":"<20251025142300.64480-1-uajain@igalia.com>\n\t<20251025142300.64480-2-uajain@igalia.com>","Autocrypt":"addr=nicolas.dufresne@collabora.com; prefer-encrypt=mutual;\n\tkeydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD\n\t/e0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPoicBBMWCgBEAhsDBQsJCA\n\tcCAiICBhUKCQgLAgQWAgMBAh4HAheABQkJZfd1FiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrjo\n\tCGQEACgkQ2UGUUSlgcvQlQwD/RjpU1SZYcKG6pnfnQ8ivgtTkGDRUJ8gP3fK7+XUjRNIA/iXfhXMN\n\tabIWxO2oCXKf3TdD7aQ4070KO6zSxIcxgNQFtDFOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1Z\n\tnJlc25lQGNvbGxhYm9yYS5jb20+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4\n\tAWIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyyxgUJCWX3dQAKCRDZQZRRKWBy9ARJAP96pFmLffZ\n\tsmBUpkyVBfFAf+zq6BJt769R0al3kHvUKdgD9G7KAHuioxD2v6SX7idpIazjzx8b8rfzwTWyOQWHC\n\tAAS0LU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPoiZBBMWCgBBF\n\tiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrGYCGwMFCQll93UFCwkIBwICIgIGFQoJCAsCBBYCAw\n\tECHgcCF4AACgkQ2UGUUSlgcvRObgD/YnQjfi4+L8f4fI7p1pPMTwRTcaRdy6aqkKEmKsCArzQBAK8\n\tbRLv9QjuqsE6oQZra/RB4widZPvphs78H0P6NmpIJ","Organization":"Collabora Canada","Content-Type":"multipart/signed; micalg=\"pgp-sha512\";\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"=-EcPJqUqck0/s06YKBrr3\"","User-Agent":"Evolution 3.56.2 (3.56.2-2.fc42) ","MIME-Version":"1.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]