[{"id":37251,"web_url":"https://patchwork.libcamera.org/comment/37251/","msgid":"","date":"2025-12-10T14:12:41","subject":"Re: [PATCH 4/4] ipa: rpi: controller: Ignore algorithms starting\n\twith disable","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nOn Fri, 24 Oct 2025 at 15:41, David Plowman\n wrote:\n>\n> From: Peter Bailey \n>\n> Prevent an algorithm starting with \"disable\" from being loaded.\n>\n> Signed-off-by: Peter Bailey \n> ---\n> src/ipa/rpi/controller/controller.cpp | 6 ++++++\n> 1 file changed, 6 insertions(+)\n>\n> diff --git a/src/ipa/rpi/controller/controller.cpp b/src/ipa/rpi/controller/controller.cpp\n> index df45dcd3..5eee0693 100644\n> --- a/src/ipa/rpi/controller/controller.cpp\n> +++ b/src/ipa/rpi/controller/controller.cpp\n> @@ -145,6 +145,12 @@ int Controller::read(char const *filename)\n>\n> int Controller::createAlgorithm(const std::string &name, const YamlObject ¶ms)\n> {\n> + if (name.find(\"disable\") == 0) {\n\nIs it worth using name.find(\"blah\") != std::string::npos here so we\ncan also do \"rpi.nn_awb.disable\"?\n\nWith or without that\n\nReviewed-by: Naushir Patuck \n\n\n> + LOG(RPiController, Debug)\n> + << \"Algorithm \\\"\" << name << \"\\\" is disabled\";\n> + return 0;\n> + }\n> +\n> auto it = getAlgorithms().find(name);\n> if (it == getAlgorithms().end()) {\n> LOG(RPiController, Warning)\n> --\n> 2.47.3\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56A17C3257\n\tfor ;\n\tWed, 10 Dec 2025 14:13:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F19F661480;\n\tWed, 10 Dec 2025 15:13:20 +0100 (CET)","from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com\n\t[IPv6:2607:f8b0:4864:20::e2d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59C3D613CB\n\tfor ;\n\tWed, 10 Dec 2025 15:13:19 +0100 (CET)","by mail-vs1-xe2d.google.com with SMTP id\n\tada2fe7eead31-5dfb6430553so361120137.3\n\tfor ;\n\tWed, 10 Dec 2025 06:13:19 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"jwTj4bY+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1765375998; x=1765980798;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=CujS0gvV0lMM7CQbScvBfV+HtajG1ezq1MgMCH+829c=;\n\tb=jwTj4bY+x8h0BKBw/GsdEqUzTBqwFX0O3jQ5kitZoJZFKP58vUIwkWEnCtUKY9fnJm\n\tWub71ilXM+O76dlSqjD8XkOKFSHd8WhKuUyC2a9/RPJiNr9meYB/KSM6luNu+5lQjWEI\n\tPVX9QoWikhprhFCRtAvuyEhch6Yj0jlQGIx91M1DYmVk+FrMjKAwWaFM3Qp8oZYGHIOP\n\tAjqUTyC7B8PdO0rK7NnZxeQWMxz7vRuM7/SnTbPgVucL6E9XY0yFDY51DalCSeJ7Q7pj\n\tlZqqQlKFyZwkUBbHO+2nt1HbEd295AYnpSRA260/6dQiaiMh8pbRsSKPxql88geohxmt\n\tliKg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765375998; x=1765980798;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=CujS0gvV0lMM7CQbScvBfV+HtajG1ezq1MgMCH+829c=;\n\tb=Rb/qdz1CKSw6qYzCXEuoY4b7vmbDQGjZT3v+wJqdY1JR/6qq7ndZA8JpYMbUNs/GE8\n\thZUZIPS7/fbDZWv70YIdlHYhlSJDCjeW3FEAjZI5wsdDTPbmu9YxIDJUWwltaA2uJ94n\n\totx9UcuIW1D9/t40M548AwSahdcpCIdusZl4DI65g8B8GlwKLMiOEScB0psrAl9zJOgB\n\tzw1UbWEiazZl1ub6XrRTEVR5Ul+Y4zOkFzs5yUD1CeyNmc3Wr/2NSfso2jqd0pxl3HX8\n\tGLJ/yaTljfxkPUUF+IZLRp+CnRPYS4aA+tAMxRt3WoBZ7yysKKw2QbjVVXOXYIBR0aiV\n\tUirg==","X-Gm-Message-State":"AOJu0Yw1xEJcNfYp4BzZmiZ5D+KnUd39dJgxYp559m70B67LY+W8yaAm\n\tfh2j2xVX2xmwjv86kW+IFK1TxqqZa0PxcoXKdn7pXMdBNiL7lEhKtmACPIi4OKHXjfKN2iu952W\n\tgUZfHBQ+OxFFa7h4Wy8AA2XeFtqm+9cJM4HqKWKMs/Q==","X-Gm-Gg":"AY/fxX52u3iEyrk13jw86M1M5aQTUbNLH0Of6178+lFFB7ul6UUR7qEXDtMOFdjDC5s\n\tAW0QaITB0fmFNaq5BhY+AkrEh1jK0VSZAo3lLftA+tpd7yj4BkEWhh0152J4qzHZtPBaVgRMPDj\n\tRZqd4GXZmxb+/e/m/MsoOWoyrEI4GGmoX2MpIH4UUgtC6lKUMPEQPNS2Co0ICs7B6IZpu7HAYON\n\trclpJXFp0lgNe/bCCLwCJo6gNtyIeVAJL/p0MCcLt+77ARYJSW+x70jFW/2BtzFV3dTSCxym1M4\n\tnHvjR9/9rvSTQPAYh/MDoF3Zang=","X-Google-Smtp-Source":"AGHT+IEkinO9dnaLFN7VGwQ1jE5/wHl6SN1yIb7k5T/jqOArVxFgiS77tHhBU481H7DBsm3I/tnSD9Jz2keMl3kEOio=","X-Received":"by 2002:a05:6102:c4c:b0:5e4:9555:8984 with SMTP id\n\tada2fe7eead31-5e571f1cca4mr406451137.6.1765375998186; Wed, 10 Dec 2025\n\t06:13:18 -0800 (PST)","MIME-Version":"1.0","References":"<20251024144049.3311-1-david.plowman@raspberrypi.com>\n\t<20251024144049.3311-5-david.plowman@raspberrypi.com>","In-Reply-To":"<20251024144049.3311-5-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Wed, 10 Dec 2025 14:12:41 +0000","X-Gm-Features":"AQt7F2p0vjRTvYe6O8VkEYkDlkTWcQpoXEB8ABknAKSqStVCY-5RY12a0HAgAAI","Message-ID":"","Subject":"Re: [PATCH 4/4] ipa: rpi: controller: Ignore algorithms starting\n\twith disable","To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org, \n\tPeter Bailey ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37266,"web_url":"https://patchwork.libcamera.org/comment/37266/","msgid":"","date":"2025-12-10T16:47:36","subject":"Re: [PATCH 4/4] ipa: rpi: controller: Ignore algorithms starting\n\twith disable","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 10. 24. 16:16 keltezéssel, David Plowman írta:\n> From: Peter Bailey \n> \n> Prevent an algorithm starting with \"disable\" from being loaded.\n> \n> Signed-off-by: Peter Bailey \n> ---\n\nA similar feature has been introduced to libipa recentl; maybe it could\nmake sense to have them both work the same way: https://patchwork.libcamera.org/patch/25151/\n\nThe difference currently is that the libipa variant checks the \"enabled\"\nalgorithm parameter, not the name.\n\n\nRegards,\nBarnabás Pőcze\n\n> src/ipa/rpi/controller/controller.cpp | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/src/ipa/rpi/controller/controller.cpp b/src/ipa/rpi/controller/controller.cpp\n> index df45dcd3..5eee0693 100644\n> --- a/src/ipa/rpi/controller/controller.cpp\n> +++ b/src/ipa/rpi/controller/controller.cpp\n> @@ -145,6 +145,12 @@ int Controller::read(char const *filename)\n> \n> int Controller::createAlgorithm(const std::string &name, const YamlObject ¶ms)\n> {\n> +\tif (name.find(\"disable\") == 0) {\n> +\t\tLOG(RPiController, Debug)\n> +\t\t\t<< \"Algorithm \\\"\" << name << \"\\\" is disabled\";\n> +\t\treturn 0;\n> +\t}\n> +\n> \tauto it = getAlgorithms().find(name);\n> \tif (it == getAlgorithms().end()) {\n> \t\tLOG(RPiController, Warning)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5E754BD1F1\n\tfor ;\n\tWed, 10 Dec 2025 16:47:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 64236614A6;\n\tWed, 10 Dec 2025 17:47:43 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A814061499\n\tfor ;\n\tWed, 10 Dec 2025 17:47:42 +0100 (CET)","from [192.168.33.37] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1033B10C4;\n\tWed, 10 Dec 2025 17:47:39 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hbgi+/cu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765385261;\n\tbh=bY9myb3AXEai0SnQFZHEirnKnaMDtwwfYbiXZKqOszs=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=hbgi+/culCr2efbqmgZrBBOAFlIqc/c++8SrBxmJkwX+6tI+F9v/qr+S52y+TTU0d\n\t6gCruF5srN+trTL3esqHL/dzN/4JjK2rh7Vu8Qx/gSeh3QhpcoMGn6ABjjsRper5Vf\n\tKTWMMf1Zgks7PqCOdv7QnLLH7JuHQ968MnnrMGxg=","Message-ID":"","Date":"Wed, 10 Dec 2025 17:47:36 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 4/4] ipa: rpi: controller: Ignore algorithms starting\n\twith disable","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Peter Bailey ","References":"<20251024144049.3311-1-david.plowman@raspberrypi.com>\n\t<20251024144049.3311-5-david.plowman@raspberrypi.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251024144049.3311-5-david.plowman@raspberrypi.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37286,"web_url":"https://patchwork.libcamera.org/comment/37286/","msgid":"","date":"2025-12-11T07:47:36","subject":"Re: [PATCH 4/4] ipa: rpi: controller: Ignore algorithms starting\n\twith disable","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Barnabás,\n\nOn Wed, 10 Dec 2025 at 16:47, Barnabás Pőcze\n wrote:\n>\n> Hi\n>\n> 2025. 10. 24. 16:16 keltezéssel, David Plowman írta:\n> > From: Peter Bailey \n> >\n> > Prevent an algorithm starting with \"disable\" from being loaded.\n> >\n> > Signed-off-by: Peter Bailey \n> > ---\n>\n> A similar feature has been introduced to libipa recentl; maybe it could\n> make sense to have them both work the same way: https://patchwork.libcamera.org/patch/25151/\n>\n> The difference currently is that the libipa variant checks the \"enabled\"\n> algorithm parameter, not the name.\n\nThis looks like a good solution, I'm ok to change this to match.\nDavid, what do you think?\n\nNaush\n\n>\n>\n> Regards,\n> Barnabás Pőcze\n>\n> > src/ipa/rpi/controller/controller.cpp | 6 ++++++\n> > 1 file changed, 6 insertions(+)\n> >\n> > diff --git a/src/ipa/rpi/controller/controller.cpp b/src/ipa/rpi/controller/controller.cpp\n> > index df45dcd3..5eee0693 100644\n> > --- a/src/ipa/rpi/controller/controller.cpp\n> > +++ b/src/ipa/rpi/controller/controller.cpp\n> > @@ -145,6 +145,12 @@ int Controller::read(char const *filename)\n> >\n> > int Controller::createAlgorithm(const std::string &name, const YamlObject ¶ms)\n> > {\n> > + if (name.find(\"disable\") == 0) {\n> > + LOG(RPiController, Debug)\n> > + << \"Algorithm \\\"\" << name << \"\\\" is disabled\";\n> > + return 0;\n> > + }\n> > +\n> > auto it = getAlgorithms().find(name);\n> > if (it == getAlgorithms().end()) {\n> > LOG(RPiController, Warning)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E6E1C3257\n\tfor ;\n\tThu, 11 Dec 2025 07:48:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BDE5B61511;\n\tThu, 11 Dec 2025 08:48:15 +0100 (CET)","from mail-ua1-x930.google.com (mail-ua1-x930.google.com\n\t[IPv6:2607:f8b0:4864:20::930])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DFF5A606D5\n\tfor ;\n\tThu, 11 Dec 2025 08:48:13 +0100 (CET)","by mail-ua1-x930.google.com with SMTP id\n\ta1e0cc1a2514c-937232a3b0cso16230241.3\n\tfor ;\n\tWed, 10 Dec 2025 23:48:13 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Ak6+oTeg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1765439292; x=1766044092;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=aw61jF878eUzLGBLJqHCqhdVBGx8IeTef4UNjidpPUM=;\n\tb=Ak6+oTeg1T0eT0gjFcJ0ES/cqBdB2D62aWXb+GCCFBEyebcOzr/U2vWL/b1REM45n8\n\tG1ye20kChlUr3k+fIvCe1r1i4NV0N4MR66iGC0sn00ol4q1M9IenNivuaaMez9+n1bL0\n\t8yIGQP3YY5768W6tP3syDl+NOTGq27dMZmBZTSnfZLebcjG85ceXRX3/cYff79fU7M86\n\tlrxj23oSGEy531zx8xxzIxprq94PYUEUUeq2n7H4Izg0/OLuQWMShC7BpaZe0eCiDI+S\n\t8Vvp2Chn0aVzsHSZ1Re+zAAz+EaMfQDezB3mZ54FmS3X5flZKWKmxJY25yvOcmVUN0Tq\n\tI6ug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765439292; x=1766044092;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=aw61jF878eUzLGBLJqHCqhdVBGx8IeTef4UNjidpPUM=;\n\tb=XpLAqxhjruNzX4aziUw00aPRanTWGM//F4uZBKyiA/7FH6CqHELxLjc+5nm+C4zdsf\n\tMen//UXvP+pTVb7JTQA9ivR6/p0hIu2SnR8FOjPpS4tC9KUqcqfXMIWGMJ+Og4LSBVaD\n\tqB/OCz9gRG8p+ahQEZdhzXRdC6bDyTzh5BA+dviNPTDmOM8dcbqfUS5g/tgAHxv+boiE\n\tvy3Ro12+Bw2TRtjxJhFb0ZOeVUfkpbB5D80FF+T01mRYeApgYBsIwrhehFEVHYLBWN62\n\tEbYTxNipiP2k2GnRSaWuqrzKmAiEY8SUI4g2ZRgLtljOkFfcUMTV9x9mtxpsSAuTqumS\n\tmiOQ==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCUXQ6d7qxuwuK1w2REy0i92RlkK972dYaFfn7dceBx6pJ3sOtusFPlmn/S6bdYpzuuOp6cTRMA76Zg8toIBdSc=@lists.libcamera.org","X-Gm-Message-State":"AOJu0Yx6vq2tMcR1xzgpLq56ufBDgGpQauxmeub+AvkDH+rjgf72j7Af\n\tGsHoRzQSsZrQD9g+wbZ/783zl5zIjcL2IOd9DCw6xJMU6U/kPhsk0xOos7PEbvxYZwwl+AXrmn4\n\tXk1pyGIMRh1/80tFUJVe1ULgU6PmhvXYXVFfs1+DnUg==","X-Gm-Gg":"AY/fxX7UjtFaNMkcMqEMKjxfaCkEiifDtz/icW2bITa+yTveV2XJhUVItYir9wKp2sx\n\tRot4O83VzO2Bz7BOAvq/f+fHVnOsgAii1LCSXH44kUR2/gpjHnuHiFaYEHmqBr6Jc6nkLb6PT0V\n\tdmIOeEEfauoLSUN8UPTd120LDnU5IsjmgB8T9sO1PTxS3hE6OFWg08hM7GZaUmZrAkGSJyDIEVy\n\tRWklP2jLyfYABenmGateqD/PZqGviKq8qc+03znbgh/pMZ9vyEiEgcw8lvgqfJxjAATxLoG5eCo\n\tvc7VjGq6QcLbDj6EAvebHpsU5uA=","X-Google-Smtp-Source":"AGHT+IEyaok1kd95UcNVBzDEvE598qAN6R6bri5tXryMeEB32KhSZMfcgADBmpMf6t55VTVRNyhkP8hwA/EDIljEikE=","X-Received":"by 2002:a05:6102:3fa8:b0:5df:af0f:309b with SMTP id\n\tada2fe7eead31-5e572287614mr1060046137.5.1765439292482;\n\tWed, 10 Dec 2025 23:48:12 -0800 (PST)","MIME-Version":"1.0","References":"<20251024144049.3311-1-david.plowman@raspberrypi.com>\n\t<20251024144049.3311-5-david.plowman@raspberrypi.com>\n\t","In-Reply-To":"","From":"Naushir Patuck ","Date":"Thu, 11 Dec 2025 07:47:36 +0000","X-Gm-Features":"AQt7F2pnunIt2uk2ZrYnEWJjAIceKzlaxYpvjZ7GXNMLwqcL59q-NkVVGQt8t4k","Message-ID":"","Subject":"Re: [PATCH 4/4] ipa: rpi: controller: Ignore algorithms starting\n\twith disable","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org, \n\tPeter Bailey ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37300,"web_url":"https://patchwork.libcamera.org/comment/37300/","msgid":"","date":"2025-12-11T11:28:02","subject":"Re: [PATCH 4/4] ipa: rpi: controller: Ignore algorithms starting\n\twith disable","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the review!\n\nOn Wed, 10 Dec 2025 at 14:13, Naushir Patuck wrote:\n>\n> Hi David,\n>\n> On Fri, 24 Oct 2025 at 15:41, David Plowman\n> wrote:\n> >\n> > From: Peter Bailey \n> >\n> > Prevent an algorithm starting with \"disable\" from being loaded.\n> >\n> > Signed-off-by: Peter Bailey \n> > ---\n> > src/ipa/rpi/controller/controller.cpp | 6 ++++++\n> > 1 file changed, 6 insertions(+)\n> >\n> > diff --git a/src/ipa/rpi/controller/controller.cpp b/src/ipa/rpi/controller/controller.cpp\n> > index df45dcd3..5eee0693 100644\n> > --- a/src/ipa/rpi/controller/controller.cpp\n> > +++ b/src/ipa/rpi/controller/controller.cpp\n> > @@ -145,6 +145,12 @@ int Controller::read(char const *filename)\n> >\n> > int Controller::createAlgorithm(const std::string &name, const YamlObject ¶ms)\n> > {\n> > + if (name.find(\"disable\") == 0) {\n>\n> Is it worth using name.find(\"blah\") != std::string::npos here so we\n> can also do \"rpi.nn_awb.disable\"?\n\nYes, that's a good suggestion. However, I'm slightly inclined to stick\nwith our documented design where the final token in the string (so\nafter the last period) names the algorithm type (hence our code has\ncalls like \"find_algorithm(\"awb\")). So putting \"disable\" at the end\nlooks a bit like a \"disable\" algorithm. Conversely, adding tokens\nbefore the algorithm type is already documented as the way to add\nalternative versions of algorithms so it feels slightly less like an\nabuse of the naming convention. Maybe? I agree it's all a bit\nmarginal, and overall I'm not too bothered...\n\n(Of course, I haven't looked at Barnabas' suggestion yet, which may\nchange things again.)\n\nThanks\nDavid\n\n>\n> With or without that\n>\n> Reviewed-by: Naushir Patuck \n>\n>\n> > + LOG(RPiController, Debug)\n> > + << \"Algorithm \\\"\" << name << \"\\\" is disabled\";\n> > + return 0;\n> > + }\n> > +\n> > auto it = getAlgorithms().find(name);\n> > if (it == getAlgorithms().end()) {\n> > LOG(RPiController, Warning)\n> > --\n> > 2.47.3\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C767AC3257\n\tfor ;\n\tThu, 11 Dec 2025 11:28:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E32FE615BC;\n\tThu, 11 Dec 2025 12:28:16 +0100 (CET)","from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com\n\t[IPv6:2607:f8b0:4864:20::72c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 725C8609D8\n\tfor ;\n\tThu, 11 Dec 2025 12:28:15 +0100 (CET)","by mail-qk1-x72c.google.com with SMTP id\n\taf79cd13be357-8b9f73728e8so86724685a.0\n\tfor ;\n\tThu, 11 Dec 2025 03:28:15 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"IJiveknf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1765452494; x=1766057294;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=FaJ8/joJzsjDvVy/J6TK9ooIPk6WNlDqzF/NHmstqB0=;\n\tb=IJiveknf0nKaBgt2pAINXmNnnILd+tDIxVcpEXIIxBBIERE6VyNamnUrxDaWD4q0wf\n\tDQZiezRmt81JzDpethxjc6gQeFhxy7t4w4LfkjJXv2ARoNnGkWj3o4YoIbOvdTpoIu3W\n\trW0eI4DjEpUqaEZTpbP+o/Mw4b9SqhW4Qf6y6teQHHa1RP9rWWHRNNA4E/tiIF+8USbo\n\t8JWN8Go3Q6tjnob1IYQYe78X0Ctp2B8mn9KEvN2Bvuhc8e9j09S5A40/NM0wQtyISH41\n\tK4OnY1I7DHSQrbIrXD7QICpbSqtwrGLBA7Pw4zK/q+1cciSnuy4xFWefBw0UV5UOn7eh\n\tnDIw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765452494; x=1766057294;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=FaJ8/joJzsjDvVy/J6TK9ooIPk6WNlDqzF/NHmstqB0=;\n\tb=sZBQS3+VhTtYcH1JKPxunkKYKNbJMMaitdlZLBnrqyeEsrH6C9Qq0eXYotcTiojPG5\n\t2u+vqSSylgoP4eAtTkpxlo32M+vxaAcTTvKuSck1sRegjQdCGfd82Bx7Z9XjlWqwAowq\n\tkOc1TdH+c1nPAh3YJYjxMRB6pN1+KpZx3oDjy5fc9PGIZzrg9f1T5/Y6IHKfz/JpT8Vb\n\tJh40b8EWPayLKhWVceu8iLp0coMcEkwuOlle8K4wACvFc+2lUSTTvwcSfEIV+ISHe/Yv\n\tpqUEoQAOJ+lNfrgBIwSLnmHtBIBIQ3rIsRL5yXr2lU/ZN03i5wJZ4GVGrrVFX9kNgt0B\n\t7r8A==","X-Gm-Message-State":"AOJu0YwEgziTNXOC9Ma20kVt7/tHsVe/HGXvg0Qthb60ziZ0pBhoF8vS\n\tad4QWfNJPp5rXZnbRgeu9TkIMnoCLF7781DHEss1fZT0qcY5eobFjwb1JjJvskPKOsvZ+fytKoE\n\txGnnCTRdNfPJGDjUFPoEg8MQPxbescpEdvNon5eaicrGz33ZjXg4Z","X-Gm-Gg":"AY/fxX5EYDNUy7BhgVorbYiLaI23UMJ6Wip3xXqUbocnguobf77iQ7ikIDBqaz8JAV4\n\tbydP/h6+CONoWFIOZbmsK5B6bigMknrnM1bemCgvzb0IQlLPux1D2y2RtT0IvSwxWuI16hM/LTX\n\tkqCw+uZyGSfCDuXkP7vF5noUpGWAHRHi5F+NoDgS0VG4X4lk+VExc9iBbh8GCbFzw6NMmFo0CuT\n\tbmLzMHgHTwbX18hHxgtqNpzJzRNP849q/AAUv+OjDZCtYDqceNthIts4BvvmdWmqqvMrzLEiWM0\n\tcd6cSz8Uk34pouHRoxF9fAJalJ5NvJ0Zvswy6N4eQj2SHoH9CB9kCI2mcmZGOu3x4Lck8sb01wt\n\tybYG7KhMgNcwg6xxT7mT+F4Y=","X-Google-Smtp-Source":"AGHT+IHxS0yXic9xPi/OxjW95aCrGKt7Hrs2qzXXudKUcx03QCBMKkIGfe9VBn9gCh11nO9LCkKjfyAWF+ptCjRdIfc=","X-Received":"by 2002:ac8:574b:0:b0:4ee:168a:9ebb with SMTP id\n\td75a77b69052e-4f1b1b4dd8dmr71645621cf.58.1765452494222;\n\tThu, 11 Dec 2025 03:28:14 -0800 (PST)","MIME-Version":"1.0","References":"<20251024144049.3311-1-david.plowman@raspberrypi.com>\n\t<20251024144049.3311-5-david.plowman@raspberrypi.com>\n\t","In-Reply-To":"","From":"David Plowman ","Date":"Thu, 11 Dec 2025 11:28:02 +0000","X-Gm-Features":"AQt7F2ohDNIWuzNs4YBxtT6xksnUPWZp9aGiHXeLfiAzKKFG7d_5NyPVEsHsYBE","Message-ID":"","Subject":"Re: [PATCH 4/4] ipa: rpi: controller: Ignore algorithms starting\n\twith disable","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org, \n\tPeter Bailey ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]