[{"id":37863,"web_url":"https://patchwork.libcamera.org/comment/37863/","msgid":"<176907346904.3882822.9527924957584309344@neptunite.rasen.tech>","date":"2026-01-22T09:17:49","subject":"Re: [PATCH v1 34/35] ipa: rkisp1: Increase regulation speed","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-10-24 17:50:58)\n> Now that the rkisp1 is well synchronized, we can safely increase the\n> regulation speed and reduce the number of startup frames. With current\n> settings, the results based on the stats for frame 0 are active on frame\n> 5. Setting the startup frames to 7 leaves room for one additional lost\n> frame.\n> \n> Signed-off-by: Stefan Klug \n\nLooks good to me.\n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index 71ad3a01d90c..e8f2324797d4 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -122,6 +122,9 @@ uint8_t Agc::computeHistogramPredivider(const Size &size,\n> Agc::Agc()\n> {\n> supportsRaw_ = true;\n> + /* rkisp1 is well synchronized, increase the speed. */\n> + regulationSpeed_ = 0.6;\n> + numStartupFrames_ = 7;\n> }\n> \n> /**\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A33E2BDCBF\n\tfor ;\n\tThu, 22 Jan 2026 09:17:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4FD8C61FF7;\n\tThu, 22 Jan 2026 10:17:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2254761FBF\n\tfor ;\n\tThu, 22 Jan 2026 10:17:57 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:8816:a947:ebed:2ec7])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 37F1B2DD;\n\tThu, 22 Jan 2026 10:17:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"k805FGpq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769073444;\n\tbh=dLnCzZ145CJgQ9oXaMa2kAgKYBD9h65lEd249km4d38=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=k805FGpqJ7CIYsswZXak12g1pLPufMjHPhaYMsTTeMppGLHIj2Tljw5yf8hJnComv\n\tomAZp5COcOl1q3zKrKIQ88thWcsbNpNiP/BIZbujUqe5hBHd4niF6tcIf2m3rm6u6h\n\tn4dt36mU/sHsBMVkyaxS1K3vCoeIP8fxjOX5p1I0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251024085130.995967-35-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>\n\t<20251024085130.995967-35-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 34/35] ipa: rkisp1: Increase regulation speed","From":"Paul Elder ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 22 Jan 2026 18:17:49 +0900","Message-ID":"<176907346904.3882822.9527924957584309344@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]