{"id":24800,"url":"https://patchwork.libcamera.org/api/patches/24800/?format=json","web_url":"https://patchwork.libcamera.org/patch/24800/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251024085130.995967-35-stefan.klug@ideasonboard.com>","date":"2025-10-24T08:50:58","name":"[v1,34/35] ipa: rkisp1: Increase regulation speed","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5dea7ca41d25327eaff9134c04e5f45f05ce0e23","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24800/mbox/","series":[{"id":5524,"url":"https://patchwork.libcamera.org/api/series/5524/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5524","date":"2025-10-24T08:50:24","name":"rkisp1: pipeline rework for PFC","version":1,"mbox":"https://patchwork.libcamera.org/series/5524/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24800/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24800/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D4DABE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Oct 2025 08:53:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D42A06096A;\n\tFri, 24 Oct 2025 10:53:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D8C9960938\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Oct 2025 10:53:20 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7edc:62f4:c118:1549])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 61CFB21D0; \n\tFri, 24 Oct 2025 10:51:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c3Fz9iag\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761295895;\n\tbh=6jtGsTXG0bEb6iM/1wRCadoSIAITU2l4SiCkOBLmmng=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=c3Fz9iagT6AhALsIbEKdBg+cErkPWXglQeYiew+jSI9e4Tx+d3J4eARJU3HmP/dTi\n\t8Fsv03AMvLwurrdyVHus6QemrcBT2pKayk2ZHzBKmhQlEqy7GHCe03v4b9pKVGHH/6\n\tr0YkmLamdcC9Ip1fAD1+SY9jAPkGBD34NgTqf7o8=","From":"Stefan Klug <stefan.klug@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug <stefan.klug@ideasonboard.com>","Subject":"[PATCH v1 34/35] ipa: rkisp1: Increase regulation speed","Date":"Fri, 24 Oct 2025 10:50:58 +0200","Message-ID":"<20251024085130.995967-35-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Now that the rkisp1 is well synchronized, we can safely increase the\nregulation speed and reduce the number of startup frames.  With current\nsettings, the results based on the stats for frame 0 are active on frame\n5. Setting the startup frames to 7 leaves room for one additional lost\nframe.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/agc.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 71ad3a01d90c..e8f2324797d4 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -122,6 +122,9 @@ uint8_t Agc::computeHistogramPredivider(const Size &size,\n Agc::Agc()\n {\n \tsupportsRaw_ = true;\n+\t/* rkisp1 is well synchronized, increase the speed. */\n+\tregulationSpeed_ = 0.6;\n+\tnumStartupFrames_ = 7;\n }\n \n /**\n","prefixes":["v1","34/35"]}