[{"id":37860,"web_url":"https://patchwork.libcamera.org/comment/37860/","msgid":"<176907344472.3882822.15228463722279746148@neptunite.rasen.tech>","date":"2026-01-22T09:17:24","subject":"Re: [PATCH v1 29/35] ipa: libipa: Reduce log level when obtaining an\n\tuninitialized frame context","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-10-24 17:50:53)\n> With the pipeline rework, it is a valid condition to obtain an\n> uninitialized frame context. Explain that in the comment and reduce the\n> log level.\n> \n> The same applies to the \"already initialized\" case.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/libipa/fc_queue.h | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/ipa/libipa/fc_queue.h b/src/ipa/libipa/fc_queue.h\n> index 812022c496ed..75e0072a6eb4 100644\n> --- a/src/ipa/libipa/fc_queue.h\n> +++ b/src/ipa/libipa/fc_queue.h\n> @@ -64,7 +64,7 @@ public:\n> * an error condition ?\n> */\n> if (frame != 0 && frame <= frameContext.frame_)\n> - LOG(FCQueue, Warning)\n> + LOG(FCQueue, Debug)\n> << \"Frame \" << frame << \" already initialised\";\n> else\n> init(fc, frame);\n> @@ -112,12 +112,12 @@ public:\n> * The frame context has been retrieved before it was\n> * initialised through the initialise() call. This indicates an\n> * algorithm attempted to access a Frame context before it was\n> - * queued to the IPA. Controls applied for this request may be\n> - * left unhandled.\n> - *\n> - * \\todo Set an error flag for per-frame control errors.\n> + * queued to the IPA. This can happen when a frame was dropped\n> + * in the kernel. Then one frame will not be queued for the\n> + * requests to catch up, but the pipeline will still call\n> + * prepare on that frame.\n> */\n> - LOG(FCQueue, Warning)\n> + LOG(FCQueue, Debug)\n> << \"Obtained an uninitialised FrameContext for \" << frame;\n> \n> init(fc, frame);\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A0919BDCBF\n\tfor ;\n\tThu, 22 Jan 2026 09:17:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5906A61FDB;\n\tThu, 22 Jan 2026 10:17:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DC7761FBF\n\tfor ;\n\tThu, 22 Jan 2026 10:17:30 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:8816:a947:ebed:2ec7])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 700C52DD;\n\tThu, 22 Jan 2026 10:16:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aXZau4D3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769073418;\n\tbh=0GzMYLEDV6+8s+da6WNohNqX3aX+FBsD5+ZnjqXqUW4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=aXZau4D3IHam1MrNcVllrXcdP3V7bVQOyeegEwwm3TdoXMiKeqSh/kyQX02ZNE0ND\n\tPfDNfl8W4yHqI38hO2BAJo4zC5zDn1ul+guLil8tkKlaDn6fV9uDz/fQIV5/i8IjRa\n\tOV/JvgWTIo58W9qgNLKFdEGKNsc0o63w2mbOjxk8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251024085130.995967-30-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>\n\t<20251024085130.995967-30-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 29/35] ipa: libipa: Reduce log level when obtaining an\n\tuninitialized frame context","From":"Paul Elder ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 22 Jan 2026 18:17:24 +0900","Message-ID":"<176907344472.3882822.15228463722279746148@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]