{"id":24795,"url":"https://patchwork.libcamera.org/api/patches/24795/?format=json","web_url":"https://patchwork.libcamera.org/patch/24795/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251024085130.995967-30-stefan.klug@ideasonboard.com>","date":"2025-10-24T08:50:53","name":"[v1,29/35] ipa: libipa: Reduce log level when obtaining an uninitialized frame context","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"023e06ce8dbf02e2d93809614cb612f368d9d1b0","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24795/mbox/","series":[{"id":5524,"url":"https://patchwork.libcamera.org/api/series/5524/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5524","date":"2025-10-24T08:50:24","name":"rkisp1: pipeline rework for PFC","version":1,"mbox":"https://patchwork.libcamera.org/series/5524/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24795/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24795/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7670BE080\n\tfor ;\n\tFri, 24 Oct 2025 08:53:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78DD660947;\n\tFri, 24 Oct 2025 10:53:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 72EA860938\n\tfor ;\n\tFri, 24 Oct 2025 10:53:06 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7edc:62f4:c118:1549])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id D0D6B4B0C; \n\tFri, 24 Oct 2025 10:51:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lcGytAZb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761295880;\n\tbh=Ik+5kjY+0todhct0SOiC4RS7hv34hhfk2uGJKgSEv/Y=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=lcGytAZbkR4mOY+Sja1lZLX98lKIdwVHuvNcJC+4YmGiXJZBEMlNw7be5S+EPdhLU\n\tLXqn+dJfya8Q854lAF4vYI7C7Sf1nggofEHSTpFqJiv05aZJLIUjzp4CFyTNUIGKMy\n\tSSTXtAyrr0TsUk0g0pylAzZlo8UJ3lVouqUtofJc=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 29/35] ipa: libipa: Reduce log level when obtaining an\n\tuninitialized frame context","Date":"Fri, 24 Oct 2025 10:50:53 +0200","Message-ID":"<20251024085130.995967-30-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"With the pipeline rework, it is a valid condition to obtain an\nuninitialized frame context. Explain that in the comment and reduce the\nlog level.\n\nThe same applies to the \"already initialized\" case.\n\nSigned-off-by: Stefan Klug \n---\n src/ipa/libipa/fc_queue.h | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/src/ipa/libipa/fc_queue.h b/src/ipa/libipa/fc_queue.h\nindex 812022c496ed..75e0072a6eb4 100644\n--- a/src/ipa/libipa/fc_queue.h\n+++ b/src/ipa/libipa/fc_queue.h\n@@ -64,7 +64,7 @@ public:\n \t\t * an error condition ?\n \t\t */\n \t\tif (frame != 0 && frame <= frameContext.frame_)\n-\t\t\tLOG(FCQueue, Warning)\n+\t\t\tLOG(FCQueue, Debug)\n \t\t\t\t<< \"Frame \" << frame << \" already initialised\";\n \t\telse\n \t\t\tinit(fc, frame);\n@@ -112,12 +112,12 @@ public:\n \t\t * The frame context has been retrieved before it was\n \t\t * initialised through the initialise() call. This indicates an\n \t\t * algorithm attempted to access a Frame context before it was\n-\t\t * queued to the IPA. Controls applied for this request may be\n-\t\t * left unhandled.\n-\t\t *\n-\t\t * \\todo Set an error flag for per-frame control errors.\n+\t\t * queued to the IPA. This can happen when a frame was dropped\n+\t\t * in the kernel. Then one frame will not be queued for the\n+\t\t * requests to catch up, but the pipeline will still call\n+\t\t * prepare on that frame.\n \t\t */\n-\t\tLOG(FCQueue, Warning)\n+\t\tLOG(FCQueue, Debug)\n \t\t\t<< \"Obtained an uninitialised FrameContext for \" << frame;\n \n \t\tinit(fc, frame);\n","prefixes":["v1","29/35"]}