[{"id":37859,"web_url":"https://patchwork.libcamera.org/comment/37859/","msgid":"<176907343747.3882822.3347915923638486922@neptunite.rasen.tech>","date":"2026-01-22T09:17:17","subject":"Re: [PATCH v1 28/35] pipline: rkisp1: Reinstantiate\n\tmaxQueuedRequestsDevice limit","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-10-24 17:50:52)\n> With the pipeline rework, the maxQueuedRequestsDevice should not be\n> necessary anymore, as prepare() and therefore the calculation for the\n> ISP regulation is called only as late as possible when a params buffer\n> was dequeued.\n> \n> However with unlimited maxQueuedRequestsDevice all the incoming requests\n> get immediately queued to the ipa with the sensor sequence number that\n> was anticipated for that request at queueRequestDevice time. Now when\n> the correction tries to mitigate dropped sequence numbers, it will call\n> computeParams() with sensor frame numbers that were not anticipated for\n> the requests queued to the IPA. There still might be a better solution\n> to this, but reinstantiating the limit reduces the effect.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index cd9364cb8950..2d78721be63a 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -764,7 +764,7 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n> */\n> \n> PipelineHandlerRkISP1::PipelineHandlerRkISP1(CameraManager *manager)\n> - : PipelineHandler(manager), hasSelfPath_(true)\n> + : PipelineHandler(manager, kRkISP1MinBufferCount), hasSelfPath_(true)\n\nThe min buffer count doesn't sound like the right value to use for maxQueuedRequestsDevice...?\n\n\nPaul\n\n> {\n> }\n> \n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0EA45BDCBF\n\tfor ;\n\tThu, 22 Jan 2026 09:17:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BBAB361FC4;\n\tThu, 22 Jan 2026 10:17:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8526F61FBF\n\tfor ;\n\tThu, 22 Jan 2026 10:17:23 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:8816:a947:ebed:2ec7])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 93C64324;\n\tThu, 22 Jan 2026 10:16:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"syg20Ye0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769073411;\n\tbh=y33+Z6IW/nIDlc+YKTOpmOfouVBiuGMFZppKhQHAvVs=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=syg20Ye04yojxPoWEEPc+/BtUT3qRWKupqXDyLMbU+BV8r5ajDkgLlTjPWMZQ/02r\n\tzu0044jC8H02aTsojoHDw+9em16g741boyCVJ1zKN9wZZve7ReQRvsLTzd5DMcCxw8\n\t+kYMcVuNEDgT+zkqYlKfSjttOn84I+YJfA31yhYg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251024085130.995967-29-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>\n\t<20251024085130.995967-29-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 28/35] pipline: rkisp1: Reinstantiate\n\tmaxQueuedRequestsDevice limit","From":"Paul Elder ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 22 Jan 2026 18:17:17 +0900","Message-ID":"<176907343747.3882822.3347915923638486922@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]