{"id":24792,"url":"https://patchwork.libcamera.org/api/patches/24792/?format=json","web_url":"https://patchwork.libcamera.org/patch/24792/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251024085130.995967-27-stefan.klug@ideasonboard.com>","date":"2025-10-24T08:50:50","name":"[v1,26/35] ipa: rkisp1: awb: Ignore empty AWB statistics","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ec9b319c1b4926ca874e058b63c625e73412d8da","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24792/mbox/","series":[{"id":5524,"url":"https://patchwork.libcamera.org/api/series/5524/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5524","date":"2025-10-24T08:50:24","name":"rkisp1: pipeline rework for PFC","version":1,"mbox":"https://patchwork.libcamera.org/series/5524/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24792/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24792/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05C8FBE080\n\tfor ;\n\tFri, 24 Oct 2025 08:52:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B3BA460941;\n\tFri, 24 Oct 2025 10:52:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 450CE608FE\n\tfor ;\n\tFri, 24 Oct 2025 10:52:56 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7edc:62f4:c118:1549])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id A8F1C4B0C; \n\tFri, 24 Oct 2025 10:51:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bDeLakYX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761295870;\n\tbh=eByHVcvUquYqQ2+UqMyFSY2oHfGcKMqRDTkbu8g8WQY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=bDeLakYXKLE1w3Npi9ysOlKh3NLM41/H4PMA9z2AUnYxgcjCYsdRNVDDByLKQIIff\n\tuhLjwJjU6q0rb02XSob8PKQNsOV6eysyGMevYJ6G50brG+C04OxqsLrCt5AmdOsXKO\n\tkslYmle72jf5khbKrEa3JCgT3XVHi1idleavg+Pg=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 26/35] ipa: rkisp1: awb: Ignore empty AWB statistics","Date":"Fri, 24 Oct 2025 10:50:50 +0200","Message-ID":"<20251024085130.995967-27-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When the AWB engine doesn't find a valid pixel because all pixels lie\noutside the configured colour range it returns an AWB measurement value\nof 255, 255, 255. This leaves the regulation in an unrecoverable state\nnoticeable by a completely green image. Fix that by skipping the AWB\ncalculation in case there were no valid pixels.\n\nSigned-off-by: Stefan Klug \n---\n src/ipa/rkisp1/algorithms/awb.cpp | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 27109478c340..81c767531c03 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -313,6 +313,11 @@ void Awb::process(IPAContext &context,\n \t\treturn;\n \t}\n \n+\tif (awb->awb_mean[0].cnt == 0) {\n+\t\tLOG(RkISP1Awb, Warning) << \"AWB statistics are empty\";\n+\t\treturn;\n+\t}\n+\n \tRGB rgbMeans = calculateRgbMeans(frameContext, awb);\n \n \t/*\n","prefixes":["v1","26/35"]}