{"id":24788,"url":"https://patchwork.libcamera.org/api/patches/24788/?format=json","web_url":"https://patchwork.libcamera.org/patch/24788/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251024085130.995967-23-stefan.klug@ideasonboard.com>","date":"2025-10-24T08:50:46","name":"[v1,22/35] ipa: rkisp1: Allow processStats to be called without stats buffer","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b2c24e359c3fd11dee99bdf5e0d664026ee67ffa","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24788/mbox/","series":[{"id":5524,"url":"https://patchwork.libcamera.org/api/series/5524/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5524","date":"2025-10-24T08:50:24","name":"rkisp1: pipeline rework for PFC","version":1,"mbox":"https://patchwork.libcamera.org/series/5524/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24788/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24788/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 72FC9C3259\n\tfor ;\n\tFri, 24 Oct 2025 08:52:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 307DC608DE;\n\tFri, 24 Oct 2025 10:52:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B0A2608C7\n\tfor ;\n\tFri, 24 Oct 2025 10:52:44 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7edc:62f4:c118:1549])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 872922363; \n\tFri, 24 Oct 2025 10:50:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XR76qxYN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761295858;\n\tbh=bRWFbrF4vkcWee4e9c0ihLXAwb+PcLCFFzuY48wyNhg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=XR76qxYNHLnTRRVCbvhhLCeZLSShOkkjxfUpmGPifLCPTNh72oZL73SZGIThLm4nW\n\tcqJaxEKdm1LY3kd5tFsjoMT7TOW35gXkI8GctqwLPDdbaKbwz4qnboyUJILjqqH/lP\n\tvLNSvKkZr5EvoJIk/gRak3jAW8588p4rQ8RFKAXE=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 22/35] ipa: rkisp1: Allow processStats to be called\n\twithout stats buffer","Date":"Fri, 24 Oct 2025 10:50:46 +0200","Message-ID":"<20251024085130.995967-23-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When there are no stats available for a frame, it still makes sense\nto call processStats to fill in the metadata of that frame. This mechanism is\nalready used for the raw path. Allow it's use for no-raw also.\n\n\nSigned-off-by: Stefan Klug \n---\n src/ipa/rkisp1/rkisp1.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 7a7b7682e242..01b30c947a0a 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -389,7 +389,7 @@ void IPARkISP1::processStats(const uint32_t frame, const uint32_t bufferId,\n \t * provided.\n \t */\n \tconst rkisp1_stat_buffer *stats = nullptr;\n-\tif (!context_.configuration.raw)\n+\tif (bufferId != 0)\n \t\tstats = reinterpret_cast(\n \t\t\tmappedBuffers_.at(bufferId).planes()[0].data());\n \n","prefixes":["v1","22/35"]}